From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: claudiu beznea <claudiu.beznea@tuxon.dev>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<p.zabel@pengutronix.de>, <yoshihiro.shimoda.uh@renesas.com>,
<geert+renesas@glider.be>, <wsa+renesas@sang-engineering.com>,
<biju.das.jz@bp.renesas.com>,
<prabhakar.mahadev-lad.rj@bp.renesas.com>,
<sergei.shtylyov@cogentembedded.com>,
<mitsuhiro.kimura.kc@renesas.com>, <masaru.nagai.vx@renesas.com>
Cc: <netdev@vger.kernel.org>, <linux-renesas-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH 02/13] net: ravb: Use pm_runtime_resume_and_get()
Date: Fri, 24 Nov 2023 22:02:03 +0300 [thread overview]
Message-ID: <c9424992-98cd-c675-22dd-360b7392054b@omp.ru> (raw)
In-Reply-To: <33a44057-eefa-44ba-8e06-b6eb8bd79e59@tuxon.dev>
On 11/21/23 8:57 AM, claudiu beznea wrote:
[...]
>>> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>>>
>>> pm_runtime_get_sync() may return with error. In case it returns with error
>>> dev->power.usage_count needs to be decremented. pm_runtime_resume_and_get()
>>> takes care of this. Thus use it.
>>>
>>> Along with this pm_runtime_resume_and_get() and reset_control_deassert()
>>> were moved before alloc_etherdev_mqs() to simplify the error path.
>>
>> I don't see how it simplifies the error path...
>
> By not changing it... Actually, I took the other approach: you suggested in
But it does need to be changed! It's not currently in the reverse order
compared to the buildup path...
> patch 1 to re-arrange the error path, I did it the other way around:
> changed the initialization path...
That way you needlessly obfuscate (by moving the code around) the core
change you do in this patch: switching from calling pm_runtime_get_sync()
to calling pm_runtime_resume_and_get(). :-/
[...]
>>> Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
>>> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>> [...]
MBR, Sergey
next prev parent reply other threads:[~2023-11-24 19:02 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 8:45 [PATCH 00/13] net: ravb: Add suspend to RAM and runtime PM support for RZ/G3S Claudiu
2023-11-20 8:45 ` [PATCH 01/13] net: ravb: Check return value of reset_control_deassert() Claudiu
2023-11-20 19:03 ` Sergey Shtylyov
2023-11-21 5:59 ` claudiu beznea
2023-11-24 19:04 ` Sergey Shtylyov
2023-11-20 8:45 ` [PATCH 02/13] net: ravb: Use pm_runtime_resume_and_get() Claudiu
2023-11-20 19:23 ` Sergey Shtylyov
2023-11-21 5:57 ` claudiu beznea
2023-11-24 19:02 ` Sergey Shtylyov [this message]
2023-11-20 8:45 ` [PATCH 03/13] net: ravb: Make write access to CXR35 first before accessing other EMAC registers Claudiu
2023-11-20 19:44 ` Sergey Shtylyov
2023-11-21 6:02 ` claudiu beznea
2023-11-23 19:30 ` Sergey Shtylyov
2023-11-20 8:45 ` [PATCH 04/13] net: ravb: Start TX queues after HW initialization succeeded Claudiu
2023-11-20 19:49 ` Sergey Shtylyov
2023-11-20 8:45 ` [PATCH 05/13] net: ravb: Stop DMA in case of failures on ravb_open() Claudiu
2023-11-20 20:01 ` Sergey Shtylyov
2023-11-20 8:45 ` [PATCH 06/13] net: ravb: Let IP specific receive function to interrogate descriptors Claudiu
2023-11-23 16:37 ` Sergey Shtylyov
2023-11-23 17:15 ` claudiu beznea
2023-11-24 17:27 ` Sergey Shtylyov
2023-11-20 8:46 ` [PATCH 07/13] net: ravb: Rely on PM domain to enable gptp_clk Claudiu
2023-11-22 16:59 ` Sergey Shtylyov
2023-11-20 8:46 ` [PATCH 08/13] net: ravb: Rely on PM domain to enable refclk Claudiu
2023-11-22 17:31 ` Sergey Shtylyov
2023-11-23 8:48 ` Geert Uytterhoeven
2023-11-23 17:10 ` claudiu beznea
2023-11-23 19:26 ` Sergey Shtylyov
2023-11-20 8:46 ` [PATCH 09/13] net: ravb: Make reset controller support mandatory Claudiu
2023-11-21 18:46 ` Sergey Shtylyov
2023-11-24 8:07 ` Geert Uytterhoeven
2023-11-20 8:46 ` [PATCH 10/13] net: ravb: Switch to SYSTEM_SLEEP_PM_OPS()/RUNTIME_PM_OPS() and pm_ptr() Claudiu
2023-11-21 20:29 ` Sergey Shtylyov
2023-12-06 11:36 ` Geert Uytterhoeven
2023-11-20 8:46 ` [PATCH 11/13] net: ravb: Use tabs instead of spaces Claudiu
2023-11-21 18:43 ` Sergey Shtylyov
2023-11-20 8:46 ` [PATCH 12/13] net: ravb: Assert/deassert reset on suspend/resume Claudiu
2023-11-21 19:13 ` Sergey Shtylyov
2023-11-22 16:41 ` Sergey Shtylyov
2023-11-20 8:46 ` [PATCH 13/13] net: ravb: Add runtime PM support Claudiu
2023-11-22 16:25 ` Sergey Shtylyov
2023-11-23 17:04 ` claudiu beznea
2023-11-23 19:19 ` Sergey Shtylyov
2023-11-24 18:03 ` claudiu beznea
2023-11-27 14:05 ` Geert Uytterhoeven
2023-11-27 14:46 ` claudiu beznea
2023-11-28 9:23 ` claudiu beznea
2023-11-27 19:01 ` Sergey Shtylyov
2023-11-30 17:35 ` Simon Horman
2023-11-20 20:48 ` [PATCH 00/13] net: ravb: Add suspend to RAM and runtime PM support for RZ/G3S Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9424992-98cd-c675-22dd-360b7392054b@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=masaru.nagai.vx@renesas.com \
--cc=mitsuhiro.kimura.kc@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®