From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
claudiu beznea <claudiu.beznea@tuxon.dev>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <p.zabel@pengutronix.de>,
<yoshihiro.shimoda.uh@renesas.com>,
<wsa+renesas@sang-engineering.com>, <biju.das.jz@bp.renesas.com>,
<prabhakar.mahadev-lad.rj@bp.renesas.com>,
<sergei.shtylyov@cogentembedded.com>,
<mitsuhiro.kimura.kc@renesas.com>, <masaru.nagai.vx@renesas.com>,
<netdev@vger.kernel.org>, <linux-renesas-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH 13/13] net: ravb: Add runtime PM support
Date: Mon, 27 Nov 2023 22:01:16 +0300 [thread overview]
Message-ID: <ec9b6604-839f-d31f-59c6-72367804d06a@omp.ru> (raw)
In-Reply-To: <CAMuHMdVCRXYKtcwaC=v-HhJW-PLV-zhj_3GmeU6Vu1JOK_eu0Q@mail.gmail.com>
On 11/27/23 5:05 PM, Geert Uytterhoeven wrote:
[...]
>>>>>> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>>>>>
>>>>>> RZ/G3S supports enabling/disabling clocks for its modules (including
>>>>>> Ethernet module). For this commit adds runtime PM support which
>>>>>> relies on PM domain to enable/disable Ethernet clocks.
>>>>>
>>>>> That's not exactly something new in RZ/G3S. The ravb driver has unconditional
>>>>> RPM calls already in the probe() and remove() methods...
>>>>> And the sh_eth driver
>>>>> has RPM support since 2009...
>>>>>
>>>>>> At the end of probe ravb_pm_runtime_put() is called which will turn
>>>>>
>>>>> I'd suggest a shorter name, like ravb_rpm_put() but (looking at this function)
>>>>>> off the Ethernet clocks (if no other request arrives at the driver).
>>>>>> After that if the interface is brought up (though ravb_open()) then
>>>>>> the clocks remain enabled until interface is brought down (operation
>>>>>> done though ravb_close()).
>>>>>>
>>>>>> If any request arrives to the driver while the interface is down the
>>>>>> clocks are enabled to serve the request and then disabled.
>>>>>>
>>>>>> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
[...]
> Sergey: does sh_eth.c really reinitialize the hardware completely after
> pm_runtime_get_sync()?
Well, even with the original Magnus' commit that added the RPM support (bcd5149ded6b2edbf3732fa1483600a716b1cba6) it wasn't so -- sh_eth_open()
indeed seemed to re-init everything (but not TSU!) but sh_eth_get_stats()
surely didn't (the RPM calls there have been removed since); other RPM
"wrappers" have been added to the driver methods since -- which also
don't init anything... thus the comment in sh_eth_runtime_nop(() seems
to be wrong from the very start...
[...]
> Gr{oetje,eeting}s,
>
> Geert
MBR, Sergey
next prev parent reply other threads:[~2023-11-27 19:01 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 8:45 [PATCH 00/13] net: ravb: Add suspend to RAM and runtime PM support for RZ/G3S Claudiu
2023-11-20 8:45 ` [PATCH 01/13] net: ravb: Check return value of reset_control_deassert() Claudiu
2023-11-20 19:03 ` Sergey Shtylyov
2023-11-21 5:59 ` claudiu beznea
2023-11-24 19:04 ` Sergey Shtylyov
2023-11-20 8:45 ` [PATCH 02/13] net: ravb: Use pm_runtime_resume_and_get() Claudiu
2023-11-20 19:23 ` Sergey Shtylyov
2023-11-21 5:57 ` claudiu beznea
2023-11-24 19:02 ` Sergey Shtylyov
2023-11-20 8:45 ` [PATCH 03/13] net: ravb: Make write access to CXR35 first before accessing other EMAC registers Claudiu
2023-11-20 19:44 ` Sergey Shtylyov
2023-11-21 6:02 ` claudiu beznea
2023-11-23 19:30 ` Sergey Shtylyov
2023-11-20 8:45 ` [PATCH 04/13] net: ravb: Start TX queues after HW initialization succeeded Claudiu
2023-11-20 19:49 ` Sergey Shtylyov
2023-11-20 8:45 ` [PATCH 05/13] net: ravb: Stop DMA in case of failures on ravb_open() Claudiu
2023-11-20 20:01 ` Sergey Shtylyov
2023-11-20 8:45 ` [PATCH 06/13] net: ravb: Let IP specific receive function to interrogate descriptors Claudiu
2023-11-23 16:37 ` Sergey Shtylyov
2023-11-23 17:15 ` claudiu beznea
2023-11-24 17:27 ` Sergey Shtylyov
2023-11-20 8:46 ` [PATCH 07/13] net: ravb: Rely on PM domain to enable gptp_clk Claudiu
2023-11-22 16:59 ` Sergey Shtylyov
2023-11-20 8:46 ` [PATCH 08/13] net: ravb: Rely on PM domain to enable refclk Claudiu
2023-11-22 17:31 ` Sergey Shtylyov
2023-11-23 8:48 ` Geert Uytterhoeven
2023-11-23 17:10 ` claudiu beznea
2023-11-23 19:26 ` Sergey Shtylyov
2023-11-20 8:46 ` [PATCH 09/13] net: ravb: Make reset controller support mandatory Claudiu
2023-11-21 18:46 ` Sergey Shtylyov
2023-11-24 8:07 ` Geert Uytterhoeven
2023-11-20 8:46 ` [PATCH 10/13] net: ravb: Switch to SYSTEM_SLEEP_PM_OPS()/RUNTIME_PM_OPS() and pm_ptr() Claudiu
2023-11-21 20:29 ` Sergey Shtylyov
2023-12-06 11:36 ` Geert Uytterhoeven
2023-11-20 8:46 ` [PATCH 11/13] net: ravb: Use tabs instead of spaces Claudiu
2023-11-21 18:43 ` Sergey Shtylyov
2023-11-20 8:46 ` [PATCH 12/13] net: ravb: Assert/deassert reset on suspend/resume Claudiu
2023-11-21 19:13 ` Sergey Shtylyov
2023-11-22 16:41 ` Sergey Shtylyov
2023-11-20 8:46 ` [PATCH 13/13] net: ravb: Add runtime PM support Claudiu
2023-11-22 16:25 ` Sergey Shtylyov
2023-11-23 17:04 ` claudiu beznea
2023-11-23 19:19 ` Sergey Shtylyov
2023-11-24 18:03 ` claudiu beznea
2023-11-27 14:05 ` Geert Uytterhoeven
2023-11-27 14:46 ` claudiu beznea
2023-11-28 9:23 ` claudiu beznea
2023-11-27 19:01 ` Sergey Shtylyov [this message]
2023-11-30 17:35 ` Simon Horman
2023-11-20 20:48 ` [PATCH 00/13] net: ravb: Add suspend to RAM and runtime PM support for RZ/G3S Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec9b6604-839f-d31f-59c6-72367804d06a@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert@linux-m68k.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=masaru.nagai.vx@renesas.com \
--cc=mitsuhiro.kimura.kc@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®