From: Michal Simek <michal.simek@amd.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu,
michal.simek@xilinx.com, git@xilinx.com,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: interrupt-controller: Add Xilinx INTC binding
Date: Tue, 22 Jul 2025 10:12:09 +0200 [thread overview]
Message-ID: <c9747893-45f5-4d1b-8b7a-193eb90221e9@amd.com> (raw)
In-Reply-To: <20250722-pragmatic-nebulous-bloodhound-6251bb@kuoka>
On 7/22/25 09:40, Krzysztof Kozlowski wrote:
> On Tue, Jul 22, 2025 at 08:49:42AM +0200, Michal Simek wrote:
>> + "#interrupt-cells":
>> + const: 2
>> + description:
>> + Specifies the number of cells needed to encode an interrupt source.
>> + The value shall be a minimum of 1. The Xilinx device trees typically
>> + use 2 but the 2nd value is not used.
>> +
>> + interrupt-controller: true
>> +
>> + interrupts:
>> + maxItems: 1
>> + description:
>> + Specifies the interrupt of the parent controller from which it is chained.
>> +
>> + xlnx,kind-of-intr:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description:
>> + A 32 bit value specifying the interrupt type for each possible interrupt
>> + (1 = edge, 0 = level). The interrupt type typically comes in thru
>> + the device tree node of the interrupt generating device, but in this case
>> + the interrupt type is determined by the interrupt controller based on how
>> + it was implemented.
>
> enum: [ 0, 1 ]
It is hex value for all interrupts together.
And bit position correspond to interrupt line. And you can mix edge or level
interrupts together and this is the property which distinguish them.
I know that separate cell is normally used but it has never been converted to be
like that but interrupt-cells is 2 that binding allows using this description too.
Thanks,
Michal
prev parent reply other threads:[~2025-07-22 8:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 6:49 Michal Simek
2025-07-22 7:17 ` Krzysztof Kozlowski
2025-07-22 7:32 ` Michal Simek
2025-07-22 7:37 ` Krzysztof Kozlowski
2025-07-22 7:40 ` Krzysztof Kozlowski
2025-07-22 8:12 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9747893-45f5-4d1b-8b7a-193eb90221e9@amd.com \
--to=michal.simek@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®