From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>
Cc: kernel test robot <lkp@intel.com>, <kbuild-all@lists.01.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: sound/soc/ti/j721e-evm.c:528:34: warning: unused variable 'j721e_audio_of_match'
Date: Tue, 29 Sep 2020 09:00:02 +0300 [thread overview]
Message-ID: <c97e8363-1e8e-38fe-3214-cff47f09e459@ti.com> (raw)
In-Reply-To: <20200928180412.GA4827@sirena.org.uk>
On 28/09/2020 21.04, Mark Brown wrote:
> On Mon, Sep 28, 2020 at 10:52:54AM -0700, Nick Desaulniers wrote:
>> On Mon, Sep 28, 2020 at 12:27 AM 'Peter Ujfalusi' via Clang Built
>
>>> Right, in the attached .config:
>>> # CONFIG_OF is not set
>
>>> There must be a clean way to handle this without extensive ifedfery...
>
>> Pretty sure I just saw a patch go by wrapping another device table
>> definition in #ifdef CONFIG_OF, so it's not unusual.
>
> It's the standard solution, it's just not as clean as would be ideal :/
The ifdef would be preferred if the driver could work in non DT boot (to
save few bytes) but since it is not the case here:
https://lore.kernel.org/alsa-devel/20200928074330.13029-1-peter.ujfalusi@ti.com/
Not much point to size optimize for randconfig builds ;)
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-09-29 5:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202009271553.4OjMpGkX%lkp@intel.com>
2020-09-28 7:27 ` Peter Ujfalusi
2020-09-28 17:52 ` Nick Desaulniers
2020-09-28 18:04 ` Mark Brown
2020-09-29 6:00 ` Peter Ujfalusi [this message]
2020-09-29 11:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c97e8363-1e8e-38fe-3214-cff47f09e459@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=broonie@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®