From: Kever Yang <kever.yang@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Shawn Lin <shawn.lin@rock-chips.com>,
Huibin Hong <huibin.hong@rock-chips.com>,
Elaine Zhang <zhangqing@rock-chips.com>,
Catalin Marinas <catalin.marinas@arm.com>,
David Wu <david.wu@rock-chips.com>,
Brian Norris <briannorris@chromium.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Douglas Anderson <dianders@chromium.org>,
Will Deacon <will.deacon@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
devicetree@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Jianqun Xu <jay.xu@rock-chips.com>,
linux-kernel@vger.kernel.org, Andy Yan <andy.yan@rock-chips.com>,
Caesar Wang <wxt@rock-chips.com>,
Mark Rutland <mark.rutland@arm.com>,
Roger Chen <roger.chen@rock-chips.com>
Subject: Re: [PATCH 3/4] ARM: dts: rockchip: use pin constants to describe IO in pinctrl
Date: Wed, 10 May 2017 09:25:25 +0800 [thread overview]
Message-ID: <c98e2eaf-3e92-a6b6-5367-df31d0614d5c@rock-chips.com> (raw)
In-Reply-To: <3966386.YQGqDXjHSp@phil>
Heiko,
On 05/10/2017 05:43 AM, Heiko Stuebner wrote:
> Am Mittwoch, 12. April 2017, 15:10:43 CEST schrieb Kever Yang:
>> Use command below to replace the IO naming in pinctrl:
>> sed -i -e 's/ 31 RK_FUNC_/ RK_PD7 RK_FUNC_/' arch/arm/boot/dts/rk*
>> sed -i -e 's/ 0 RK_FUNC_/ RK_PA0 RK_FUNC_/'
>> arch/arm64/boot/dts/rockchip/*
>>
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> I'm not sure, if we really want to mass-convert each and every pin.
> All pins in use right now seem to be working and it hides other
> history/blame for these entries.
Do you mean you want to leave the code already there as is, and new
code using MACRO define for IO?
This sounds reasonable, I can agree on this. I send this patch because I
see there is
a patch from Andy using MACRO for many IOs, but not complete enough
and my patch suppose to make all Rockchip IO has update.
Thanks,
- Kever
>
> In any case though, this needs to be split into separate arm32/arm64
> patches.
>
>
> Heiko
>
next prev parent reply other threads:[~2017-05-10 1:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 7:10 [PATCH 1/4] arm64: dts: rk3399: add missing qos node Kever Yang
2017-04-12 7:10 ` [PATCH 2/4] arm64: dts: rk3399: add power domain for some peripheral Kever Yang
2017-05-09 21:40 ` Heiko Stuebner
2017-05-09 22:35 ` Heiko Stübner
2017-04-12 7:10 ` [PATCH 3/4] ARM: dts: rockchip: use pin constants to describe IO in pinctrl Kever Yang
2017-05-09 21:43 ` Heiko Stuebner
2017-05-10 1:25 ` Kever Yang [this message]
2017-05-10 13:55 ` Heiko Stuebner
2017-04-12 7:10 ` [PATCH 4/4] arm64: dts: rk3399: add pinctrl for some peripheral Kever Yang
2017-05-09 21:43 ` Heiko Stuebner
2017-05-09 21:40 ` [PATCH 1/4] arm64: dts: rk3399: add missing qos node Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c98e2eaf-3e92-a6b6-5367-df31d0614d5c@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=andy.yan@rock-chips.com \
--cc=briannorris@chromium.org \
--cc=catalin.marinas@arm.com \
--cc=david.wu@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=huibin.hong@rock-chips.com \
--cc=jay.xu@rock-chips.com \
--cc=jh80.chung@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=roger.chen@rock-chips.com \
--cc=shawn.lin@rock-chips.com \
--cc=will.deacon@arm.com \
--cc=wxt@rock-chips.com \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®