From: Randy Dunlap <rdunlap@infradead.org>
To: moderated for non-subscribers <alsa-devel@alsa-project.org>
Cc: "Mylène Josserand" <mylene.josserand@bootlin.com>,
LKML <linux-kernel@vger.kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"kbuild test robot" <lkp@intel.com>
Subject: [PATCH] ASoC: codecs: fix pcm1789.c build errors
Date: Tue, 15 May 2018 21:42:28 -0700 [thread overview]
Message-ID: <c99575a2-5172-b42e-dd18-6bc763fee361@infradead.org> (raw)
From: Randy Dunlap <rdunlap@infradead.org>
Fix build errors in pcm1789.c.
The source file needs to #include <linux/gpio/consumer.h> since it
uses interfaces and macros that are provided by it.
However, it does not need to #include <linux/gpio.h>, so drop it.
Fixes these build errors:
../sound/soc/codecs/pcm1789.c: In function 'pcm1789_common_init':
../sound/soc/codecs/pcm1789.c:247:2: error: implicit declaration of function 'devm_gpiod_get_optional' [-Werror=implicit-function-declaration]
pcm1789->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
../sound/soc/codecs/pcm1789.c:247:57: error: 'GPIOD_OUT_HIGH' undeclared (first use in this function)
pcm1789->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
../sound/soc/codecs/pcm1789.c:251:2: error: implicit declaration of function 'gpiod_set_value_cansleep' [-Werror=implicit-function-declaration]
gpiod_set_value_cansleep(pcm1789->reset, 0);
Fixes: 4ae340d1be36 ("ASoC: codecs: Add support for PCM1789")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Mylène Josserand <mylene.josserand@bootlin.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
---
sound/soc/codecs/pcm1789.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
BTW, MODULE_AUTHOR() still uses @free-electrons.com.
--- lnx-417-rc4.orig/sound/soc/codecs/pcm1789.c
+++ lnx-417-rc4/sound/soc/codecs/pcm1789.c
@@ -3,7 +3,7 @@
// Copyright (C) 2018 Bootlin
// Mylène Josserand <mylene.josserand@bootlin.com>
-#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
#include <linux/module.h>
#include <linux/workqueue.h>
next reply other threads:[~2018-05-16 4:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 4:42 Randy Dunlap [this message]
2018-05-31 11:06 ` Applied "ASoC: codecs: PCM1789: include gpio/consumer.h" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c99575a2-5172-b42e-dd18-6bc763fee361@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mylene.josserand@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®