* [PATCH v2 1/2] net/mlx5: Fix null-ptr-deref in mlx5_create_inner_ttc_table()
@ 2025-04-08 15:40 Henry Martin
2025-04-08 15:40 ` [PATCH v2 2/2] net/mlx5: Fix null-ptr-deref in mlx5_create_ttc_table() Henry Martin
2025-04-08 19:40 ` [PATCH v2 1/2] net/mlx5: Fix null-ptr-deref in mlx5_create_inner_ttc_table() Markus Elfring
0 siblings, 2 replies; 3+ messages in thread
From: Henry Martin @ 2025-04-08 15:40 UTC (permalink / raw)
To: saeedm, leon, tariqt, andrew+netdev, davem, edumazet, kuba, pabeni
Cc: ayal, amirtz, bsdhenrymartin, netdev, linux-rdma, linux-kernel
Add NULL check for mlx5_get_flow_namespace() returns in
mlx5_create_inner_ttc_table() to prevent NULL pointer dereference.
Fixes: 137f3d50ad2a ("net/mlx5: Support matching on l4_type for ttc_table")
Signed-off-by: Henry Martin <bsdhenrymartin@gmail.com>
---
V1 -> V2: Add a empty line after the return statement.
drivers/net/ethernet/mellanox/mlx5/core/lib/fs_ttc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_ttc.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_ttc.c
index eb3bd9c7f66e..ecf4b60ddd96 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_ttc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_ttc.c
@@ -655,6 +655,9 @@ struct mlx5_ttc_table *mlx5_create_inner_ttc_table(struct mlx5_core_dev *dev,
}
ns = mlx5_get_flow_namespace(dev, params->ns_type);
+ if (!ns)
+ return ERR_PTR(-EOPNOTSUPP);
+
groups = use_l4_type ? &inner_ttc_groups[TTC_GROUPS_USE_L4_TYPE] :
&inner_ttc_groups[TTC_GROUPS_DEFAULT];
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v2 2/2] net/mlx5: Fix null-ptr-deref in mlx5_create_ttc_table()
2025-04-08 15:40 [PATCH v2 1/2] net/mlx5: Fix null-ptr-deref in mlx5_create_inner_ttc_table() Henry Martin
@ 2025-04-08 15:40 ` Henry Martin
2025-04-08 19:40 ` [PATCH v2 1/2] net/mlx5: Fix null-ptr-deref in mlx5_create_inner_ttc_table() Markus Elfring
1 sibling, 0 replies; 3+ messages in thread
From: Henry Martin @ 2025-04-08 15:40 UTC (permalink / raw)
To: saeedm, leon, tariqt, andrew+netdev, davem, edumazet, kuba, pabeni
Cc: ayal, amirtz, bsdhenrymartin, netdev, linux-rdma, linux-kernel
Add NULL check for mlx5_get_flow_namespace() returns in
mlx5_create_ttc_table() to prevent NULL pointer dereference.
Fixes: 137f3d50ad2a ("net/mlx5: Support matching on l4_type for ttc_table")
Signed-off-by: Henry Martin <bsdhenrymartin@gmail.com>
---
V1 -> V2: Add a empty line after the return statement.
drivers/net/ethernet/mellanox/mlx5/core/lib/fs_ttc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_ttc.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_ttc.c
index ecf4b60ddd96..18cc6960a5c1 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_ttc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_ttc.c
@@ -731,6 +731,9 @@ struct mlx5_ttc_table *mlx5_create_ttc_table(struct mlx5_core_dev *dev,
}
ns = mlx5_get_flow_namespace(dev, params->ns_type);
+ if (!ns)
+ return ERR_PTR(-EOPNOTSUPP);
+
groups = use_l4_type ? &ttc_groups[TTC_GROUPS_USE_L4_TYPE] :
&ttc_groups[TTC_GROUPS_DEFAULT];
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2 1/2] net/mlx5: Fix null-ptr-deref in mlx5_create_inner_ttc_table()
2025-04-08 15:40 [PATCH v2 1/2] net/mlx5: Fix null-ptr-deref in mlx5_create_inner_ttc_table() Henry Martin
2025-04-08 15:40 ` [PATCH v2 2/2] net/mlx5: Fix null-ptr-deref in mlx5_create_ttc_table() Henry Martin
@ 2025-04-08 19:40 ` Markus Elfring
1 sibling, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2025-04-08 19:40 UTC (permalink / raw)
To: Henry Martin, linux-rdma, netdev
Cc: LKML, Amir Tzin, Andrew Lunn, Aya Levin, David S. Miller,
Eric Dumazet, Jakub Kicinski, Leon Romanovsky, Paolo Abeni,
Saeed Mahameed, Simon Horman, Tariq Toukan
> Add NULL check for mlx5_get_flow_namespace() returns in
> mlx5_create_inner_ttc_table() to prevent NULL pointer dereference.
* Did you propose to adjust the error handling for three function
implementations from a common subdirectory initially?
* Can any other summary phrase variants become more desirable accordingly?
* Would a cover letter usually be helpful for patch series?
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-08 19:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-08 15:40 [PATCH v2 1/2] net/mlx5: Fix null-ptr-deref in mlx5_create_inner_ttc_table() Henry Martin
2025-04-08 15:40 ` [PATCH v2 2/2] net/mlx5: Fix null-ptr-deref in mlx5_create_ttc_table() Henry Martin
2025-04-08 19:40 ` [PATCH v2 1/2] net/mlx5: Fix null-ptr-deref in mlx5_create_inner_ttc_table() Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®