From: Shuah Khan <skhan@linuxfoundation.org>
To: Simon Holesch <simon@holesch.de>,
Valentina Manea <valentina.manea.m@gmail.com>,
Shuah Khan <shuah@kernel.org>, Hongren Zheng <i@zenithal.me>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] usbip: Don't submit special requests twice
Date: Tue, 28 Nov 2023 13:31:58 -0700 [thread overview]
Message-ID: <c9c09012-9df8-406b-a299-1310d9c626b2@linuxfoundation.org> (raw)
In-Reply-To: <20231128000955.119735-1-simon@holesch.de>
On 11/27/23 17:08, Simon Holesch wrote:
> Skip submitting URBs, when identical requests were already sent in
> tweak_special_requests(). Instead call the completion handler directly
> to return the result of the URB.
>
Sounds reasonable. What happens when a tweak_* routine does nothing
or returns an error.
tweak_reset_device_cmd() returns 0 when it can't get the device lock
and after calling usb_reset_device().
tweak_set_interface_cmd() and tweak_clear_halt_cmd() return the value
the usb_* routine they call. Don't these cases be handled as well?
thanks,
-- Shuah
prev parent reply other threads:[~2023-11-28 20:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 0:08 Simon Holesch
2023-11-28 20:31 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9c09012-9df8-406b-a299-1310d9c626b2@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=i@zenithal.me \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=simon@holesch.de \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®