mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: "T.J. Mercier" <tjmercier@google.com>,
	"Isaac J. Manjarres" <isaacmanjarres@google.com>
Cc: sumit.semwal@linaro.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
	kernel-team@android.com
Subject: Re: [PATCH v1] dma-buf: Include ioctl.h in UAPI header
Date: Tue, 3 Mar 2026 08:53:20 +0100	[thread overview]
Message-ID: <c9c7110b-dc23-473b-a103-cdf11ed494b0@amd.com> (raw)
In-Reply-To: <CABdmKX3FOUUq=9rriXa3BYOOAqedaLma6TXZsA5LH0gBgCAEvg@mail.gmail.com>

On 3/3/26 02:45, T.J. Mercier wrote:
> On Mon, Mar 2, 2026 at 4:23 PM Isaac J. Manjarres
> <isaacmanjarres@google.com> wrote:
>>
>> include/uapi/linux/dma-buf.h uses several macros from ioctl.h to define
>> its ioctl commands. However, it does not include ioctl.h itself. So,
>> if userspace source code tries to include the dma-buf.h file without
>> including ioctl.h, it can result in build failures.
>>
>> Therefore, include ioctl.h in the dma-buf UAPI header.
>>
>> Signed-off-by: Isaac J. Manjarres <isaacmanjarres@google.com>
> 
> Reviewed-by: T.J. Mercier <tjmercier@google.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

Going to push that to drm-misc-fixes now.

Thanks,
Christian.

      reply	other threads:[~2026-03-03  7:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03  0:23 Isaac J. Manjarres
2026-03-03  1:45 ` T.J. Mercier
2026-03-03  7:53   ` Christian König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9c7110b-dc23-473b-a103-cdf11ed494b0@amd.com \
    --to=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=isaacmanjarres@google.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=sumit.semwal@linaro.org \
    --cc=tjmercier@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®