* [PATCH v1] dma-buf: Include ioctl.h in UAPI header
@ 2026-03-03 0:23 Isaac J. Manjarres
2026-03-03 1:45 ` T.J. Mercier
0 siblings, 1 reply; 3+ messages in thread
From: Isaac J. Manjarres @ 2026-03-03 0:23 UTC (permalink / raw)
To: christian.koenig, sumit.semwal
Cc: linux-kernel, tjmercier, linux-media, dri-devel,
Isaac J. Manjarres, kernel-team
include/uapi/linux/dma-buf.h uses several macros from ioctl.h to define
its ioctl commands. However, it does not include ioctl.h itself. So,
if userspace source code tries to include the dma-buf.h file without
including ioctl.h, it can result in build failures.
Therefore, include ioctl.h in the dma-buf UAPI header.
Signed-off-by: Isaac J. Manjarres <isaacmanjarres@google.com>
---
include/uapi/linux/dma-buf.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/dma-buf.h b/include/uapi/linux/dma-buf.h
index 5a6fda66d9ad..e827c9d20c5d 100644
--- a/include/uapi/linux/dma-buf.h
+++ b/include/uapi/linux/dma-buf.h
@@ -20,6 +20,7 @@
#ifndef _DMA_BUF_UAPI_H_
#define _DMA_BUF_UAPI_H_
+#include <linux/ioctl.h>
#include <linux/types.h>
/**
--
2.53.0.473.g4a7958ca14-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] dma-buf: Include ioctl.h in UAPI header
2026-03-03 0:23 [PATCH v1] dma-buf: Include ioctl.h in UAPI header Isaac J. Manjarres
@ 2026-03-03 1:45 ` T.J. Mercier
2026-03-03 7:53 ` Christian König
0 siblings, 1 reply; 3+ messages in thread
From: T.J. Mercier @ 2026-03-03 1:45 UTC (permalink / raw)
To: Isaac J. Manjarres
Cc: christian.koenig, sumit.semwal, linux-kernel, linux-media,
dri-devel, kernel-team
On Mon, Mar 2, 2026 at 4:23 PM Isaac J. Manjarres
<isaacmanjarres@google.com> wrote:
>
> include/uapi/linux/dma-buf.h uses several macros from ioctl.h to define
> its ioctl commands. However, it does not include ioctl.h itself. So,
> if userspace source code tries to include the dma-buf.h file without
> including ioctl.h, it can result in build failures.
>
> Therefore, include ioctl.h in the dma-buf UAPI header.
>
> Signed-off-by: Isaac J. Manjarres <isaacmanjarres@google.com>
Reviewed-by: T.J. Mercier <tjmercier@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] dma-buf: Include ioctl.h in UAPI header
2026-03-03 1:45 ` T.J. Mercier
@ 2026-03-03 7:53 ` Christian König
0 siblings, 0 replies; 3+ messages in thread
From: Christian König @ 2026-03-03 7:53 UTC (permalink / raw)
To: T.J. Mercier, Isaac J. Manjarres
Cc: sumit.semwal, linux-kernel, linux-media, dri-devel, kernel-team
On 3/3/26 02:45, T.J. Mercier wrote:
> On Mon, Mar 2, 2026 at 4:23 PM Isaac J. Manjarres
> <isaacmanjarres@google.com> wrote:
>>
>> include/uapi/linux/dma-buf.h uses several macros from ioctl.h to define
>> its ioctl commands. However, it does not include ioctl.h itself. So,
>> if userspace source code tries to include the dma-buf.h file without
>> including ioctl.h, it can result in build failures.
>>
>> Therefore, include ioctl.h in the dma-buf UAPI header.
>>
>> Signed-off-by: Isaac J. Manjarres <isaacmanjarres@google.com>
>
> Reviewed-by: T.J. Mercier <tjmercier@google.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Going to push that to drm-misc-fixes now.
Thanks,
Christian.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-03 7:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-03 0:23 [PATCH v1] dma-buf: Include ioctl.h in UAPI header Isaac J. Manjarres
2026-03-03 1:45 ` T.J. Mercier
2026-03-03 7:53 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®