[PATCH 0/3] media: mali-c55: Update uAPI headers for v6.19-rc1

[PATCH 0/3] media: mali-c55: Update uAPI headers for v6.19-rc1

[Jacopo Mondi]

The Mali C55 uAPI header has been accepted in the v6.19 merge window
with the definition of the MALI_C55_PARAM_BUFFER_V1 versioning number.

However, the driver uses the v4l2-isp framework, which defines its own
versioning symbols.

Remove the Mali C55 specific version identifiers and use the one defined
by the v4l2-isp framework.

Mauro, Hans: could you collect this for your next pull requests to Linus
for v6.19 please ?

Thanks
  j

Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
Jacopo Mondi (3):
      Documentation: media: mali-c55: Use v4l2-isp version identifier
      media: mali-c55: Remove duplicated version check
      uapi: media: mali-c55-config: Remove version identifier

 Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst | 2 +-
 drivers/media/platform/arm/mali-c55/mali-c55-params.c          | 7 -------
 include/uapi/linux/media/arm/mali-c55-config.h                 | 9 ---------
 3 files changed, 1 insertion(+), 17 deletions(-)
---
base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
change-id: 20251215-mali-c55-header-update-for-v6-19-rc1-118380a0cb7a

Best regards,
-- 
Jacopo Mondi <jacopo.mondi@ideasonboard.com>

[PATCH 1/3] Documentation: media: mali-c55: Use v4l2-isp version identifier

[Jacopo Mondi]

The Mali C55 driver uses the v4l2-isp framework, which defines its own
versioning numbers.

Do not use the Mali C55 specific version identifier in the code example
in the documentation of the Mali C55 stats and params metadata formats.

Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
 Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst b/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
index 696e0a645a7e0566921a3e9db3226b76d402f909..f8029bcb528283cddb1ea854b25469af97ecfa54 100644
--- a/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
+++ b/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
@@ -44,7 +44,7 @@ member and userspace must populate the type member with a value from
 	struct v4l2_isp_params_buffer *params =
 		(struct v4l2_isp_params_buffer *)buffer;
 
-	params->version = MALI_C55_PARAM_BUFFER_V1;
+	params->version = V4L2_ISP_PARAMS_VERSION_V1;
 	params->data_size = 0;
 
 	void *data = (void *)params->data;

-- 
2.52.0

Re: [PATCH 1/3] Documentation: media: mali-c55: Use v4l2-isp version identifier

[Bryan O'Donoghue]

On 15/12/2025 13:20, Jacopo Mondi wrote:
> The Mali C55 driver uses the v4l2-isp framework, which defines its own
> versioning numbers.
> 
> Do not use the Mali C55 specific version identifier in the code example
> in the documentation of the Mali C55 stats and params metadata formats.
> 
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> ---
>   Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst b/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
> index 696e0a645a7e0566921a3e9db3226b76d402f909..f8029bcb528283cddb1ea854b25469af97ecfa54 100644
> --- a/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
> +++ b/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
> @@ -44,7 +44,7 @@ member and userspace must populate the type member with a value from
>   	struct v4l2_isp_params_buffer *params =
>   		(struct v4l2_isp_params_buffer *)buffer;
> 
> -	params->version = MALI_C55_PARAM_BUFFER_V1;
> +	params->version = V4L2_ISP_PARAMS_VERSION_V1;
>   	params->data_size = 0;
> 
>   	void *data = (void *)params->data;
> 
> --
> 2.52.0
> 
> 

Feels like this should have a Fixes tag.

---
bod

Re: [PATCH 1/3] Documentation: media: mali-c55: Use v4l2-isp version identifier

[Jacopo Mondi]

Hi Brian

On Tue, Dec 16, 2025 at 12:38:16PM +0000, Bryan O'Donoghue wrote:
> On 15/12/2025 13:20, Jacopo Mondi wrote:
> > The Mali C55 driver uses the v4l2-isp framework, which defines its own
> > versioning numbers.
> >
> > Do not use the Mali C55 specific version identifier in the code example
> > in the documentation of the Mali C55 stats and params metadata formats.
> >
> > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> > ---
> >   Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst b/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
> > index 696e0a645a7e0566921a3e9db3226b76d402f909..f8029bcb528283cddb1ea854b25469af97ecfa54 100644
> > --- a/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
> > +++ b/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
> > @@ -44,7 +44,7 @@ member and userspace must populate the type member with a value from
> >   	struct v4l2_isp_params_buffer *params =
> >   		(struct v4l2_isp_params_buffer *)buffer;
> >
> > -	params->version = MALI_C55_PARAM_BUFFER_V1;
> > +	params->version = V4L2_ISP_PARAMS_VERSION_V1;
> >   	params->data_size = 0;
> >
> >   	void *data = (void *)params->data;
> >
> > --
> > 2.52.0
> >
> >
>
> Feels like this should have a Fixes tag.

I want this collected for v6.19, the same release the driver will be
collected in. Is it worth a Fixes and a cc to Stable if this patch
and the driver that it "fixes" land in the same release ?

>
> ---
> bod

Re: [PATCH 1/3] Documentation: media: mali-c55: Use v4l2-isp version identifier

[Bryan O'Donoghue]

On 17/12/2025 08:11, Jacopo Mondi wrote:
>> Feels like this should have a Fixes tag.
> I want this collected for v6.19, the same release the driver will be
> collected in. Is it worth a Fixes and a cc to Stable if this patch
> and the driver that it "fixes" land in the same release ?

Ah no not if its in the same release :)

---
bod

Re: [PATCH 1/3] Documentation: media: mali-c55: Use v4l2-isp version identifier

[Dan Scally]

Morning Jacopo - thanks for the set

On 15/12/2025 13:20, Jacopo Mondi wrote:
> The Mali C55 driver uses the v4l2-isp framework, which defines its own
> versioning numbers.
> 
> Do not use the Mali C55 specific version identifier in the code example
> in the documentation of the Mali C55 stats and params metadata formats.
> 
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> ---

Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>

>   Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst b/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
> index 696e0a645a7e0566921a3e9db3226b76d402f909..f8029bcb528283cddb1ea854b25469af97ecfa54 100644
> --- a/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
> +++ b/Documentation/userspace-api/media/v4l/metafmt-arm-mali-c55.rst
> @@ -44,7 +44,7 @@ member and userspace must populate the type member with a value from
>   	struct v4l2_isp_params_buffer *params =
>   		(struct v4l2_isp_params_buffer *)buffer;
>   
> -	params->version = MALI_C55_PARAM_BUFFER_V1;
> +	params->version = V4L2_ISP_PARAMS_VERSION_V1;
>   	params->data_size = 0;
>   
>   	void *data = (void *)params->data;
> 

[PATCH 2/3] media: mali-c55: Remove duplicated version check

[Jacopo Mondi]

The Mali C55 driver uses the v4l2-isp framework, which performs
validation of the parameters buffer versioning in the
v4l2_isp_params_validate_buffer() function.

It is not necessary to replicate the validation of the parameters buffer
versioning in the platform-specific implementation.

Remove it.

Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
 drivers/media/platform/arm/mali-c55/mali-c55-params.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-params.c b/drivers/media/platform/arm/mali-c55/mali-c55-params.c
index 082cda4f4f63e880162896ff0f893cd774982d51..be0e909bcf29f62c01c75d711c21278faf7c9de5 100644
--- a/drivers/media/platform/arm/mali-c55/mali-c55-params.c
+++ b/drivers/media/platform/arm/mali-c55/mali-c55-params.c
@@ -582,13 +582,6 @@ static int mali_c55_params_buf_prepare(struct vb2_buffer *vb)
 	struct mali_c55 *mali_c55 = params->mali_c55;
 	int ret;
 
-	if (config->version != MALI_C55_PARAM_BUFFER_V1) {
-		dev_dbg(mali_c55->dev,
-			"Unsupported extensible format version: %u\n",
-			config->version);
-		return -EINVAL;
-	}
-
 	ret = v4l2_isp_params_validate_buffer_size(mali_c55->dev, vb,
 			v4l2_isp_params_buffer_size(MALI_C55_PARAMS_MAX_SIZE));
 	if (ret)

-- 
2.52.0

Re: [PATCH 2/3] media: mali-c55: Remove duplicated version check

[Dan Scally]

On 15/12/2025 13:20, Jacopo Mondi wrote:
> The Mali C55 driver uses the v4l2-isp framework, which performs
> validation of the parameters buffer versioning in the
> v4l2_isp_params_validate_buffer() function.
> 
> It is not necessary to replicate the validation of the parameters buffer
> versioning in the platform-specific implementation.
> 
> Remove it.
> 
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>

> ---
>   drivers/media/platform/arm/mali-c55/mali-c55-params.c | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-params.c b/drivers/media/platform/arm/mali-c55/mali-c55-params.c
> index 082cda4f4f63e880162896ff0f893cd774982d51..be0e909bcf29f62c01c75d711c21278faf7c9de5 100644
> --- a/drivers/media/platform/arm/mali-c55/mali-c55-params.c
> +++ b/drivers/media/platform/arm/mali-c55/mali-c55-params.c
> @@ -582,13 +582,6 @@ static int mali_c55_params_buf_prepare(struct vb2_buffer *vb)
>   	struct mali_c55 *mali_c55 = params->mali_c55;
>   	int ret;
>   
> -	if (config->version != MALI_C55_PARAM_BUFFER_V1) {
> -		dev_dbg(mali_c55->dev,
> -			"Unsupported extensible format version: %u\n",
> -			config->version);
> -		return -EINVAL;
> -	}
> -
>   	ret = v4l2_isp_params_validate_buffer_size(mali_c55->dev, vb,
>   			v4l2_isp_params_buffer_size(MALI_C55_PARAMS_MAX_SIZE));
>   	if (ret)
> 

[PATCH 3/3] uapi: media: mali-c55-config: Remove version identifier

[Jacopo Mondi]

The Mali C55 driver uses the v4l2-isp framework, which defines its own
versioning number which does not need to be defined again in each
platform-specific header.

Remove the definition of mali_c55_param_buffer_version enumeration from
the Mali C55 uAPI header.

Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
---
 include/uapi/linux/media/arm/mali-c55-config.h | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/include/uapi/linux/media/arm/mali-c55-config.h b/include/uapi/linux/media/arm/mali-c55-config.h
index 109082c5694f6b927dc5511043e3bfbc27a0b675..3d335f950eeb1e58ed3cbb556752996f16441e55 100644
--- a/include/uapi/linux/media/arm/mali-c55-config.h
+++ b/include/uapi/linux/media/arm/mali-c55-config.h
@@ -194,15 +194,6 @@ struct mali_c55_stats_buffer {
 	__u32 reserved3[15];
 } __attribute__((packed));
 
-/**
- * enum mali_c55_param_buffer_version - Mali-C55 parameters block versioning
- *
- * @MALI_C55_PARAM_BUFFER_V1: First version of Mali-C55 parameters block
- */
-enum mali_c55_param_buffer_version {
-	MALI_C55_PARAM_BUFFER_V1,
-};
-
 /**
  * enum mali_c55_param_block_type - Enumeration of Mali-C55 parameter blocks
  *

-- 
2.52.0

Re: [PATCH 3/3] uapi: media: mali-c55-config: Remove version identifier

[Dan Scally]

On 15/12/2025 13:20, Jacopo Mondi wrote:
> The Mali C55 driver uses the v4l2-isp framework, which defines its own
> versioning number which does not need to be defined again in each
> platform-specific header.
> 
> Remove the definition of mali_c55_param_buffer_version enumeration from
> the Mali C55 uAPI header.
> 
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> ---

Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>

>   include/uapi/linux/media/arm/mali-c55-config.h | 9 ---------
>   1 file changed, 9 deletions(-)
> 
> diff --git a/include/uapi/linux/media/arm/mali-c55-config.h b/include/uapi/linux/media/arm/mali-c55-config.h
> index 109082c5694f6b927dc5511043e3bfbc27a0b675..3d335f950eeb1e58ed3cbb556752996f16441e55 100644
> --- a/include/uapi/linux/media/arm/mali-c55-config.h
> +++ b/include/uapi/linux/media/arm/mali-c55-config.h
> @@ -194,15 +194,6 @@ struct mali_c55_stats_buffer {
>   	__u32 reserved3[15];
>   } __attribute__((packed));
>   
> -/**
> - * enum mali_c55_param_buffer_version - Mali-C55 parameters block versioning
> - *
> - * @MALI_C55_PARAM_BUFFER_V1: First version of Mali-C55 parameters block
> - */
> -enum mali_c55_param_buffer_version {
> -	MALI_C55_PARAM_BUFFER_V1,
> -};
> -
>   /**
>    * enum mali_c55_param_block_type - Enumeration of Mali-C55 parameter blocks
>    *
>