mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Taeung Song <treeze.taeung@gmail.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, taeung@kosslab.kr,
	Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH v3 4/5] perf annotate browser: Support --show-nr-samples option
Date: Mon, 21 Aug 2017 14:34:55 +0900	[thread overview]
Message-ID: <ca5862a6-8b91-5085-0bd6-397233f618a8@gmail.com> (raw)
In-Reply-To: <20170818141740.GI10891@kernel.org>



On 08/18/2017 11:17 PM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Aug 18, 2017 at 05:47:03PM +0900, Taeung Song escreveu:
>> Cc: Namhyung Kim <namhyung@kernel.org>
>> Cc: Jiri Olsa <jolsa@redhat.com>
>> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> 
> Ok, now that check for !--stdio is lifted and replaced with:
> 
> -       if (symbol_conf.show_nr_samples && !annotate.use_stdio) {
> -               pr_err("--show-nr-samples is only available in --stdio mode at this time\n");
> +       if (symbol_conf.show_nr_samples && annotate.use_gtk) {
> +               pr_err("--show-nr-samples is not available in --gtk mode at this time\n");
>                  return ret;
>          }
> 
> - Arnaldo
> 

I got it :)

Thanks,
Taeung

  reply	other threads:[~2017-08-21  5:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18  8:47 Taeung Song
2017-08-18 14:17 ` Arnaldo Carvalho de Melo
2017-08-21  5:34   ` Taeung Song [this message]
2017-08-22 10:26 ` [tip:perf/core] " tip-bot for Taeung Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca5862a6-8b91-5085-0bd6-397233f618a8@gmail.com \
    --to=treeze.taeung@gmail.com \
    --cc=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=taeung@kosslab.kr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome