mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Sudeep Holla <sudeep.holla@kernel.org>, Ben Horgan <ben.horgan@arm.com>
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Hanjun Guo <guohanjun@huawei.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>, James Morse <james.morse@arm.com>,
	Reinette Chatre <reinette.chatre@intel.com>,
	Fenghua Yu <fenghuay@nvidia.com>,
	Jonathan Cameron <jic23@kernel.org>,
	Srivathsa L Rao <srivathsa.rao@oss.qualcomm.com>,
	Ganapatrao Kulkarni <ganapatrao.kulkarni@oss.qualcomm.com>,
	Trilok Soni <tsoni@quicinc.com>,
	Srinivas Ramana <sramana@qti.qualcomm.com>,
	Niyas Sait <niyas.sait@arm.com>, Lee Trager <lee@trager.us>,
	Ritwick Sharma <ritwick.sharma@arm.com>,
	Gavin Shan <gshan@redhat.com>,
	linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 12/14] arm_mpam: detect and enable MPAM-Fb PCC support
Date: Thu, 24 Sep 2026 12:35:48 +0200	[thread overview]
Message-ID: <ca773e60-e709-4b07-bf7f-14f92b8e3e5e@arm.com> (raw)
In-Reply-To: <20260924-snobbish-brainy-velociraptor-06bdd4@sudeepholla>

Hi Sudeep,

On 9/24/26 11:48, Sudeep Holla wrote:
> On Mon, Sep 21, 2026 at 05:28:27PM +0100, Ben Horgan wrote:
>> Hi Andre,
>>
>> On 21/09/2026 17:09, Andre Przywara wrote:
>>> Hi Ben,
>>>
>>> On 9/11/26 17:09, Ben Horgan wrote:
>>>> Hi Andre,
>>>>
> 
> [...]
> 
>>>>
>>>> This looks like the change earlier in the series to
>>>> drivers/acpi/arm64/mpam.c makes no functional effect unless the proposed
>>>> spec changes are accepted; the default is msc->id. I'd just move the
>>>
>>> Yes, but it reduces churn, and more importantly, is more true to the
>>> MPAM-Fb spec, which says:"The MSC identifiers are sequential and start from
>>> 0 for each agent which uses this protocol." So this requires that we have
>>> per-channel IDs for the MSCs, that's why I think it's justified to
>>> introduce this already now, even when it's somewhat redundant as the code
>>> stands now, as we always assign the system-wide ID to it.
>>>
>>> I can of course move that out (and have that already on top of v9,
>>> internally), but wanted to check this with you.
>>
>> I don't really mind. If Lorenzo/Sudeep are happy with doing the preparation
>> work in drivers/acpi/arm64/mpam.c then I'm ok with it. It's currently a
>> non-functional change but does make the expected path forward slightly
>> clearer.
>>
> 
> Sure, I am okay to have it added here if we plan to use it in the future.
> We can always rip it off if the spec changes its direction or gets deemed
> as broken 😉.
Many thanks, will keep it in then.

Cheers,
Andre

  reply	other threads:[~2026-09-24 10:35 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11 11:28 [PATCH v10 00/14] arm_mpam: Add MPAM-Fb firmware support Andre Przywara
2026-09-11 11:28 ` [PATCH v10 01/14] arm_mpam: let low level MSC accessors return an error Andre Przywara
2026-09-11 11:28 ` [PATCH v10 02/14] arm_mpam: propagate MSC access errors for hw_probe functions Andre Przywara
2026-09-11 11:28 ` [PATCH v10 03/14] arm_mpam: propagate MSC access errors for MBWU counters Andre Przywara
2026-09-11 11:28 ` [PATCH v10 04/14] arm_mpam: propagate MSC access errors for msmon helpers Andre Przywara
2026-09-11 11:28 ` [PATCH v10 05/14] arm_mpam: propagate MSC access errors for __ris_msmon_read() Andre Przywara
2026-09-11 11:28 ` [PATCH v10 06/14] arm_mpam: propagate MSC access errors for state saving function Andre Przywara
2026-09-11 11:28 ` [PATCH v10 07/14] arm_mpam: propagate MSC access errors for mpam_reprogram_ris_partid() Andre Przywara
2026-09-11 11:28 ` [PATCH v10 08/14] arm_mpam: propagate MSC access errors for interrupt control Andre Przywara
2026-09-11 14:26   ` Ben Horgan
2026-09-11 16:19     ` Andre Przywara
2026-09-11 16:23       ` Ben Horgan
2026-09-11 11:28 ` [PATCH v10 09/14] arm_mpam: prepare mon_sel locking for MPAM-Fb Andre Przywara
2026-09-11 11:28 ` [PATCH v10 10/14] arm_mpam: add MPAM-Fb MSC firmware access support Andre Przywara
2026-09-11 15:13   ` Ben Horgan
2026-09-24 15:25     ` Andre Przywara
2026-09-11 11:28 ` [PATCH v10 11/14] arm_mpam: change MPAM-Fb error IRQ to use a threaded IRQ handler Andre Przywara
2026-09-11 11:28 ` [PATCH v10 12/14] arm_mpam: detect and enable MPAM-Fb PCC support Andre Przywara
2026-09-11 15:09   ` Ben Horgan
2026-09-21 16:09     ` Andre Przywara
2026-09-21 16:28       ` Ben Horgan
2026-09-24  9:48         ` Sudeep Holla
2026-09-24 10:35           ` Andre Przywara [this message]
2026-09-15 16:33   ` Ben Horgan
2026-09-24 15:26     ` Andre Przywara
2026-09-11 11:28 ` [RFC PATCH v10 13/14] ACPICA: actbl2.h: MPAM: adapt to MPAM ACPI v3.1 changes Andre Przywara
2026-09-11 11:28 ` [RFC PATCH v10 14/14] acpi: arm64: use MPAM-Fb offset field from ACPI table Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca773e60-e709-4b07-bf7f-14f92b8e3e5e@arm.com \
    --to=andre.przywara@arm.com \
    --cc=ben.horgan@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=fenghuay@nvidia.com \
    --cc=ganapatrao.kulkarni@oss.qualcomm.com \
    --cc=gshan@redhat.com \
    --cc=guohanjun@huawei.com \
    --cc=james.morse@arm.com \
    --cc=jic23@kernel.org \
    --cc=lee@trager.us \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=niyas.sait@arm.com \
    --cc=rafael@kernel.org \
    --cc=reinette.chatre@intel.com \
    --cc=ritwick.sharma@arm.com \
    --cc=sramana@qti.qualcomm.com \
    --cc=srivathsa.rao@oss.qualcomm.com \
    --cc=sudeep.holla@kernel.org \
    --cc=tsoni@quicinc.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®