* [PATCH] drm/panic: clean Clippy warning
@ 2025-03-03 9:32 Miguel Ojeda
2025-03-03 9:33 ` Alice Ryhl
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Miguel Ojeda @ 2025-03-03 9:32 UTC (permalink / raw)
To: Jocelyn Falempe, Thomas Böhler, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Miguel Ojeda, Alex Gaynor
Cc: dri-devel, Boqun Feng, Gary Guo, Björn Roy Baron,
Benno Lossin, Andreas Hindborg, Alice Ryhl, Trevor Gross,
rust-for-linux, linux-kernel, patches
Clippy warns:
error: manual implementation of an assign operation
--> drivers/gpu/drm/drm_panic_qr.rs:418:25
|
418 | self.carry = self.carry % pow;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.carry %= pow`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
Thus clean it up.
Fixes: dbed4a797e00 ("drm/panic: Better binary encoding in QR code")
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
---
drivers/gpu/drm/drm_panic_qr.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_panic_qr.rs b/drivers/gpu/drm/drm_panic_qr.rs
index 62cb8a162483..3b0dd59781d4 100644
--- a/drivers/gpu/drm/drm_panic_qr.rs
+++ b/drivers/gpu/drm/drm_panic_qr.rs
@@ -415,7 +415,7 @@ fn next(&mut self) -> Option<Self::Item> {
self.carry_len -= out_len;
let pow = u64::pow(10, self.carry_len as u32);
let out = (self.carry / pow) as u16;
- self.carry = self.carry % pow;
+ self.carry %= pow;
Some((out, NUM_CHARS_BITS[out_len]))
}
}
base-commit: c0eb65494e59d9834af7cbad983629e9017b25a1
--
2.48.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/panic: clean Clippy warning
2025-03-03 9:32 [PATCH] drm/panic: clean Clippy warning Miguel Ojeda
@ 2025-03-03 9:33 ` Alice Ryhl
2025-03-03 9:42 ` Jocelyn Falempe
2025-03-10 9:59 ` Jocelyn Falempe
2 siblings, 0 replies; 4+ messages in thread
From: Alice Ryhl @ 2025-03-03 9:33 UTC (permalink / raw)
To: Miguel Ojeda
Cc: Jocelyn Falempe, Thomas Böhler, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Alex Gaynor, dri-devel, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg,
Trevor Gross, rust-for-linux, linux-kernel, patches
On Mon, Mar 3, 2025 at 10:33 AM Miguel Ojeda <ojeda@kernel.org> wrote:
>
> Clippy warns:
>
> error: manual implementation of an assign operation
> --> drivers/gpu/drm/drm_panic_qr.rs:418:25
> |
> 418 | self.carry = self.carry % pow;
> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.carry %= pow`
> |
> = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
>
> Thus clean it up.
>
> Fixes: dbed4a797e00 ("drm/panic: Better binary encoding in QR code")
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/panic: clean Clippy warning
2025-03-03 9:32 [PATCH] drm/panic: clean Clippy warning Miguel Ojeda
2025-03-03 9:33 ` Alice Ryhl
@ 2025-03-03 9:42 ` Jocelyn Falempe
2025-03-10 9:59 ` Jocelyn Falempe
2 siblings, 0 replies; 4+ messages in thread
From: Jocelyn Falempe @ 2025-03-03 9:42 UTC (permalink / raw)
To: Miguel Ojeda, Thomas Böhler, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Alex Gaynor
Cc: dri-devel, Boqun Feng, Gary Guo, Björn Roy Baron,
Benno Lossin, Andreas Hindborg, Alice Ryhl, Trevor Gross,
rust-for-linux, linux-kernel, patches
On 03/03/2025 10:32, Miguel Ojeda wrote:
> Clippy warns:
>
> error: manual implementation of an assign operation
> --> drivers/gpu/drm/drm_panic_qr.rs:418:25
> |
> 418 | self.carry = self.carry % pow;
> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.carry %= pow`
> |
> = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
>
> Thus clean it up.
Thanks, it looks good to me.
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
>
> Fixes: dbed4a797e00 ("drm/panic: Better binary encoding in QR code")
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
> ---
> drivers/gpu/drm/drm_panic_qr.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_panic_qr.rs b/drivers/gpu/drm/drm_panic_qr.rs
> index 62cb8a162483..3b0dd59781d4 100644
> --- a/drivers/gpu/drm/drm_panic_qr.rs
> +++ b/drivers/gpu/drm/drm_panic_qr.rs
> @@ -415,7 +415,7 @@ fn next(&mut self) -> Option<Self::Item> {
> self.carry_len -= out_len;
> let pow = u64::pow(10, self.carry_len as u32);
> let out = (self.carry / pow) as u16;
> - self.carry = self.carry % pow;
> + self.carry %= pow;
> Some((out, NUM_CHARS_BITS[out_len]))
> }
> }
>
> base-commit: c0eb65494e59d9834af7cbad983629e9017b25a1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/panic: clean Clippy warning
2025-03-03 9:32 [PATCH] drm/panic: clean Clippy warning Miguel Ojeda
2025-03-03 9:33 ` Alice Ryhl
2025-03-03 9:42 ` Jocelyn Falempe
@ 2025-03-10 9:59 ` Jocelyn Falempe
2 siblings, 0 replies; 4+ messages in thread
From: Jocelyn Falempe @ 2025-03-10 9:59 UTC (permalink / raw)
To: Miguel Ojeda, Thomas Böhler, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Alex Gaynor
Cc: dri-devel, Boqun Feng, Gary Guo, Björn Roy Baron,
Benno Lossin, Andreas Hindborg, Alice Ryhl, Trevor Gross,
rust-for-linux, linux-kernel, patches
On 03/03/2025 10:32, Miguel Ojeda wrote:
> Clippy warns:
>
> error: manual implementation of an assign operation
> --> drivers/gpu/drm/drm_panic_qr.rs:418:25
> |
> 418 | self.carry = self.carry % pow;
> | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.carry %= pow`
> |
> = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
>
> Thus clean it up.
Applied to drm-misc-next (because dbed4a797e00 is only present in this
branch).
Thanks for your contribution.
--
Jocelyn
>
> Fixes: dbed4a797e00 ("drm/panic: Better binary encoding in QR code")
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
> ---
> drivers/gpu/drm/drm_panic_qr.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_panic_qr.rs b/drivers/gpu/drm/drm_panic_qr.rs
> index 62cb8a162483..3b0dd59781d4 100644
> --- a/drivers/gpu/drm/drm_panic_qr.rs
> +++ b/drivers/gpu/drm/drm_panic_qr.rs
> @@ -415,7 +415,7 @@ fn next(&mut self) -> Option<Self::Item> {
> self.carry_len -= out_len;
> let pow = u64::pow(10, self.carry_len as u32);
> let out = (self.carry / pow) as u16;
> - self.carry = self.carry % pow;
> + self.carry %= pow;
> Some((out, NUM_CHARS_BITS[out_len]))
> }
> }
>
> base-commit: c0eb65494e59d9834af7cbad983629e9017b25a1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-10 9:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-03 9:32 [PATCH] drm/panic: clean Clippy warning Miguel Ojeda
2025-03-03 9:33 ` Alice Ryhl
2025-03-03 9:42 ` Jocelyn Falempe
2025-03-10 9:59 ` Jocelyn Falempe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®