From: John Meneghini <jmeneghi@redhat.com>
To: Hannes Reinecke <hare@suse.de>, Keith Busch <kbusch@kernel.org>,
Sagi Grimberg <sagi@grimberg.me>
Cc: Nilay Shroff <nilay@linux.ibm.com>,
hch@lst.de, bmarzins@redhat.com,
Bryan Gurney <bgurney@redhat.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Marco Patalano <mpatalan@redhat.com>,
axboe@kernel.dk
Subject: Re: [PATCH] nvme: remove multipath module parameter
Date: Tue, 11 Mar 2025 23:08:37 -0400 [thread overview]
Message-ID: <ca96d675-7ada-42c0-a3b9-6ced9e399ff3@redhat.com> (raw)
In-Reply-To: <91ae613a-7b56-4ca0-b91c-6bc1eee798b8@suse.de>
On 2/26/25 4:55 AM, Hannes Reinecke wrote:
> Plus there are some NVMe devices out there which _despite_ being PCIe do report NMIC and CMIC set
> (I won't name names, if you came across them you'll know). This is causing stacking drivers (most notably MD)
> to behave vastly different on hotplug. Having the module option is an easy way of debugging (and, in quite
> some cases, fixing) the issue.
So some MD driver configurations that use PCIe devices that report CMIC and NMIC need to turn off
core.nvme_multipath. Is that what you're saying? Are these PCIe devices multiported?
> If the module option really causes issues just make it read-only; that
> way you can still set if if absolutely required, and at the same time
> catch installations which try to modify it.
If we do that the parameter can't be used to support use cases like your MD driver, or Kieth's ublk driver.
/John
next prev parent reply other threads:[~2025-03-12 3:08 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 21:11 Bryan Gurney
2025-02-13 20:37 ` John Meneghini
2025-02-17 8:08 ` Sagi Grimberg
2025-02-17 16:14 ` John Meneghini
2025-02-18 8:19 ` Sagi Grimberg
2025-02-18 14:05 ` John Meneghini
2025-02-18 14:57 ` John Meneghini
2025-02-18 15:06 ` Keith Busch
2025-02-18 16:31 ` John Meneghini
2025-02-18 17:15 ` Keith Busch
2025-02-18 23:06 ` John Meneghini
2025-02-18 23:30 ` Keith Busch
2025-02-19 14:47 ` Nilay Shroff
2025-02-20 11:05 ` Sagi Grimberg
2025-02-20 16:47 ` Keith Busch
2025-02-26 9:55 ` Hannes Reinecke
2025-03-05 14:15 ` Christoph Hellwig
2025-03-05 15:17 ` Keith Busch
2025-03-05 23:51 ` Christoph Hellwig
2025-03-05 23:57 ` Keith Busch
2025-03-06 0:03 ` Christoph Hellwig
2025-03-06 0:15 ` Keith Busch
2025-03-06 7:12 ` Hannes Reinecke
2025-03-06 14:18 ` Christoph Hellwig
2025-03-06 15:01 ` Keith Busch
2025-03-06 15:16 ` Christoph Hellwig
2025-03-07 0:46 ` Keith Busch
2025-03-07 15:19 ` Nilay Shroff
2025-03-07 15:43 ` Keith Busch
2025-03-09 17:23 ` Nilay Shroff
2025-03-10 13:29 ` Christoph Hellwig
2025-03-12 3:47 ` John Meneghini
2025-03-12 15:26 ` Nilay Shroff
2025-03-10 13:28 ` Christoph Hellwig
2025-03-12 3:08 ` John Meneghini [this message]
2025-02-18 14:26 ` John Meneghini
2025-02-18 16:41 ` John Meneghini
2025-02-18 14:43 ` John Meneghini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca96d675-7ada-42c0-a3b9-6ced9e399ff3@redhat.com \
--to=jmeneghi@redhat.com \
--cc=axboe@kernel.dk \
--cc=bgurney@redhat.com \
--cc=bmarzins@redhat.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mpatalan@redhat.com \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®