From: John Meneghini <jmeneghi@redhat.com>
To: Sagi Grimberg <sagi@grimberg.me>, kbusch@kernel.org, hch@lst.de
Cc: bmarzins@redhat.com, Bryan Gurney <bgurney@redhat.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Marco Patalano <mpatalan@redhat.com>,
axboe@kernel.dk
Subject: Re: [PATCH] nvme: remove multipath module parameter
Date: Mon, 17 Feb 2025 11:14:44 -0500 [thread overview]
Message-ID: <ea9537d5-721a-4b37-84d1-df797646fce2@redhat.com> (raw)
In-Reply-To: <ea0e6445-9770-4df9-91bd-80f44cd0388e@grimberg.me>
On 2/17/25 3:08 AM, Sagi Grimberg wrote:
>>
>> We plan to ship this patch with RHEL-10. So it would be really good if we could get this
>> change accepted and merged upstream, perhaps into v6.15.
>
> Hey John,
>
> This looks fine to me, I'm assuming this was also tested with CONFIG_NVME_MULTIPATH=n ?
Yes, everything has been tested with CONFIG_NVME_MULTIPATH both enabled (Y) and disabled (N).
As we discussed in the previous email thread[1] there is an anomaly seen when you build a kernel with CONFIG_NVME_MULTIPATH=n.
and the host discovers a multipath capable nvme device (CMIC/NMIC=1). You will see exactly the same thing that you do with
CONFIG_NVME_MULTIPATH=y when the nvme_core.multipath parameter is N. You see a separate /dev/nvmeNN entry for
every namespace/controller path.
We can send send a separate patch to address that problem, but this patch, which simply removes the nvme_core.multipath parameter
has beeen fully tested and is ready to go.
[1] https://lore.kernel.org/linux-nvme/58519c4e-5801-4481-9087-be4f19b218f7@redhat.com/
Please approve/merge this patch.
/John
next prev parent reply other threads:[~2025-02-17 16:14 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 21:11 Bryan Gurney
2025-02-13 20:37 ` John Meneghini
2025-02-17 8:08 ` Sagi Grimberg
2025-02-17 16:14 ` John Meneghini [this message]
2025-02-18 8:19 ` Sagi Grimberg
2025-02-18 14:05 ` John Meneghini
2025-02-18 14:57 ` John Meneghini
2025-02-18 15:06 ` Keith Busch
2025-02-18 16:31 ` John Meneghini
2025-02-18 17:15 ` Keith Busch
2025-02-18 23:06 ` John Meneghini
2025-02-18 23:30 ` Keith Busch
2025-02-19 14:47 ` Nilay Shroff
2025-02-20 11:05 ` Sagi Grimberg
2025-02-20 16:47 ` Keith Busch
2025-02-26 9:55 ` Hannes Reinecke
2025-03-05 14:15 ` Christoph Hellwig
2025-03-05 15:17 ` Keith Busch
2025-03-05 23:51 ` Christoph Hellwig
2025-03-05 23:57 ` Keith Busch
2025-03-06 0:03 ` Christoph Hellwig
2025-03-06 0:15 ` Keith Busch
2025-03-06 7:12 ` Hannes Reinecke
2025-03-06 14:18 ` Christoph Hellwig
2025-03-06 15:01 ` Keith Busch
2025-03-06 15:16 ` Christoph Hellwig
2025-03-07 0:46 ` Keith Busch
2025-03-07 15:19 ` Nilay Shroff
2025-03-07 15:43 ` Keith Busch
2025-03-09 17:23 ` Nilay Shroff
2025-03-10 13:29 ` Christoph Hellwig
2025-03-12 3:47 ` John Meneghini
2025-03-12 15:26 ` Nilay Shroff
2025-03-10 13:28 ` Christoph Hellwig
2025-03-12 3:08 ` John Meneghini
2025-02-18 14:26 ` John Meneghini
2025-02-18 16:41 ` John Meneghini
2025-02-18 14:43 ` John Meneghini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea9537d5-721a-4b37-84d1-df797646fce2@redhat.com \
--to=jmeneghi@redhat.com \
--cc=axboe@kernel.dk \
--cc=bgurney@redhat.com \
--cc=bmarzins@redhat.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mpatalan@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®