mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kim Phillips <kim.phillips@amd.com>
To: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
	Sean Christopherson <seanjc@google.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	K Prateek Nayak <kprateek.nayak@amd.com>,
	Nikunj A Dadhania <nikunj@amd.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Michael Roth <michael.roth@amd.com>,
	Borislav Petkov <borislav.petkov@amd.com>,
	Borislav Petkov <bp@alien8.de>, Naveen Rao <naveen.rao@amd.com>,
	David Kaplan <david.kaplan@amd.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Nathan Fontenot <nathan.fontenot@amd.com>,
	stable@kernel.org
Subject: Re: [PATCH] x86/bugs: Only log missing retpoline when it's actually the missing mitigation
Date: Mon, 31 Aug 2026 17:44:52 -0500	[thread overview]
Message-ID: <caa8512b-8262-4007-93b3-318349cb80f4@amd.com> (raw)
In-Reply-To: <ccy6cxmro4hyvradyddbqubt5jlth3l7cwp3v4obz2lviazyry@2d4ixypnltll>

On 8/26/26 11:59 PM, Pawan Gupta wrote:
> On Wed, Aug 26, 2026 at 05:22:28PM -0500, Kim Phillips wrote:
>> +++ b/arch/x86/kernel/cpu/bugs.c
>> @@ -1956,10 +1956,8 @@ early_param("spectre_v2", spectre_v2_parse_cmdline);
>>   
>>   static enum spectre_v2_mitigation __init spectre_v2_select_retpoline(void)
>>   {
>> -	if (!IS_ENABLED(CONFIG_MITIGATION_RETPOLINE)) {
>> -		pr_err("Kernel not compiled with retpoline; no mitigation available!");
> 
> The claim "No mitigation available" is really the problem. And, it is
> redundant here because the final mitigation state is anyways printed in
> spectre_v2_update_mitigation().
> 
> How about just change the message to:
> 
> 	pr_err("Kernel not compiled with retpoline");
> 
> It stays accurate here, telling retpoline mitigation was attempted.

Thanks for your review.  I've made these changes and reworded the commit
text and submitted a v2 here:

https://lore.kernel.org/lkml/20260831210916.987152-1-kim.phillips@amd.com/

Thanks,

Kim

      reply	other threads:[~2026-08-31 22:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-26 22:22 Kim Phillips
2026-08-27  4:59 ` Pawan Gupta
2026-08-31 22:44   ` Kim Phillips [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=caa8512b-8262-4007-93b3-318349cb80f4@amd.com \
    --to=kim.phillips@amd.com \
    --cc=borislav.petkov@amd.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=david.kaplan@amd.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.roth@amd.com \
    --cc=nathan.fontenot@amd.com \
    --cc=naveen.rao@amd.com \
    --cc=nikunj@amd.com \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=stable@kernel.org \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®