From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Ondrej Zary <linux@zary.sk>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Tim Waugh <tim@cyberelk.net>, <linux-block@vger.kernel.org>,
<linux-parport@lists.infradead.org>, <linux-ide@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 05/12] pata_parport: remove typedef struct PIA
Date: Mon, 13 Feb 2023 23:08:48 +0300 [thread overview]
Message-ID: <cab6cec4-1a3a-ed15-ddd1-8b51def4f53e@omp.ru> (raw)
In-Reply-To: <20230211144232.15138-6-linux@zary.sk>
On 2/11/23 5:42 PM, Ondrej Zary wrote:
> Remove typedef struct PIA and use struct pi_adapter directly.
Prolly worth mentioning that you drop the spaces in the parameter lists
while at it...
> Signed-off-by: Ondrej Zary <linux@zary.sk>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Had some comments tho...
[...]
> diff --git a/drivers/ata/pata_parport/fit2.c b/drivers/ata/pata_parport/fit2.c
> index 28de8e4e41c3..020c93dea362 100644
> --- a/drivers/ata/pata_parport/fit2.c
> +++ b/drivers/ata/pata_parport/fit2.c
> @@ -37,13 +37,13 @@ devices.
>
> */
>
> -static void fit2_write_regr( PIA *pi, int cont, int regr, int val)
> +static void fit2_write_regr(struct pi_adapter *pi, int cont, int regr, int val)
Could also kill an extra space after *void*...
[...]
> diff --git a/drivers/ata/pata_parport/fit3.c b/drivers/ata/pata_parport/fit3.c
> index 0366f3123508..03f314ad5ee7 100644
> --- a/drivers/ata/pata_parport/fit3.c
> +++ b/drivers/ata/pata_parport/fit3.c
> @@ -39,7 +39,7 @@
>
> */
>
> -static void fit3_write_regr( PIA *pi, int cont, int regr, int val)
> +static void fit3_write_regr(struct pi_adapter *pi, int cont, int regr, int val)
Here as well...
[...]
> diff --git a/drivers/ata/pata_parport/kbic.c b/drivers/ata/pata_parport/kbic.c
> index 9a99b9e35d41..e065f8367716 100644
> --- a/drivers/ata/pata_parport/kbic.c
> +++ b/drivers/ata/pata_parport/kbic.c
[...]
> @@ -72,7 +72,7 @@ static int kbic_read_regr( PIA *pi, int cont, int regr )
> return -1;
> }
>
> -static void kbic_write_regr( PIA *pi, int cont, int regr, int val)
> +static void kbic_write_regr(struct pi_adapter *pi, int cont, int regr, int val)
And here...
[...]
> diff --git a/drivers/ata/pata_parport/ktti.c b/drivers/ata/pata_parport/ktti.c
> index d87eb3c139bc..bddd13b4801f 100644
> --- a/drivers/ata/pata_parport/ktti.c
> +++ b/drivers/ata/pata_parport/ktti.c
> @@ -29,7 +29,7 @@
>
> static int cont_map[2] = { 0x10, 0x08 };
>
> -static void ktti_write_regr( PIA *pi, int cont, int regr, int val)
> +static void ktti_write_regr(struct pi_adapter *pi, int cont, int regr, int val)
And here...
[...]
MBR, Sergey
next prev parent reply other threads:[~2023-02-13 20:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-11 14:42 [PATCH 0/12] pata_parport: protocol drivers cleanups Ondrej Zary
2023-02-11 14:42 ` [PATCH 01/12] pata_parport: Remove pi_swab16 and pi_swab32 Ondrej Zary
2023-02-11 19:01 ` Sergey Shtylyov
2023-02-11 14:42 ` [PATCH 02/12] pata_parport: Introduce module_pata_parport_driver macro Ondrej Zary
2023-02-12 12:19 ` Sergey Shtylyov
2023-02-12 18:19 ` Ondrej Zary
2023-02-11 14:42 ` [PATCH 03/12] pata_parport: remove devtype from struct pi_adapter Ondrej Zary
2023-02-11 19:11 ` Sergey Shtylyov
2023-02-11 20:47 ` Ondrej Zary
2023-02-12 12:17 ` Damien Le Moal
2023-02-11 14:42 ` [PATCH 04/12] pata_parport: remove device " Ondrej Zary
2023-02-12 17:36 ` Sergey Shtylyov
2023-02-11 14:42 ` [PATCH 05/12] pata_parport: remove typedef struct PIA Ondrej Zary
2023-02-13 20:08 ` Sergey Shtylyov [this message]
2023-02-11 14:42 ` [PATCH 06/12] pata_parport: remove verbose parameter from log_adapter() Ondrej Zary
2023-02-11 20:43 ` Sergey Shtylyov
2023-02-11 14:42 ` [PATCH 07/12] pata_parport: remove scratch " Ondrej Zary
2023-02-12 17:14 ` Sergey Shtylyov
2023-02-11 14:42 ` [PATCH 08/12] pata_parport: use dev_* and print_hex_* instead of printk Ondrej Zary
2023-02-14 20:55 ` Sergei Shtylyov
2023-02-11 14:42 ` [PATCH 09/12] pata_parport: remove verbose parameter from test_proto() Ondrej Zary
2023-02-11 19:56 ` Sergey Shtylyov
2023-02-11 14:42 ` [PATCH 10/12] pata_parport: remove scratch " Ondrej Zary
2023-02-12 17:47 ` Sergey Shtylyov
2023-02-11 14:42 ` [PATCH 11/12] pata_parport: remove obsolete changelogs Ondrej Zary
2023-02-13 20:42 ` Sergey Shtylyov
2023-02-11 14:42 ` [PATCH 12/12] pata_parport: move pata_parport.h to drivers/ata/pata_parport Ondrej Zary
2023-02-13 20:51 ` Sergey Shtylyov
2023-02-11 20:59 ` [PATCH 0/12] pata_parport: protocol drivers cleanups Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cab6cec4-1a3a-ed15-ddd1-8b51def4f53e@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
--cc=linux@zary.sk \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®