mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Swapnil Sapkal <swapnil.sapkal@amd.com>
To: Reinette Chatre <reinette.chatre@intel.com>,
	<tony.luck@intel.com>, <babu.moger@amd.com>, <shuah@kernel.org>
Cc: <Dave.Martin@arm.com>, <james.morse@arm.com>,
	<peternewman@google.com>, <eranian@google.com>,
	<tan.shaopeng@fujitsu.com>, <linux-kernel@vger.kernel.org>,
	<linux-kselftest@vger.kernel.org>, <x86@kernel.org>
Subject: Re: [PATCH v5 5/5] selftests/resctrl: Enable MBM and MBA tests on AMD
Date: Thu, 5 Nov 2026 09:46:27 +0530	[thread overview]
Message-ID: <cacc0f81-eb8b-4b76-b341-1ba8f27cf1f5@amd.com> (raw)
In-Reply-To: <befefa2c-6898-45ba-ba17-4944c2d47d97@intel.com>

Hi Reinette,

On 29-10-2026 00:15, Reinette Chatre wrote:
> Hi Swapnil,
> 
> On 10/22/26 6:25 AM, Swapnil Sapkal wrote:
> ...> diff --git a/tools/testing/selftests/resctrl/mbm_test.c b/tools/testing/selftests/resctrl/mbm_test.c
>> index e24c6237a22f..b2c5fd0ab8e3 100644
>> --- a/tools/testing/selftests/resctrl/mbm_test.c
>> +++ b/tools/testing/selftests/resctrl/mbm_test.c
>> @@ -178,7 +178,7 @@ static bool mbm_feature_check(const struct resctrl_test *test)
>>   struct resctrl_test mbm_test = {
>>   	.name = "MBM",
>>   	.resource = "MB",
>> -	.vendor_specific = ARCH_INTEL,
>> +	.vendor_specific = ARCH_INTEL | ARCH_AMD,
>>   	.feature_check = mbm_feature_check,
>>   	.run_test = mbm_run_test,
>>   	.cleanup = mbm_test_cleanup,
> 
> The issue reported by sahiko looks real to me:
> 	https://sashiko.dev/#/patchset/20261022132517.46805-1-swapnil.sapkal%40amd.com
> 

Yes, the reported issue is real. Currently, mba_test uses the 
unthrottled value of 100 for Intel, which does not hold true for AMD. 
AMD should likewise use the unthrottled value, and I'll update this 
accordingly in the next version.

> Reinette
--
Thanks and Regards,
Swapnil

      reply	other threads:[~2026-11-05  4:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22 13:25 [PATCH v5 0/5] selftests/resctrl: Add MBM and MBA test support for AMD Swapnil Sapkal
2026-10-22 13:25 ` [PATCH v5 1/5] selftests/resctrl: Rename variables and functions to generic names Swapnil Sapkal
2026-10-28 18:38   ` Reinette Chatre
2026-11-03  6:13     ` Swapnil Sapkal
2026-10-22 13:25 ` [PATCH v5 2/5] selftests/resctrl: Detect vendor to select memory controller sysfs name Swapnil Sapkal
2026-10-28 18:39   ` Reinette Chatre
2026-11-03  6:19     ` Swapnil Sapkal
2026-10-22 13:25 ` [PATCH v5 3/5] selftests/resctrl: Add support for MBM and MBA tests on AMD Swapnil Sapkal
2026-10-28 18:41   ` Reinette Chatre
2026-11-03  6:34     ` Swapnil Sapkal
2026-10-22 13:25 ` [PATCH v5 4/5] selftests/resctrl: Use bandwidth values for AMD MBA schemata Swapnil Sapkal
2026-10-28 18:45   ` Reinette Chatre
2026-11-03  1:15     ` Moger, Babu
2026-11-05  4:08       ` Swapnil Sapkal
2026-11-05  4:05     ` Swapnil Sapkal
2026-11-05  4:16       ` Reinette Chatre
2026-10-22 13:25 ` [PATCH v5 5/5] selftests/resctrl: Enable MBM and MBA tests on AMD Swapnil Sapkal
2026-10-28 18:45   ` Reinette Chatre
2026-11-05  4:16     ` Swapnil Sapkal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cacc0f81-eb8b-4b76-b341-1ba8f27cf1f5@amd.com \
    --to=swapnil.sapkal@amd.com \
    --cc=Dave.Martin@arm.com \
    --cc=babu.moger@amd.com \
    --cc=eranian@google.com \
    --cc=james.morse@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=peternewman@google.com \
    --cc=reinette.chatre@intel.com \
    --cc=shuah@kernel.org \
    --cc=tan.shaopeng@fujitsu.com \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®