From: Joe Perches <joe@perches.com>
To: Tanjuate Brunostar <tanjubrunostar0@gmail.com>,
gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev
Subject: Re: [PATCH v3 1/6] staging: vt6655: fix lines ending in a '('
Date: Sat, 22 Oct 2022 00:18:34 -0700 [thread overview]
Message-ID: <cae0a94e73b1e44a7d8c750a406aa77d1942a06a.camel@perches.com> (raw)
In-Reply-To: <20221022070612.13009-2-tanjubrunostar0@gmail.com>
On Sat, 2022-10-22 at 07:06 +0000, Tanjuate Brunostar wrote:
> fix serveral checkpatch errors related to lines ending with a '(' by
> refactoring the code lines
[]
> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
[]
> @@ -141,13 +141,11 @@ static __le16 vnt_time_stamp_off(struct vnt_private *priv, u16 rate)
> */
> static
> unsigned int
> -s_uGetTxRsvTime(
> - struct vnt_private *pDevice,
> - unsigned char byPktType,
> - unsigned int cbFrameLength,
> - unsigned short wRate,
> - bool bNeedAck
> -)
> +s_uGetTxRsvTime(struct vnt_private *pDevice,
If you end up doing more work here, ou might consider removing the
Hungarian style notations
Maybe something like:
s_uGetTxRsvTime -> get_tx_rsv_time
> + unsigned char byPktType,
byPktType -> pkt_type
etc...
Perhaps patches by unique rename.
next prev parent reply other threads:[~2022-10-22 7:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 7:06 [PATCH v3 0/6] a series of checkpatch fixes on the file: rxtx.c Tanjuate Brunostar
2022-10-22 7:06 ` [PATCH v3 1/6] staging: vt6655: fix lines ending in a '(' Tanjuate Brunostar
2022-10-22 7:18 ` Joe Perches [this message]
2022-10-22 7:35 ` Tanju Brunostar
2022-10-22 8:10 ` Greg KH
2022-10-22 8:24 ` Tanju Brunostar
2022-10-22 7:06 ` [PATCH v3 2/6] staging: vt6655: refactor long lines of code in s_uGetRTSCTSDuration Tanjuate Brunostar
2022-10-22 8:11 ` Greg KH
2022-10-22 8:26 ` Tanju Brunostar
2022-10-22 7:06 ` [PATCH v3 3/6] staging: vt6655: refactor long lines of code in s_uFillDataHead Tanjuate Brunostar
2022-10-22 8:12 ` Greg KH
2022-10-22 8:27 ` Tanju Brunostar
2022-10-22 7:06 ` [PATCH v3 4/6] staging: vt6655: refactor long lines of code in s_vGenerateTxParameter Tanjuate Brunostar
2022-10-22 8:14 ` Greg KH
2022-10-22 8:28 ` Tanju Brunostar
2022-10-22 7:06 ` [PATCH v3 5/6] staging: vt6655: refactor long lines of code in the rest of the file Tanjuate Brunostar
2022-10-22 8:14 ` Greg KH
2022-10-22 8:29 ` Tanju Brunostar
2022-10-22 7:06 ` [PATCH v3 6/6] staging: vt6655: refactor code to avoid a line ending in '(' Tanjuate Brunostar
2022-10-22 7:35 ` [PATCH v3 0/6] a series of checkpatch fixes on the file: rxtx.c Greg KH
2022-10-22 8:22 ` Tanju Brunostar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cae0a94e73b1e44a7d8c750a406aa77d1942a06a.camel@perches.com \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=tanjubrunostar0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®