From: Andrew Lunn <andrew@lunn.ch>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Biju Das <biju.das.jz@bp.renesas.com>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH net-next] net: phy: mscc: Add support for PHY LEDs on VSC8541
Date: Fri, 7 Nov 2025 20:01:17 +0100 [thread overview]
Message-ID: <caef6e6e-b81e-45d7-ac92-ed6adc652aa2@lunn.ch> (raw)
In-Reply-To: <CA+V-a8uk-9pUrpXF3GDjwuDJBxpASpW8g5pHNBkd44JhF8AEew@mail.gmail.com>
> Certainly the probes can be simplified into a single function. I'll
> create a patch for this.
Please do make sure of each device having its own .probe
pointer. Don't have one probe function with lots of if/else
clauses. Put what is device specific into a device specific probe, and
what is common into helpers.
> > Also, is the LED handling you are adding here specific to the 8541? If
> > you look at the datasheets for the other devices, are any the same?
> >
> Looking at the below datasheets the LED handlings seem to be the same.
That is common. So yes, please add it to them all. It does not matter
if you can only test one device.
Andrew
next prev parent reply other threads:[~2025-11-07 19:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 20:03 Prabhakar
2025-11-06 20:45 ` Andrew Lunn
2025-11-07 10:34 ` Lad, Prabhakar
2025-11-07 12:28 ` Russell King (Oracle)
2025-11-07 12:53 ` Lad, Prabhakar
2025-11-07 13:14 ` Andrew Lunn
2025-11-07 18:55 ` Lad, Prabhakar
2025-11-07 19:01 ` Andrew Lunn [this message]
2025-11-07 19:07 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=caef6e6e-b81e-45d7-ac92-ed6adc652aa2@lunn.ch \
--to=andrew@lunn.ch \
--cc=biju.das.jz@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=vadim.fedorenko@linux.dev \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®