* [PATCH 1/1] mcb: Use DEFINE_RES_MEM() to simplify code
@ 2021-06-01 6:40 Zhen Lei
2021-06-01 13:24 ` Johannes Thumshirn
0 siblings, 1 reply; 2+ messages in thread
From: Zhen Lei @ 2021-06-01 6:40 UTC (permalink / raw)
To: Johannes Thumshirn, linux-kernel; +Cc: Zhen Lei
The value of '.end' should be "start + size - 1". So the previous writing
should have omitted subtracted 1.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/mcb/mcb-lpc.c | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/mcb/mcb-lpc.c b/drivers/mcb/mcb-lpc.c
index 506676754538b9e..53decd89876ee1b 100644
--- a/drivers/mcb/mcb-lpc.c
+++ b/drivers/mcb/mcb-lpc.c
@@ -105,17 +105,8 @@ static int mcb_lpc_create_platform_device(const struct dmi_system_id *id)
return ret;
}
-static struct resource sc24_fpga_resource = {
- .start = 0xe000e000,
- .end = 0xe000e000 + CHAM_HEADER_SIZE,
- .flags = IORESOURCE_MEM,
-};
-
-static struct resource sc31_fpga_resource = {
- .start = 0xf000e000,
- .end = 0xf000e000 + CHAM_HEADER_SIZE,
- .flags = IORESOURCE_MEM,
-};
+static struct resource sc24_fpga_resource = DEFINE_RES_MEM(0xe000e000, CHAM_HEADER_SIZE);
+static struct resource sc31_fpga_resource = DEFINE_RES_MEM(0xf000e000, CHAM_HEADER_SIZE);
static struct platform_driver mcb_lpc_driver = {
.driver = {
--
2.26.0.106.g9fadedd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-01 13:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 6:40 [PATCH 1/1] mcb: Use DEFINE_RES_MEM() to simplify code Zhen Lei
2021-06-01 13:24 ` Johannes Thumshirn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®