[regression] iwlwifi driver broken on Intel 3165 network card

[regression] iwlwifi driver broken on Intel 3165 network card

[Linux regression tracking (Thorsten Leemhuis)]

Hi, Thorsten here, the Linux kernel's regression tracker.

I noticed a regression report in bugzilla.kernel.org. As many (most?)
kernel developers don't keep an eye on it, I decided to forward it by mail.

Aloka Dixit, apparently it's cause by a change of yours: bd54f3c2907
("wifi: mac80211: generate EMA beacons in AP mode") [v6.4-rc1]

Note, you have to use bugzilla to reach the reporter, as I sadly[1] can
not CCed them in mails like this.

Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=217635 :

> Distro: Arch Linux
> Kernel version: 6.4.1.arch1-1
> Happens on mainline kernel? : YES (linux-mainline 6.4-1)
> Note: linux-mainline 6.4.1 is not available at time of this writing
> 
> Arch linux bug:
> https://bugs.archlinux.org/task/78984
> 
> Summary:
> No network access even after connecting to wifi. Websites don't load, ping doesn't work.
> This didn't happen on kernel 6.3.x (specifically 6.3.9, the last 6.3 kernel provided by Arch).
> 
> Bug happens on both Arch-provided kernel and mainline kernel
> 
> Steps to reproduce:
> 1) On fresh boot, connect to a wifi network
>    a) Make sure wifi password is not saved beforehand
> 2) Ping a url with terminal, or open a website with browser
> 3) Ping fails to work / website doesn't load

See the ticket for more details and the bisection result that came later.

Aditya Kumar Singh, FWIW, I hope you don't mind that I CCed you, but you
already contributed a fix for the culprit, so it seemed the right thing
to do in this case.

[TLDR for the rest of this mail: I'm adding this report to the list of
tracked Linux kernel regressions; the text you find below is based on a
few templates paragraphs you might have encountered already in similar
form.]

BTW, let me use this mail to also add the report to the list of tracked
regressions to ensure it's doesn't fall through the cracks:

#regzbot introduced: bd54f3c29077f2
https://bugzilla.kernel.org/show_bug.cgi?id=217635
#regzbot title: net: wireless: iwlwifi driver broken on Intel 3165
network card
#regzbot ignore-activity

This isn't a regression? This issue or a fix for it are already
discussed somewhere else? It was fixed already? You want to clarify when
the regression started to happen? Or point out I got the title or
something else totally wrong? Then just reply and tell me -- ideally
while also telling regzbot about it, as explained by the page listed in
the footer of this mail.

Developers: When fixing the issue, remember to add 'Link:' tags pointing
to the report (e.g. the buzgzilla ticket and maybe this mail as well, if
this thread sees some discussion). See page linked in footer for details.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

[1] because bugzilla.kernel.org tells users upon registration their
"email address will never be displayed to logged out users"

Re: [regression] iwlwifi driver broken on Intel 3165 network card

[Johannes Berg]

On Mon, 2023-07-10 at 10:32 +0200, Linux regression tracking (Thorsten
Leemhuis) wrote:
> Hi, Thorsten here, the Linux kernel's regression tracker.
> 
> I noticed a regression report in bugzilla.kernel.org. As many (most?)
> kernel developers don't keep an eye on it, I decided to forward it by mail.
> 
> Aloka Dixit, apparently it's cause by a change of yours: bd54f3c2907
> ("wifi: mac80211: generate EMA beacons in AP mode") [v6.4-rc1]
> 

That bisect result seems unlikely to be correct. Those changes are in
"how to get beacons" (in AP mode) which isn't even used in client mode
here.

johannes

Re: [regression] iwlwifi driver broken on Intel 3165 network card

[Linux regression tracking (Thorsten Leemhuis)]

On 10.07.23 17:02, Johannes Berg wrote:
> On Mon, 2023-07-10 at 10:32 +0200, Linux regression tracking (Thorsten
> Leemhuis) wrote:
>> Hi, Thorsten here, the Linux kernel's regression tracker.
>>
>> I noticed a regression report in bugzilla.kernel.org. As many (most?)
>> kernel developers don't keep an eye on it, I decided to forward it by mail.
>>
>> Aloka Dixit, apparently it's cause by a change of yours: bd54f3c2907
>> ("wifi: mac80211: generate EMA beacons in AP mode") [v6.4-rc1]
>>
> 
> That bisect result seems unlikely to be correct. Those changes are in
> "how to get beacons" (in AP mode) which isn't even used in client mode
> here.

You where right, the second bisect resulted in a different outcome.
Currently looks like 5fc3f6c90cc ("r8169: consolidate disabling ASPM
before EPHY access") [v6.4-rc1] is the culprit; this is somewhat odd as
well, but confirmed partially, as blacklisting r8169 apparently fixes
the issue. I nevertheless asked the reporter to recheck by reverting
that commit. Once that happened I'll notify the author of 5fc3f6c90cc.

Thx again and sorry for the noise.

BTW, in case anyone wants details, see:
https://bugzilla.kernel.org/show_bug.cgi?id=217635

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

Re: [regression] iwlwifi driver broken on Intel 3165 network card

[Johannes Berg]

On Wed, 2023-07-12 at 11:59 +0200, Linux regression tracking (Thorsten
Leemhuis) wrote:
> On 10.07.23 17:02, Johannes Berg wrote:
> > On Mon, 2023-07-10 at 10:32 +0200, Linux regression tracking (Thorsten
> > Leemhuis) wrote:
> > > Hi, Thorsten here, the Linux kernel's regression tracker.
> > > 
> > > I noticed a regression report in bugzilla.kernel.org. As many (most?)
> > > kernel developers don't keep an eye on it, I decided to forward it by mail.
> > > 
> > > Aloka Dixit, apparently it's cause by a change of yours: bd54f3c2907
> > > ("wifi: mac80211: generate EMA beacons in AP mode") [v6.4-rc1]
> > > 
> > 
> > That bisect result seems unlikely to be correct. Those changes are in
> > "how to get beacons" (in AP mode) which isn't even used in client mode
> > here.
> 
> You where right, the second bisect resulted in a different outcome.
> Currently looks like 5fc3f6c90cc ("r8169: consolidate disabling ASPM
> before EPHY access") [v6.4-rc1] is the culprit; this is somewhat odd as
> well, but confirmed partially, as blacklisting r8169 apparently fixes
> the issue.

That indeed is odd as well, but from the log it looks like r8169 is
actually present on the machine, so perhaps this messes with some PCI
bugs configuration badly enough? It looks harmless enough, but who
knows.

Anyway, thanks for letting me know.

johannes

[regression] r8169 ASPM changes broke iwlwifi driver for Intel 3165

[Linux regression tracking (Thorsten Leemhuis)]

[adding maintainers for r8169 to the list of recipients while dropping
the iwlwifi folks (the latter are already aware about the bad bisection)]

On 10.07.23 10:32, Linux regression tracking (Thorsten Leemhuis) wrote:
> Hi, Thorsten here, the Linux kernel's regression tracker.
> 
> I noticed a regression report in bugzilla.kernel.org. As many (most?)
> kernel developers don't keep an eye on it, I decided to forward it by mail.
> 
> Aloka Dixit, apparently it's cause by a change of yours: bd54f3c2907
> ("wifi: mac80211: generate EMA beacons in AP mode") [v6.4-rc1]

Heiner, this turned out to be a bad bisection. The reporter ran another
one and this time even verified the results by reverting the fix ontop
of v6.4. Turns out the issue is caused by 5fc3f6c90cc ("r8169:
consolidate disabling ASPM before EPHY access") you contributed.

Blacklisting r8169 fixes the issue, too. For details see:
https://bugzilla.kernel.org/show_bug.cgi?id=217635

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

> Note, you have to use bugzilla to reach the reporter, as I sadly[1] can
> not CCed them in mails like this.
> 
> Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=217635 :
> 
>> Distro: Arch Linux
>> Kernel version: 6.4.1.arch1-1
>> Happens on mainline kernel? : YES (linux-mainline 6.4-1)
>> Note: linux-mainline 6.4.1 is not available at time of this writing
>>
>> Arch linux bug:
>> https://bugs.archlinux.org/task/78984
>>
>> Summary:
>> No network access even after connecting to wifi. Websites don't load, ping doesn't work.
>> This didn't happen on kernel 6.3.x (specifically 6.3.9, the last 6.3 kernel provided by Arch).
>>
>> Bug happens on both Arch-provided kernel and mainline kernel
>>
>> Steps to reproduce:
>> 1) On fresh boot, connect to a wifi network
>>    a) Make sure wifi password is not saved beforehand
>> 2) Ping a url with terminal, or open a website with browser
>> 3) Ping fails to work / website doesn't load
> 
> See the ticket for more details and the bisection result that came later.
> 
> Aditya Kumar Singh, FWIW, I hope you don't mind that I CCed you, but you
> already contributed a fix for the culprit, so it seemed the right thing
> to do in this case.
> 
> [TLDR for the rest of this mail: I'm adding this report to the list of
> tracked Linux kernel regressions; the text you find below is based on a
> few templates paragraphs you might have encountered already in similar
> form.]
> 
> BTW, let me use this mail to also add the report to the list of tracked
> regressions to ensure it's doesn't fall through the cracks:
> 
> #regzbot introduced: bd54f3c29077f2
> https://bugzilla.kernel.org/show_bug.cgi?id=217635
> #regzbot title: net: wireless: iwlwifi driver broken on Intel 3165
> network card
> #regzbot ignore-activity

#regzbot introduced: 5fc3f6c90cca19e