From: JeffleXu <jefflexu@linux.alibaba.com>
To: Jia Zhu <zhujia.zj@bytedance.com>,
linux-erofs@lists.ozlabs.org, xiang@kernel.org, chao@kernel.org
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
yinxin.x@bytedance.com, huyue2@coolpad.com
Subject: Re: [PATCH V3 2/6] erofs: code clean up for fscache
Date: Thu, 15 Sep 2022 14:45:02 +0800 [thread overview]
Message-ID: <cb498259-08a1-2d94-c725-0188633efdb7@linux.alibaba.com> (raw)
In-Reply-To: <20220914105041.42970-3-zhujia.zj@bytedance.com>
On 9/14/22 6:50 PM, Jia Zhu wrote:
>
> @@ -485,13 +481,13 @@ void erofs_fscache_unregister_cookie(struct erofs_fscache **fscache)
> ctx->inode = NULL;
- ctx->cookie = NULL;
- ctx->inode = NULL;
I think the above two lines can also be deleted. After all @ctx will be
freed soon.
>
> kfree(ctx);
> - *fscache = NULL;
> }
>
--
Thanks,
Jingbo
next prev parent reply other threads:[~2022-09-15 6:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 10:50 [PATCH V3 0/6] Introduce erofs shared domain Jia Zhu
2022-09-14 10:50 ` [PATCH V3 1/6] erofs: use kill_anon_super() to kill super in fscache mode Jia Zhu
2022-09-15 2:28 ` JeffleXu
2022-09-15 6:07 ` [External] " Jia Zhu
2022-09-14 10:50 ` [PATCH V3 2/6] erofs: code clean up for fscache Jia Zhu
2022-09-15 2:26 ` JeffleXu
2022-09-15 6:45 ` JeffleXu [this message]
2022-09-14 10:50 ` [PATCH V3 3/6] erofs: introduce 'domain_id' mount option Jia Zhu
2022-09-15 7:30 ` JeffleXu
2022-09-15 7:43 ` [External] " Jia Zhu
2022-09-14 10:50 ` [PATCH V3 4/6] erofs: introduce fscache-based domain Jia Zhu
2022-09-14 13:21 ` Gao Xiang
2022-09-15 3:29 ` JeffleXu
2022-09-15 8:00 ` [External] " Jia Zhu
2022-09-15 3:27 ` JeffleXu
2022-09-14 10:50 ` [PATCH V3 5/6] erofs: introduce a pseudo mnt to manage shared cookies Jia Zhu
2022-09-15 5:43 ` JeffleXu
2022-09-14 10:50 ` [PATCH V3 6/6] erofs: Support sharing cookies in the same domain Jia Zhu
2022-09-14 13:30 ` Gao Xiang
2022-09-15 6:53 ` JeffleXu
2022-09-15 7:26 ` [External] " Jia Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb498259-08a1-2d94-c725-0188633efdb7@linux.alibaba.com \
--to=jefflexu@linux.alibaba.com \
--cc=chao@kernel.org \
--cc=huyue2@coolpad.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
--cc=yinxin.x@bytedance.com \
--cc=zhujia.zj@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®