* [PATCH] drm/bridge: waveshare-dsi: Fix bailout for devm_drm_bridge_alloc()
@ 2025-08-06 8:41 Liu Ying
2025-09-05 8:40 ` Liu Ying
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Liu Ying @ 2025-08-06 8:41 UTC (permalink / raw)
To: dri-devel, linux-kernel
Cc: andrzej.hajda, neil.armstrong, rfoss, Laurent.pinchart, jonas,
jernej.skrabec, maarten.lankhorst, mripard, tzimmermann, airlied,
simona, qijian.guo
devm_drm_bridge_alloc() returns ERR_PTR on failure instead of a
NULL pointer, so use IS_ERR() to check the returned pointer and
turn proper error code on failure by using PTR_ERR().
Fixes: dbdea37add13 ("drm: bridge: Add waveshare DSI2DPI unit driver")
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
drivers/gpu/drm/bridge/waveshare-dsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/waveshare-dsi.c b/drivers/gpu/drm/bridge/waveshare-dsi.c
index 01c70e7d3d3b..43f4e7412d72 100644
--- a/drivers/gpu/drm/bridge/waveshare-dsi.c
+++ b/drivers/gpu/drm/bridge/waveshare-dsi.c
@@ -147,8 +147,8 @@ static int ws_bridge_probe(struct i2c_client *i2c)
int ret;
ws = devm_drm_bridge_alloc(dev, struct ws_bridge, bridge, &ws_bridge_bridge_funcs);
- if (!ws)
- return -ENOMEM;
+ if (IS_ERR(ws))
+ return PTR_ERR(ws);
ws->dev = dev;
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/bridge: waveshare-dsi: Fix bailout for devm_drm_bridge_alloc()
2025-08-06 8:41 [PATCH] drm/bridge: waveshare-dsi: Fix bailout for devm_drm_bridge_alloc() Liu Ying
@ 2025-09-05 8:40 ` Liu Ying
2025-09-18 6:02 ` Liu Ying
2025-09-18 12:44 ` Dmitry Baryshkov
2025-09-19 3:06 ` Liu Ying
2 siblings, 1 reply; 5+ messages in thread
From: Liu Ying @ 2025-09-05 8:40 UTC (permalink / raw)
To: dri-devel, linux-kernel
Cc: andrzej.hajda, neil.armstrong, rfoss, Laurent.pinchart, jonas,
jernej.skrabec, maarten.lankhorst, mripard, tzimmermann, airlied,
simona, qijian.guo
On 8/6/25 16:41, Liu Ying wrote:
> devm_drm_bridge_alloc() returns ERR_PTR on failure instead of a
> NULL pointer, so use IS_ERR() to check the returned pointer and
> turn proper error code on failure by using PTR_ERR().
>
> Fixes: dbdea37add13 ("drm: bridge: Add waveshare DSI2DPI unit driver")
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
> drivers/gpu/drm/bridge/waveshare-dsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Gentle ping for review.
>
> diff --git a/drivers/gpu/drm/bridge/waveshare-dsi.c b/drivers/gpu/drm/bridge/waveshare-dsi.c
> index 01c70e7d3d3b..43f4e7412d72 100644
> --- a/drivers/gpu/drm/bridge/waveshare-dsi.c
> +++ b/drivers/gpu/drm/bridge/waveshare-dsi.c
> @@ -147,8 +147,8 @@ static int ws_bridge_probe(struct i2c_client *i2c)
> int ret;
>
> ws = devm_drm_bridge_alloc(dev, struct ws_bridge, bridge, &ws_bridge_bridge_funcs);
> - if (!ws)
> - return -ENOMEM;
> + if (IS_ERR(ws))
> + return PTR_ERR(ws);
>
> ws->dev = dev;
>
--
Regards,
Liu Ying
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/bridge: waveshare-dsi: Fix bailout for devm_drm_bridge_alloc()
2025-09-05 8:40 ` Liu Ying
@ 2025-09-18 6:02 ` Liu Ying
0 siblings, 0 replies; 5+ messages in thread
From: Liu Ying @ 2025-09-18 6:02 UTC (permalink / raw)
To: dri-devel, linux-kernel
Cc: andrzej.hajda, neil.armstrong, rfoss, Laurent.pinchart, jonas,
jernej.skrabec, maarten.lankhorst, mripard, tzimmermann, airlied,
simona, qijian.guo
On 09/05/2025, Liu Ying wrote:
> On 8/6/25 16:41, Liu Ying wrote:
>> devm_drm_bridge_alloc() returns ERR_PTR on failure instead of a
>> NULL pointer, so use IS_ERR() to check the returned pointer and
>> turn proper error code on failure by using PTR_ERR().
>>
>> Fixes: dbdea37add13 ("drm: bridge: Add waveshare DSI2DPI unit driver")
>> Signed-off-by: Liu Ying <victor.liu@nxp.com>
>> ---
>> drivers/gpu/drm/bridge/waveshare-dsi.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Gentle ping for review.
Ping again.
>
>>
>> diff --git a/drivers/gpu/drm/bridge/waveshare-dsi.c b/drivers/gpu/drm/bridge/waveshare-dsi.c
>> index 01c70e7d3d3b..43f4e7412d72 100644
>> --- a/drivers/gpu/drm/bridge/waveshare-dsi.c
>> +++ b/drivers/gpu/drm/bridge/waveshare-dsi.c
>> @@ -147,8 +147,8 @@ static int ws_bridge_probe(struct i2c_client *i2c)
>> int ret;
>>
>> ws = devm_drm_bridge_alloc(dev, struct ws_bridge, bridge, &ws_bridge_bridge_funcs);
>> - if (!ws)
>> - return -ENOMEM;
>> + if (IS_ERR(ws))
>> + return PTR_ERR(ws);
>>
>> ws->dev = dev;
>>
>
--
Regards,
Liu Ying
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/bridge: waveshare-dsi: Fix bailout for devm_drm_bridge_alloc()
2025-08-06 8:41 [PATCH] drm/bridge: waveshare-dsi: Fix bailout for devm_drm_bridge_alloc() Liu Ying
2025-09-05 8:40 ` Liu Ying
@ 2025-09-18 12:44 ` Dmitry Baryshkov
2025-09-19 3:06 ` Liu Ying
2 siblings, 0 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2025-09-18 12:44 UTC (permalink / raw)
To: Liu Ying
Cc: dri-devel, linux-kernel, andrzej.hajda, neil.armstrong, rfoss,
Laurent.pinchart, jonas, jernej.skrabec, maarten.lankhorst,
mripard, tzimmermann, airlied, simona, qijian.guo
On Wed, Aug 06, 2025 at 04:41:21PM +0800, Liu Ying wrote:
> devm_drm_bridge_alloc() returns ERR_PTR on failure instead of a
> NULL pointer, so use IS_ERR() to check the returned pointer and
> turn proper error code on failure by using PTR_ERR().
>
> Fixes: dbdea37add13 ("drm: bridge: Add waveshare DSI2DPI unit driver")
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
> drivers/gpu/drm/bridge/waveshare-dsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/bridge: waveshare-dsi: Fix bailout for devm_drm_bridge_alloc()
2025-08-06 8:41 [PATCH] drm/bridge: waveshare-dsi: Fix bailout for devm_drm_bridge_alloc() Liu Ying
2025-09-05 8:40 ` Liu Ying
2025-09-18 12:44 ` Dmitry Baryshkov
@ 2025-09-19 3:06 ` Liu Ying
2 siblings, 0 replies; 5+ messages in thread
From: Liu Ying @ 2025-09-19 3:06 UTC (permalink / raw)
To: dri-devel, linux-kernel
Cc: andrzej.hajda, neil.armstrong, rfoss, Laurent.pinchart, jonas,
jernej.skrabec, maarten.lankhorst, mripard, tzimmermann, airlied,
simona, qijian.guo
On 8/6/25 16:41, Liu Ying wrote:
> devm_drm_bridge_alloc() returns ERR_PTR on failure instead of a
> NULL pointer, so use IS_ERR() to check the returned pointer and
> turn proper error code on failure by using PTR_ERR().
>
> Fixes: dbdea37add13 ("drm: bridge: Add waveshare DSI2DPI unit driver")
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
> drivers/gpu/drm/bridge/waveshare-dsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to misc/kernel.git (drm-misc-next-fixes).
--
Regards,
Liu Ying
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-09-19 3:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-06 8:41 [PATCH] drm/bridge: waveshare-dsi: Fix bailout for devm_drm_bridge_alloc() Liu Ying
2025-09-05 8:40 ` Liu Ying
2025-09-18 6:02 ` Liu Ying
2025-09-18 12:44 ` Dmitry Baryshkov
2025-09-19 3:06 ` Liu Ying
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®