From: Trilok Soni <trilokkumar.soni@oss.qualcomm.com>
To: Vedashree Vidwans <vvidwans@nvidia.com>,
salman.nabi@arm.com, sudeep.holla@arm.com,
andre.przywara@arm.com, lpieralisi@kernel.org,
mark.rutland@arm.com
Cc: ardb@kernel.org, chao.gao@intel.com,
linux-arm-kernel@lists.infradead.org, linux-coco@lists.linux.dev,
linux-kernel@vger.kernel.org, sdonthineni@nvidia.com,
vsethi@nvidia.com, vwadekar@nvidia.com
Subject: Re: [PATCH 1/2] firmware: smccc: add timeout, touch wdt
Date: Tue, 10 Feb 2026 15:10:21 -0800 [thread overview]
Message-ID: <cb7f90b5-6e13-4659-a448-1f621b89c71a@oss.qualcomm.com> (raw)
In-Reply-To: <20260210224023.2341728-2-vvidwans@nvidia.com>
On 2/10/2026 2:40 PM, Vedashree Vidwans wrote:
> Enhance PRIME/ACTIVATION functions to touch watchdog and implement
> timeout mechanism. This update ensures that any potential hangs are
> detected promptly and that the LFA process is allocated sufficient
> execution time before the watchdog timer expires. These changes improve
> overall system reliability by reducing the risk of undetected process
> stalls and unexpected watchdog resets.
>
> Signed-off-by: Vedashree Vidwans <vvidwans@nvidia.com>
> ---
> drivers/firmware/smccc/lfa_fw.c | 40 +++++++++++++++++++++++++++++++++
> 1 file changed, 40 insertions(+)
>
> diff --git a/drivers/firmware/smccc/lfa_fw.c b/drivers/firmware/smccc/lfa_fw.c
> index da6b54fe1685..b0ace6fc8dac 100644
> --- a/drivers/firmware/smccc/lfa_fw.c
> +++ b/drivers/firmware/smccc/lfa_fw.c
> @@ -17,6 +17,9 @@
> #include <linux/array_size.h>
> #include <linux/list.h>
> #include <linux/mutex.h>
> +#include <linux/nmi.h>
> +#include <linux/ktime.h>
> +#include <linux/delay.h>
>
> #undef pr_fmt
> #define pr_fmt(fmt) "Arm LFA: " fmt
> @@ -37,6 +40,14 @@
> #define LFA_PRIME_CALL_AGAIN BIT(0)
> #define LFA_ACTIVATE_CALL_AGAIN BIT(0)
>
> +/* Prime loop limits, TODO: tune after testing */
Do you want to keep this TODO? Your patches are not marked as RFC.
> +#define LFA_PRIME_BUDGET_US 30000000 /* 30s cap */
> +#define LFA_PRIME_POLL_DELAY_US 10 /* 10us between polls */
Are these values going to be tunable from the userspace or kernel module parameters?
> +
> +/* Activation loop limits, TODO: tune after testing */
Ditto.
> +#define LFA_ACTIVATE_BUDGET_US 20000000 /* 20s cap */
> +#define LFA_ACTIVATE_POLL_DELAY_US 10 /* 10us between polls */
...
---Trilok Soni
next prev parent reply other threads:[~2026-02-10 23:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 22:40 [PATCH 0/2] Arm LFA: timeout and ACPI platform driver support Vedashree Vidwans
2026-02-10 22:40 ` [PATCH 1/2] firmware: smccc: add timeout, touch wdt Vedashree Vidwans
2026-02-10 23:10 ` Trilok Soni [this message]
2026-02-10 23:46 ` Vedashree Vidwans
2026-02-24 10:58 ` Andre Przywara
2026-02-10 22:40 ` [PATCH 2/2] firmware: smccc: register as platform driver Vedashree Vidwans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb7f90b5-6e13-4659-a448-1f621b89c71a@oss.qualcomm.com \
--to=trilokkumar.soni@oss.qualcomm.com \
--cc=andre.przywara@arm.com \
--cc=ardb@kernel.org \
--cc=chao.gao@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mark.rutland@arm.com \
--cc=salman.nabi@arm.com \
--cc=sdonthineni@nvidia.com \
--cc=sudeep.holla@arm.com \
--cc=vsethi@nvidia.com \
--cc=vvidwans@nvidia.com \
--cc=vwadekar@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®