From: Michael Straube <straube.linux@gmail.com>
To: Phillip Potter <phil@philpotter.co.uk>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
Martin Kaiser <martin@kaiser.cx>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
"open list:STAGING SUBSYSTEM" <linux-staging@lists.linux.dev>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: r8188eu: remove ip.h header file
Date: Tue, 24 Aug 2021 00:31:28 +0200 [thread overview]
Message-ID: <cb8d08f7-c27c-d6f3-1128-4047350d6871@gmail.com> (raw)
In-Reply-To: <CAA=Fs0=6=ueb53iNhyjSE5B8CdQvrpijgihAaN9YVwdDgNGiFA@mail.gmail.com>
On 8/24/21 12:21 AM, Phillip Potter wrote:
> On Mon, 23 Aug 2021 at 09:19, Michael Straube <straube.linux@gmail.com> wrote:
>>
>> The struct ip_options declared in ip.h is only unsed in the optlength
>> macro which is also defined in ip.h. All other definitions/declarations
>> in ip.h are duplicated from <include/uapi/linux/ip.h>. Remove the ip.h
>> header file and its includes.
>>
>> Signed-off-by: Michael Straube <straube.linux@gmail.com>
>> ---
>
> Dear Michael,
>
> Thanks for the patch. Sorry, but it seems to conflict with your
> earlier patch titled: "[PATCH] staging: r8188eu: remove if_ether.h
> header file". They apply fine individually, but not together - can you
> confirm this is the case for you as well and not just me?
>
> Regards,
> Phil
>
Hi Phillip,
yes I can confirm, sorry about that. I will rework and send both patches
in a series. Thank you for testing and pointing out this conflict.
best regards,
Michael
next prev parent reply other threads:[~2021-08-23 22:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 8:18 Michael Straube
2021-08-23 22:21 ` Phillip Potter
2021-08-23 22:31 ` Michael Straube [this message]
2021-08-23 22:38 ` Phillip Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb8d08f7-c27c-d6f3-1128-4047350d6871@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®