mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Alexander Koskovich <akoskovich@pm.me>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Abel Vesa <abelvesa@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] arm64: dts: qcom: milos-nothing-asteroids: Enable Bluetooth
Date: Fri, 30 Oct 2026 13:53:20 +0100	[thread overview]
Message-ID: <cbb0c355-7401-4edb-b67c-00976e1a3763@oss.qualcomm.com> (raw)
In-Reply-To: <20261029-asteroids-dts-updates-v1-2-79351337d681@pm.me>

On 10/29/26 11:33 PM, Alexander Koskovich wrote:
> Add the nodes to describe the WCN6755 chip with its PMU and Bluetooth
> parts.
> 
> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
> ---

[...]

> +&pmr735b_gpios {
> +	s1j_enable_default: s1j-enable-default-state {
> +		pins = "gpio1";
> +		function = PMIC_GPIO_FUNC_NORMAL;
> +		power-source = <0>;
> +		bias-disable;
> +		output-low;

The consuming driver takes care of the output state

[...]

> +	bluetooth_enable_default: bluetooth-enable-default-state {
> +		pins = "gpio53";
> +		function = "gpio";
> +		output-low;
> +		bias-disable;

Similarly here

> +	};
> +
>  	assist_default: assist-default-state {
>  		pins = "gpio71";
>  		function = "gpio";
> @@ -905,6 +1079,32 @@ &uart5 {
>  	status = "okay";
>  };
>  
> +&uart11 {
> +	/delete-property/ interrupts;
> +	interrupts-extended = <&intc GIC_SPI 586 IRQ_TYPE_LEVEL_HIGH 0>,
> +			      <&tlmm 51 IRQ_TYPE_EDGE_FALLING>;
> +
> +	pinctrl-1 = <&qup_uart11_sleep_cts>,
> +		     <&qup_uart11_sleep_rts>,
> +		     <&qup_uart11_sleep_tx>,
> +		     <&qup_uart11_sleep_rx>;

Please align the '<'s

Konrad

  reply	other threads:[~2026-10-30 12:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29 22:33 [PATCH 0/5] Enable some more hardware on the Nothing Phone (3a) Alexander Koskovich
2026-10-29 22:33 ` [PATCH 1/5] arm64: dts: qcom: milos-nothing-asteroids: Enable UFS Alexander Koskovich
2026-10-30 12:50   ` Konrad Dybcio
2026-10-29 22:33 ` [PATCH 2/5] arm64: dts: qcom: milos-nothing-asteroids: Enable Bluetooth Alexander Koskovich
2026-10-30 12:53   ` Konrad Dybcio [this message]
2026-10-29 22:33 ` [PATCH 3/5] arm64: dts: qcom: milos-nothing-asteroids: Enable WiFi Alexander Koskovich
2026-10-30 12:50   ` Konrad Dybcio
2026-10-29 22:33 ` [PATCH 4/5] arm64: dts: qcom: milos-nothing-asteroids: Enable IPA Alexander Koskovich
2026-10-30 12:51   ` Konrad Dybcio
2026-10-30 12:51   ` Konrad Dybcio
2026-10-29 22:34 ` [PATCH 5/5] arm64: dts: qcom: milos-nothing-asteroids: Enable panel Alexander Koskovich
2026-10-30 12:52   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cbb0c355-7401-4edb-b67c-00976e1a3763@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=abelvesa@kernel.org \
    --cc=akoskovich@pm.me \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®