From: Paul Moore <paul@paul-moore.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Cc: serge@hallyn.com, jmorris@namei.org, paul@paul-moore.co,
Ben Dooks <ben.dooks@codethink.co.uk>
Subject: Re: [PATCH] lsm: make keys for static branch static
Date: Tue, 06 Jan 2026 20:57:53 -0500 [thread overview]
Message-ID: <cbbd4457d76c90179a63a87645c688f0@paul-moore.com> (raw)
In-Reply-To: <20260106171332.69558-1-ben.dooks@codethink.co.uk>
On Jan 6, 2026 Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>
> The key use for static-branches are not refrenced by name outside
> of the security/security.c file, so make them static. This stops
> the sparse warnings about "Should it be static?" such as:
>
> security/security.c: note: in included file:
> ./include/linux/lsm_hook_defs.h:29:1: warning: symbol 'security_hook_active_binder_set_context_mgr_0' was not declared. Should it be static?
> ./include/linux/lsm_hook_defs.h:29:1: warning: symbol 'security_hook_active_binder_set_context_mgr_1' was not declared. Should it be static?
> ./include/linux/lsm_hook_defs.h:29:1: warning: symbol 'security_hook_active_binder_set_context_mgr_2' was not declared. Should it be static?
> ./include/linux/lsm_hook_defs.h:30:1: warning: symbol 'security_hook_active_binder_transaction_0' was not declared. Should it be static?
> ...
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> security/security.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Merged into lsm/dev, thanks.
--
paul-moore.com
prev parent reply other threads:[~2026-01-07 1:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 17:13 Ben Dooks
2026-01-07 1:57 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbbd4457d76c90179a63a87645c688f0@paul-moore.com \
--to=paul@paul-moore.com \
--cc=ben.dooks@codethink.co.uk \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.co \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®