* [PATCH v3 0/2] Cover letter QCC2072 enablement
@ 2026-02-09 8:06 Vivek Sahu
2026-02-09 8:06 ` [PATCH v3 1/2] dt-bindings: net: bluetooth: qualcomm: add bindings for QCC2072 Vivek Sahu
2026-02-09 8:06 ` [PATCH v3 2/2] Bluetooth: qca: add QCC2072 support Vivek Sahu
0 siblings, 2 replies; 17+ messages in thread
From: Vivek Sahu @ 2026-02-09 8:06 UTC (permalink / raw)
To: Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski,
Balakrishna Godavarthi, Rocky Liao
Cc: quic_mohamull, quic_hbandi, linux-bluetooth, devicetree,
linux-kernel, linux-arm-msm, Vivek Sahu
The history of the patch set as follows.
v1: First commit to add support of QCC2072 chipset
v2: resolving review comments to sort the chipset in the switch case
and other files whenever possible. "qca_btsoc_type" enum in
drivers/bluetooth/btqca.h contains all the soc type which need to be
enabled for BT enablement on the target device. There are few places
where logic of framing packets transferring between SoC and Host
depends on the which generation of the chip it is, refer api
"qca_read_soc_version". So It is not sorted in btqca.h file.
v3: indentation fix and "qcom,wcn3950-bt" is deleted by mistake.
Signed-off-by: Vivek Sahu <vivek.sahu@oss.qualcomm.com>
Vivek Sahu (2):
dt-bindings: net: bluetooth: qualcomm: add bindings for QCC2072
Bluetooth: qca: add QCC2072 support
.../net/bluetooth/qualcomm-bluetooth.yaml | 3 +-
drivers/bluetooth/btqca.c | 41 +++++++++++--------
drivers/bluetooth/btqca.h | 1 +
drivers/bluetooth/hci_qca.c | 40 +++++++++++++-----
4 files changed, 56 insertions(+), 29 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH v3 1/2] dt-bindings: net: bluetooth: qualcomm: add bindings for QCC2072 2026-02-09 8:06 [PATCH v3 0/2] Cover letter QCC2072 enablement Vivek Sahu @ 2026-02-09 8:06 ` Vivek Sahu 2026-02-09 8:07 ` Krzysztof Kozlowski 2026-02-09 11:32 ` Bartosz Golaszewski 2026-02-09 8:06 ` [PATCH v3 2/2] Bluetooth: qca: add QCC2072 support Vivek Sahu 1 sibling, 2 replies; 17+ messages in thread From: Vivek Sahu @ 2026-02-09 8:06 UTC (permalink / raw) To: Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Balakrishna Godavarthi, Rocky Liao Cc: quic_mohamull, quic_hbandi, linux-bluetooth, devicetree, linux-kernel, linux-arm-msm, Vivek Sahu QCC2072 is a WiFi/BT connectivity chip. It requires different firmware, so document it as a new compat string. Correct the sorting of other chipsets for better readability. Signed-off-by: Vivek Sahu <vivek.sahu@oss.qualcomm.com> --- .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml index 6353a336f382..85cf65efca92 100644 --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml @@ -18,13 +18,14 @@ properties: enum: - qcom,qca2066-bt - qcom,qca6174-bt + - qcom,qca6390-bt - qcom,qca9377-bt + - qcom,qcc2072-bt - qcom,wcn3950-bt - qcom,wcn3988-bt - qcom,wcn3990-bt - qcom,wcn3991-bt - qcom,wcn3998-bt - - qcom,qca6390-bt - qcom,wcn6750-bt - qcom,wcn6855-bt - qcom,wcn7850-bt -- 2.34.1 ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: net: bluetooth: qualcomm: add bindings for QCC2072 2026-02-09 8:06 ` [PATCH v3 1/2] dt-bindings: net: bluetooth: qualcomm: add bindings for QCC2072 Vivek Sahu @ 2026-02-09 8:07 ` Krzysztof Kozlowski 2026-02-09 11:35 ` Bartosz Golaszewski 2026-02-09 15:43 ` Vivek Sahu 2026-02-09 11:32 ` Bartosz Golaszewski 1 sibling, 2 replies; 17+ messages in thread From: Krzysztof Kozlowski @ 2026-02-09 8:07 UTC (permalink / raw) To: Vivek Sahu, Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Balakrishna Godavarthi, Rocky Liao Cc: quic_mohamull, quic_hbandi, linux-bluetooth, devicetree, linux-kernel, linux-arm-msm On 09/02/2026 09:06, Vivek Sahu wrote: > QCC2072 is a WiFi/BT connectivity chip. > It requires different firmware, so document it as a new compat string. > > Correct the sorting of other chipsets for better readability. > > Signed-off-by: Vivek Sahu <vivek.sahu@oss.qualcomm.com> > --- > .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 3 ++- There is no such file. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: net: bluetooth: qualcomm: add bindings for QCC2072 2026-02-09 8:07 ` Krzysztof Kozlowski @ 2026-02-09 11:35 ` Bartosz Golaszewski 2026-02-09 15:43 ` Vivek Sahu 1 sibling, 0 replies; 17+ messages in thread From: Bartosz Golaszewski @ 2026-02-09 11:35 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: quic_mohamull, quic_hbandi, linux-bluetooth, devicetree, linux-kernel, linux-arm-msm, Vivek Sahu, Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Balakrishna Godavarthi, Rocky Liao On Mon, 9 Feb 2026 09:07:58 +0100, Krzysztof Kozlowski <krzk@kernel.org> said: > On 09/02/2026 09:06, Vivek Sahu wrote: >> QCC2072 is a WiFi/BT connectivity chip. >> It requires different firmware, so document it as a new compat string. >> >> Correct the sorting of other chipsets for better readability. >> >> Signed-off-by: Vivek Sahu <vivek.sahu@oss.qualcomm.com> >> --- >> .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 3 ++- > > There is no such file. > Ah, -ETOOFAST, I'm retracting by R-b. Thanks Krzysztof for catching it. Bartosz ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: net: bluetooth: qualcomm: add bindings for QCC2072 2026-02-09 8:07 ` Krzysztof Kozlowski 2026-02-09 11:35 ` Bartosz Golaszewski @ 2026-02-09 15:43 ` Vivek Sahu 2026-02-09 16:08 ` Krzysztof Kozlowski 1 sibling, 1 reply; 17+ messages in thread From: Vivek Sahu @ 2026-02-09 15:43 UTC (permalink / raw) To: Krzysztof Kozlowski, Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Balakrishna Godavarthi, Rocky Liao Cc: quic_mohamull, quic_hbandi, linux-bluetooth, devicetree, linux-kernel, linux-arm-msm On 2/9/2026 1:37 PM, Krzysztof Kozlowski wrote: > On 09/02/2026 09:06, Vivek Sahu wrote: >> QCC2072 is a WiFi/BT connectivity chip. >> It requires different firmware, so document it as a new compat string. >> >> Correct the sorting of other chipsets for better readability. >> >> Signed-off-by: Vivek Sahu <vivek.sahu@oss.qualcomm.com> >> --- >> .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 3 ++- > There is no such file. > > Best regards, > Krzysztof The patch is updated on "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git" repo but it appears that CI build is running on "kernel/git/next/linux-next.git" where this file is not present. Let me check linux-next branch and see how binding doc file is created. Will upload a new patch set based on that. ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: net: bluetooth: qualcomm: add bindings for QCC2072 2026-02-09 15:43 ` Vivek Sahu @ 2026-02-09 16:08 ` Krzysztof Kozlowski 2026-02-10 12:05 ` Vivek Sahu 0 siblings, 1 reply; 17+ messages in thread From: Krzysztof Kozlowski @ 2026-02-09 16:08 UTC (permalink / raw) To: Vivek Sahu, Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Balakrishna Godavarthi, Rocky Liao Cc: quic_mohamull, quic_hbandi, linux-bluetooth, devicetree, linux-kernel, linux-arm-msm On 09/02/2026 16:43, Vivek Sahu wrote: > > On 2/9/2026 1:37 PM, Krzysztof Kozlowski wrote: >> On 09/02/2026 09:06, Vivek Sahu wrote: >>> QCC2072 is a WiFi/BT connectivity chip. >>> It requires different firmware, so document it as a new compat string. >>> >>> Correct the sorting of other chipsets for better readability. >>> >>> Signed-off-by: Vivek Sahu <vivek.sahu@oss.qualcomm.com> >>> --- >>> .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 3 ++- >> There is no such file. >> >> Best regards, >> Krzysztof > The patch is updated on > "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git" repo This is not correct base. Why would you base on something old, without any in-flight accepted patches? You are supposed to work on maintainer's tree. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: net: bluetooth: qualcomm: add bindings for QCC2072 2026-02-09 16:08 ` Krzysztof Kozlowski @ 2026-02-10 12:05 ` Vivek Sahu 2026-02-11 19:23 ` Luiz Augusto von Dentz 0 siblings, 1 reply; 17+ messages in thread From: Vivek Sahu @ 2026-02-10 12:05 UTC (permalink / raw) To: Krzysztof Kozlowski, Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Balakrishna Godavarthi, Rocky Liao Cc: quic_mohamull, quic_hbandi, linux-bluetooth, devicetree, linux-kernel, linux-arm-msm On 2/9/2026 9:38 PM, Krzysztof Kozlowski wrote: > On 09/02/2026 16:43, Vivek Sahu wrote: >> On 2/9/2026 1:37 PM, Krzysztof Kozlowski wrote: >>> On 09/02/2026 09:06, Vivek Sahu wrote: >>>> QCC2072 is a WiFi/BT connectivity chip. >>>> It requires different firmware, so document it as a new compat string. >>>> >>>> Correct the sorting of other chipsets for better readability. >>>> >>>> Signed-off-by: Vivek Sahu <vivek.sahu@oss.qualcomm.com> >>>> --- >>>> .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 3 ++- >>> There is no such file. >>> >>> Best regards, >>> Krzysztof >> The patch is updated on >> "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git" repo > This is not correct base. Why would you base on something old, without > any in-flight accepted patches? > > You are supposed to work on maintainer's tree. > > Best regards, > Krzysztof Yes, I'm now raising patch on linux-next branch. Please ignore this commit. ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: net: bluetooth: qualcomm: add bindings for QCC2072 2026-02-10 12:05 ` Vivek Sahu @ 2026-02-11 19:23 ` Luiz Augusto von Dentz 0 siblings, 0 replies; 17+ messages in thread From: Luiz Augusto von Dentz @ 2026-02-11 19:23 UTC (permalink / raw) To: Vivek Sahu Cc: Krzysztof Kozlowski, Marcel Holtmann, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Balakrishna Godavarthi, Rocky Liao, quic_mohamull, quic_hbandi, linux-bluetooth, devicetree, linux-kernel, linux-arm-msm Hi Vivek, On Tue, Feb 10, 2026 at 7:05 AM Vivek Sahu <vivek.sahu@oss.qualcomm.com> wrote: > > > On 2/9/2026 9:38 PM, Krzysztof Kozlowski wrote: > > On 09/02/2026 16:43, Vivek Sahu wrote: > >> On 2/9/2026 1:37 PM, Krzysztof Kozlowski wrote: > >>> On 09/02/2026 09:06, Vivek Sahu wrote: > >>>> QCC2072 is a WiFi/BT connectivity chip. > >>>> It requires different firmware, so document it as a new compat string. > >>>> > >>>> Correct the sorting of other chipsets for better readability. > >>>> > >>>> Signed-off-by: Vivek Sahu <vivek.sahu@oss.qualcomm.com> > >>>> --- > >>>> .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 3 ++- > >>> There is no such file. > >>> > >>> Best regards, > >>> Krzysztof > >> The patch is updated on > >> "git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git" repo > > This is not correct base. Why would you base on something old, without > > any in-flight accepted patches? > > > > You are supposed to work on maintainer's tree. > > > > Best regards, > > Krzysztof > Yes, I'm now raising patch on linux-next branch. Please ignore this commit. If it goes in via bluetooth-next, which is probably the case, then please rebase on top of it. -- Luiz Augusto von Dentz ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: net: bluetooth: qualcomm: add bindings for QCC2072 2026-02-09 8:06 ` [PATCH v3 1/2] dt-bindings: net: bluetooth: qualcomm: add bindings for QCC2072 Vivek Sahu 2026-02-09 8:07 ` Krzysztof Kozlowski @ 2026-02-09 11:32 ` Bartosz Golaszewski 1 sibling, 0 replies; 17+ messages in thread From: Bartosz Golaszewski @ 2026-02-09 11:32 UTC (permalink / raw) To: Vivek Sahu Cc: quic_mohamull, quic_hbandi, linux-bluetooth, devicetree, linux-kernel, linux-arm-msm, Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Balakrishna Godavarthi, Rocky Liao On Mon, 9 Feb 2026 09:06:12 +0100, Vivek Sahu <vivek.sahu@oss.qualcomm.com> said: > QCC2072 is a WiFi/BT connectivity chip. > It requires different firmware, so document it as a new compat string. > > Correct the sorting of other chipsets for better readability. > > Signed-off-by: Vivek Sahu <vivek.sahu@oss.qualcomm.com> > --- > .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml > index 6353a336f382..85cf65efca92 100644 > --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml > +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml > @@ -18,13 +18,14 @@ properties: > enum: > - qcom,qca2066-bt > - qcom,qca6174-bt > + - qcom,qca6390-bt > - qcom,qca9377-bt > + - qcom,qcc2072-bt > - qcom,wcn3950-bt > - qcom,wcn3988-bt > - qcom,wcn3990-bt > - qcom,wcn3991-bt > - qcom,wcn3998-bt > - - qcom,qca6390-bt > - qcom,wcn6750-bt > - qcom,wcn6855-bt > - qcom,wcn7850-bt > -- > 2.34.1 > > Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com> ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v3 2/2] Bluetooth: qca: add QCC2072 support 2026-02-09 8:06 [PATCH v3 0/2] Cover letter QCC2072 enablement Vivek Sahu 2026-02-09 8:06 ` [PATCH v3 1/2] dt-bindings: net: bluetooth: qualcomm: add bindings for QCC2072 Vivek Sahu @ 2026-02-09 8:06 ` Vivek Sahu 2026-02-09 11:34 ` Bartosz Golaszewski 1 sibling, 1 reply; 17+ messages in thread From: Vivek Sahu @ 2026-02-09 8:06 UTC (permalink / raw) To: Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Balakrishna Godavarthi, Rocky Liao Cc: quic_mohamull, quic_hbandi, linux-bluetooth, devicetree, linux-kernel, linux-arm-msm, Vivek Sahu QCC2072 is a family of WiFi/BT connectivity chip. It requires different firmware files and has different configurations , so add it as a separate SoC type. Correct the sorting of other chipsets for better readability. The firmware for these chips has been recently added to the linux-firmware repository and will be a part of the upcoming release. Signed-off-by: Vivek Sahu <vivek.sahu@oss.qualcomm.com> --- drivers/bluetooth/btqca.c | 41 ++++++++++++++++++++++--------------- drivers/bluetooth/btqca.h | 1 + drivers/bluetooth/hci_qca.c | 40 ++++++++++++++++++++++++++---------- 3 files changed, 54 insertions(+), 28 deletions(-) diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c index 7c958d6065be..9b9f4b435032 100644 --- a/drivers/bluetooth/btqca.c +++ b/drivers/bluetooth/btqca.c @@ -816,6 +816,17 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate, snprintf(config.fwname, sizeof(config.fwname), "qca/%s", rampatch_name); } else { switch (soc_type) { + case QCA_QCA2066: + snprintf(config.fwname, sizeof(config.fwname), + "qca/hpbtfw%02x.tlv", rom_ver); + break; + case QCA_QCA6390: + snprintf(config.fwname, sizeof(config.fwname), + "qca/htbtfw%02x.tlv", rom_ver); + break; + case QCA_QCC2072: + snprintf(config.fwname, sizeof(config.fwname), + "qca/ornbtfw%02x.tlv", rom_ver); case QCA_WCN3950: snprintf(config.fwname, sizeof(config.fwname), "qca/cmbtfw%02x.tlv", rom_ver); @@ -830,14 +841,6 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate, snprintf(config.fwname, sizeof(config.fwname), "qca/apbtfw%02x.tlv", rom_ver); break; - case QCA_QCA2066: - snprintf(config.fwname, sizeof(config.fwname), - "qca/hpbtfw%02x.tlv", rom_ver); - break; - case QCA_QCA6390: - snprintf(config.fwname, sizeof(config.fwname), - "qca/htbtfw%02x.tlv", rom_ver); - break; case QCA_WCN6750: /* Choose mbn file by default.If mbn file is not found * then choose tlv file @@ -885,6 +888,19 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate, } } else { switch (soc_type) { + case QCA_QCA2066: + qca_get_nvm_name_by_board(config.fwname, + sizeof(config.fwname), "hpnv", soc_type, ver, + rom_ver, boardid); + break; + case QCA_QCA6390: + snprintf(config.fwname, sizeof(config.fwname), + "qca/htnv%02x.bin", rom_ver); + break; + case QCA_QCC2072: + snprintf(config.fwname, sizeof(config.fwname), + "qca/ornnv%02x.bin", rom_ver); + break; case QCA_WCN3950: if (le32_to_cpu(ver.soc_id) == QCA_WCN3950_SOC_ID_T) variant = "t"; @@ -907,15 +923,6 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate, snprintf(config.fwname, sizeof(config.fwname), "qca/apnv%02x.bin", rom_ver); break; - case QCA_QCA2066: - qca_get_nvm_name_by_board(config.fwname, - sizeof(config.fwname), "hpnv", soc_type, ver, - rom_ver, boardid); - break; - case QCA_QCA6390: - snprintf(config.fwname, sizeof(config.fwname), - "qca/htnv%02x.bin", rom_ver); - break; case QCA_WCN6750: snprintf(config.fwname, sizeof(config.fwname), "qca/msnv%02x.bin", rom_ver); diff --git a/drivers/bluetooth/btqca.h b/drivers/bluetooth/btqca.h index 8f3c1b1c77b3..a175ac31e7b2 100644 --- a/drivers/bluetooth/btqca.h +++ b/drivers/bluetooth/btqca.h @@ -158,6 +158,7 @@ enum qca_btsoc_type { QCA_WCN6750, QCA_WCN6855, QCA_WCN7850, + QCA_QCC2072, }; #if IS_ENABLED(CONFIG_BT_QCA) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 888176b0faa9..2ce6e19e5b86 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -623,6 +623,7 @@ static int qca_open(struct hci_uart *hu) qcadev = serdev_device_get_drvdata(hu->serdev); switch (qcadev->btsoc_type) { + case QCA_QCC2072: case QCA_WCN3950: case QCA_WCN3988: case QCA_WCN3990: @@ -1498,6 +1499,7 @@ static int qca_set_speed(struct hci_uart *hu, enum qca_speed_type speed_type) * changing the baudrate of chip and host. */ switch (soc_type) { + case QCA_QCC2072: case QCA_WCN3950: case QCA_WCN3988: case QCA_WCN3990: @@ -1514,6 +1516,7 @@ static int qca_set_speed(struct hci_uart *hu, enum qca_speed_type speed_type) } switch (soc_type) { + case QCA_QCC2072: case QCA_WCN3990: reinit_completion(&qca->drop_ev_comp); set_bit(QCA_DROP_VENDOR_EVENT, &qca->flags); @@ -1533,6 +1536,7 @@ static int qca_set_speed(struct hci_uart *hu, enum qca_speed_type speed_type) error: switch (soc_type) { + case QCA_QCC2072: case QCA_WCN3950: case QCA_WCN3988: case QCA_WCN3990: @@ -1549,6 +1553,7 @@ static int qca_set_speed(struct hci_uart *hu, enum qca_speed_type speed_type) } switch (soc_type) { + case QCA_QCC2072: case QCA_WCN3990: /* Wait for the controller to send the vendor event * for the baudrate change command. @@ -1900,6 +1905,10 @@ static int qca_setup(struct hci_uart *hu) soc_name = "qca2066"; break; + case QCA_QCC2072: + soc_name = "qcc2072"; + break; + case QCA_WCN3950: case QCA_WCN3988: case QCA_WCN3990: @@ -1935,6 +1944,7 @@ static int qca_setup(struct hci_uart *hu) clear_bit(QCA_SSR_TRIGGERED, &qca->flags); switch (soc_type) { + case QCA_QCC2072: case QCA_WCN3950: case QCA_WCN3988: case QCA_WCN3990: @@ -1969,6 +1979,7 @@ static int qca_setup(struct hci_uart *hu) } switch (soc_type) { + case QCA_QCC2072: case QCA_WCN3950: case QCA_WCN3988: case QCA_WCN3990: @@ -2058,6 +2069,23 @@ static const struct hci_uart_proto qca_proto = { .dequeue = qca_dequeue, }; +static const struct qca_device_data qca_soc_data_qca2066 __maybe_unused = { + .soc_type = QCA_QCA2066, + .num_vregs = 0, +}; + +static const struct qca_device_data qca_soc_data_qca6390 __maybe_unused = { + .soc_type = QCA_QCA6390, + .num_vregs = 0, + .capabilities = QCA_CAP_WIDEBAND_SPEECH | QCA_CAP_VALID_LE_STATES, +}; + +static const struct qca_device_data qca_soc_data_qcc2072 __maybe_unused = { + .soc_type = QCA_QCC2072, + .num_vregs = 0, + .capabilities = QCA_CAP_WIDEBAND_SPEECH | QCA_CAP_VALID_LE_STATES, +}; + static const struct qca_device_data qca_soc_data_wcn3950 __maybe_unused = { .soc_type = QCA_WCN3950, .vregs = (struct qca_vreg []) { @@ -2114,17 +2142,6 @@ static const struct qca_device_data qca_soc_data_wcn3998 __maybe_unused = { .num_vregs = 4, }; -static const struct qca_device_data qca_soc_data_qca2066 __maybe_unused = { - .soc_type = QCA_QCA2066, - .num_vregs = 0, - .capabilities = QCA_CAP_WIDEBAND_SPEECH | QCA_CAP_VALID_LE_STATES, -}; - -static const struct qca_device_data qca_soc_data_qca6390 __maybe_unused = { - .soc_type = QCA_QCA6390, - .num_vregs = 0, -}; - static const struct qca_device_data qca_soc_data_wcn6750 __maybe_unused = { .soc_type = QCA_WCN6750, .vregs = (struct qca_vreg []) { @@ -2715,6 +2732,7 @@ static const struct of_device_id qca_bluetooth_of_match[] = { { .compatible = "qcom,qca6174-bt" }, { .compatible = "qcom,qca6390-bt", .data = &qca_soc_data_qca6390}, { .compatible = "qcom,qca9377-bt" }, + { .compatible = "qcom,qcc2072-bt", .data = &qca_soc_data_qcc2072}, { .compatible = "qcom,wcn3950-bt", .data = &qca_soc_data_wcn3950}, { .compatible = "qcom,wcn3988-bt", .data = &qca_soc_data_wcn3988}, { .compatible = "qcom,wcn3990-bt", .data = &qca_soc_data_wcn3990}, -- 2.34.1 ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 2/2] Bluetooth: qca: add QCC2072 support 2026-02-09 8:06 ` [PATCH v3 2/2] Bluetooth: qca: add QCC2072 support Vivek Sahu @ 2026-02-09 11:34 ` Bartosz Golaszewski 2026-02-09 15:45 ` Vivek Sahu 2026-02-10 12:11 ` Vivek Sahu 0 siblings, 2 replies; 17+ messages in thread From: Bartosz Golaszewski @ 2026-02-09 11:34 UTC (permalink / raw) To: Vivek Sahu Cc: quic_mohamull, quic_hbandi, linux-bluetooth, devicetree, linux-kernel, linux-arm-msm, Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski, Balakrishna Godavarthi, Rocky Liao On Mon, 9 Feb 2026 09:06:13 +0100, Vivek Sahu <vivek.sahu@oss.qualcomm.com> said: > QCC2072 is a family of WiFi/BT connectivity chip. > It requires different firmware files and has different > configurations , so add it as a separate SoC type. > > Correct the sorting of other chipsets for better readability. > > The firmware for these chips has been recently added to the > linux-firmware repository and will be a part of the upcoming > release. Something is wrong with formatting here. I would personally split the sorting and support for the new model into two patches - without and with functional changes respectively - for easier review. Bartosz ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 2/2] Bluetooth: qca: add QCC2072 support 2026-02-09 11:34 ` Bartosz Golaszewski @ 2026-02-09 15:45 ` Vivek Sahu 2026-02-10 12:11 ` Vivek Sahu 1 sibling, 0 replies; 17+ messages in thread From: Vivek Sahu @ 2026-02-09 15:45 UTC (permalink / raw) To: Bartosz Golaszewski Cc: quic_mohamull, quic_hbandi, linux-bluetooth, devicetree, linux-kernel, linux-arm-msm, Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Balakrishna Godavarthi, Rocky Liao On 2/9/2026 5:04 PM, Bartosz Golaszewski wrote: > On Mon, 9 Feb 2026 09:06:13 +0100, Vivek Sahu > <vivek.sahu@oss.qualcomm.com> said: >> QCC2072 is a family of WiFi/BT connectivity chip. >> It requires different firmware files and has different >> configurations , so add it as a separate SoC type. >> >> Correct the sorting of other chipsets for better readability. >> >> The firmware for these chips has been recently added to the >> linux-firmware repository and will be a part of the upcoming >> release. > Something is wrong with formatting here. > > I would personally split the sorting and support for the new model into two > patches - without and with functional changes respectively - for easier review. > > Bartosz I'll divide this patch into 2 parts, one for sorting and another one for adding support for new chip-set. ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 2/2] Bluetooth: qca: add QCC2072 support 2026-02-09 11:34 ` Bartosz Golaszewski 2026-02-09 15:45 ` Vivek Sahu @ 2026-02-10 12:11 ` Vivek Sahu 2026-02-10 12:16 ` Dmitry Baryshkov 1 sibling, 1 reply; 17+ messages in thread From: Vivek Sahu @ 2026-02-10 12:11 UTC (permalink / raw) To: Bartosz Golaszewski Cc: quic_mohamull, quic_hbandi, linux-bluetooth, devicetree, linux-kernel, linux-arm-msm, Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Balakrishna Godavarthi, Rocky Liao On 2/9/2026 5:04 PM, Bartosz Golaszewski wrote: > On Mon, 9 Feb 2026 09:06:13 +0100, Vivek Sahu > <vivek.sahu@oss.qualcomm.com> said: >> QCC2072 is a family of WiFi/BT connectivity chip. >> It requires different firmware files and has different >> configurations , so add it as a separate SoC type. >> >> Correct the sorting of other chipsets for better readability. >> >> The firmware for these chips has been recently added to the >> linux-firmware repository and will be a part of the upcoming >> release. > Something is wrong with formatting here. > > I would personally split the sorting and support for the new model into two > patches - without and with functional changes respectively - for easier review. > > Bartosz Yes, I'm now splitting this patch into 2 parts, one for sorting another one for new model support. Please ignore this patch. Sorting change has been raised with tittle "[PATCH v1] Bluetooth: qca: Refactor code on the basis of chipset names". Please approve it at quickest so that we can raise new model addition code changes on top of that. ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 2/2] Bluetooth: qca: add QCC2072 support 2026-02-10 12:11 ` Vivek Sahu @ 2026-02-10 12:16 ` Dmitry Baryshkov 2026-02-10 13:53 ` Vivek Sahu 0 siblings, 1 reply; 17+ messages in thread From: Dmitry Baryshkov @ 2026-02-10 12:16 UTC (permalink / raw) To: Vivek Sahu Cc: Bartosz Golaszewski, quic_mohamull, quic_hbandi, linux-bluetooth, devicetree, linux-kernel, linux-arm-msm, Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Balakrishna Godavarthi, Rocky Liao On Tue, Feb 10, 2026 at 05:41:13PM +0530, Vivek Sahu wrote: > > On 2/9/2026 5:04 PM, Bartosz Golaszewski wrote: > > On Mon, 9 Feb 2026 09:06:13 +0100, Vivek Sahu > > <vivek.sahu@oss.qualcomm.com> said: > > > QCC2072 is a family of WiFi/BT connectivity chip. > > > It requires different firmware files and has different > > > configurations , so add it as a separate SoC type. > > > > > > Correct the sorting of other chipsets for better readability. > > > > > > The firmware for these chips has been recently added to the > > > linux-firmware repository and will be a part of the upcoming > > > release. > > Something is wrong with formatting here. > > > > I would personally split the sorting and support for the new model into two > > patches - without and with functional changes respectively - for easier review. > > > > Bartosz > > Yes, I'm now splitting this patch into 2 parts, one for sorting another one > for new model > > support. Please ignore this patch. Please stop adding extra empty lines between (or fix your email client). > > Sorting change has been raised with tittle "[PATCH v1] Bluetooth: qca: > Refactor code on > > the basis of chipset names". Please approve it at quickest so that we can > raise new model > > addition code changes on top of that. Why couldn't you send it as 2 patches in a single series? -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 2/2] Bluetooth: qca: add QCC2072 support 2026-02-10 12:16 ` Dmitry Baryshkov @ 2026-02-10 13:53 ` Vivek Sahu 2026-02-11 1:48 ` Dmitry Baryshkov 0 siblings, 1 reply; 17+ messages in thread From: Vivek Sahu @ 2026-02-10 13:53 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Bartosz Golaszewski, quic_mohamull, quic_hbandi, linux-bluetooth, devicetree, linux-kernel, linux-arm-msm, Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Balakrishna Godavarthi, Rocky Liao On 2/10/2026 5:46 PM, Dmitry Baryshkov wrote: > On Tue, Feb 10, 2026 at 05:41:13PM +0530, Vivek Sahu wrote: >> >> On 2/9/2026 5:04 PM, Bartosz Golaszewski wrote: >>> On Mon, 9 Feb 2026 09:06:13 +0100, Vivek Sahu >>> <vivek.sahu@oss.qualcomm.com> said: >>>> QCC2072 is a family of WiFi/BT connectivity chip. >>>> It requires different firmware files and has different >>>> configurations , so add it as a separate SoC type. >>>> >>>> Correct the sorting of other chipsets for better readability. >>>> >>>> The firmware for these chips has been recently added to the >>>> linux-firmware repository and will be a part of the upcoming >>>> release. >>> Something is wrong with formatting here. >>> >>> I would personally split the sorting and support for the new model into two >>> patches - without and with functional changes respectively - for easier review. >>> >>> Bartosz >> >> Yes, I'm now splitting this patch into 2 parts, one for sorting another one >> for new model >> >> support. Please ignore this patch. > > Please stop adding extra empty lines between (or fix your email client). > >> >> Sorting change has been raised with tittle "[PATCH v1] Bluetooth: qca: >> Refactor code on >> >> the basis of chipset names". Please approve it at quickest so that we can >> raise new model >> >> addition code changes on top of that. > > > Why couldn't you send it as 2 patches in a single series? > this change includes driver change and yaml change. In recent bluetooth-next branch there is a new style of documentation of bindings comes as "Split to separate schema". I need to re-modify my patch again and compile. Splitting patch seems more convenient for code submission and addressing review comments. ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 2/2] Bluetooth: qca: add QCC2072 support 2026-02-10 13:53 ` Vivek Sahu @ 2026-02-11 1:48 ` Dmitry Baryshkov 2026-02-11 6:40 ` Vivek Sahu 0 siblings, 1 reply; 17+ messages in thread From: Dmitry Baryshkov @ 2026-02-11 1:48 UTC (permalink / raw) To: Vivek Sahu Cc: Bartosz Golaszewski, quic_mohamull, quic_hbandi, linux-bluetooth, devicetree, linux-kernel, linux-arm-msm, Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Balakrishna Godavarthi, Rocky Liao On Tue, 10 Feb 2026 at 15:53, Vivek Sahu <vivek.sahu@oss.qualcomm.com> wrote: > > > > On 2/10/2026 5:46 PM, Dmitry Baryshkov wrote: > > On Tue, Feb 10, 2026 at 05:41:13PM +0530, Vivek Sahu wrote: > >> > >> On 2/9/2026 5:04 PM, Bartosz Golaszewski wrote: > >>> On Mon, 9 Feb 2026 09:06:13 +0100, Vivek Sahu > >>> <vivek.sahu@oss.qualcomm.com> said: > >>>> QCC2072 is a family of WiFi/BT connectivity chip. > >>>> It requires different firmware files and has different > >>>> configurations , so add it as a separate SoC type. > >>>> > >>>> Correct the sorting of other chipsets for better readability. > >>>> > >>>> The firmware for these chips has been recently added to the > >>>> linux-firmware repository and will be a part of the upcoming > >>>> release. > >>> Something is wrong with formatting here. > >>> > >>> I would personally split the sorting and support for the new model into two > >>> patches - without and with functional changes respectively - for easier review. > >>> > >>> Bartosz > >> > >> Yes, I'm now splitting this patch into 2 parts, one for sorting another one > >> for new model > >> > >> support. Please ignore this patch. > > > > Please stop adding extra empty lines between (or fix your email client). > > > >> > >> Sorting change has been raised with tittle "[PATCH v1] Bluetooth: qca: > >> Refactor code on > >> > >> the basis of chipset names". Please approve it at quickest so that we can > >> raise new model > >> > >> addition code changes on top of that. > > > > > > Why couldn't you send it as 2 patches in a single series? > > > this change includes driver change and yaml change. In recent > bluetooth-next branch there is a new style of documentation of bindings > comes as "Split to separate schema". I need to re-modify my patch again > and compile. Splitting patch seems more convenient for code submission > and addressing review comments. It makes maintainer's life more complicated as they have to cope with dependencies between patch series. -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 2/2] Bluetooth: qca: add QCC2072 support 2026-02-11 1:48 ` Dmitry Baryshkov @ 2026-02-11 6:40 ` Vivek Sahu 0 siblings, 0 replies; 17+ messages in thread From: Vivek Sahu @ 2026-02-11 6:40 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Bartosz Golaszewski, quic_mohamull, quic_hbandi, linux-bluetooth, devicetree, linux-kernel, linux-arm-msm, Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Balakrishna Godavarthi, Rocky Liao On 2/11/2026 7:18 AM, Dmitry Baryshkov wrote: > On Tue, 10 Feb 2026 at 15:53, Vivek Sahu <vivek.sahu@oss.qualcomm.com> wrote: >> >> >> >> On 2/10/2026 5:46 PM, Dmitry Baryshkov wrote: >>> On Tue, Feb 10, 2026 at 05:41:13PM +0530, Vivek Sahu wrote: >>>> >>>> On 2/9/2026 5:04 PM, Bartosz Golaszewski wrote: >>>>> On Mon, 9 Feb 2026 09:06:13 +0100, Vivek Sahu >>>>> <vivek.sahu@oss.qualcomm.com> said: >>>>>> QCC2072 is a family of WiFi/BT connectivity chip. >>>>>> It requires different firmware files and has different >>>>>> configurations , so add it as a separate SoC type. >>>>>> >>>>>> Correct the sorting of other chipsets for better readability. >>>>>> >>>>>> The firmware for these chips has been recently added to the >>>>>> linux-firmware repository and will be a part of the upcoming >>>>>> release. >>>>> Something is wrong with formatting here. >>>>> >>>>> I would personally split the sorting and support for the new model into two >>>>> patches - without and with functional changes respectively - for easier review. >>>>> >>>>> Bartosz >>>> >>>> Yes, I'm now splitting this patch into 2 parts, one for sorting another one >>>> for new model >>>> >>>> support. Please ignore this patch. >>> >>> Please stop adding extra empty lines between (or fix your email client). >>> >>>> >>>> Sorting change has been raised with tittle "[PATCH v1] Bluetooth: qca: >>>> Refactor code on >>>> >>>> the basis of chipset names". Please approve it at quickest so that we can >>>> raise new model >>>> >>>> addition code changes on top of that. >>> >>> >>> Why couldn't you send it as 2 patches in a single series? >>> >> this change includes driver change and yaml change. In recent >> bluetooth-next branch there is a new style of documentation of bindings >> comes as "Split to separate schema". I need to re-modify my patch again >> and compile. Splitting patch seems more convenient for code submission >> and addressing review comments. > > It makes maintainer's life more complicated as they have to cope with > dependencies between patch series. > I understand, let me see if i could send the patches in single series. ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2026-02-11 19:24 UTC | newest] Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2026-02-09 8:06 [PATCH v3 0/2] Cover letter QCC2072 enablement Vivek Sahu 2026-02-09 8:06 ` [PATCH v3 1/2] dt-bindings: net: bluetooth: qualcomm: add bindings for QCC2072 Vivek Sahu 2026-02-09 8:07 ` Krzysztof Kozlowski 2026-02-09 11:35 ` Bartosz Golaszewski 2026-02-09 15:43 ` Vivek Sahu 2026-02-09 16:08 ` Krzysztof Kozlowski 2026-02-10 12:05 ` Vivek Sahu 2026-02-11 19:23 ` Luiz Augusto von Dentz 2026-02-09 11:32 ` Bartosz Golaszewski 2026-02-09 8:06 ` [PATCH v3 2/2] Bluetooth: qca: add QCC2072 support Vivek Sahu 2026-02-09 11:34 ` Bartosz Golaszewski 2026-02-09 15:45 ` Vivek Sahu 2026-02-10 12:11 ` Vivek Sahu 2026-02-10 12:16 ` Dmitry Baryshkov 2026-02-10 13:53 ` Vivek Sahu 2026-02-11 1:48 ` Dmitry Baryshkov 2026-02-11 6:40 ` Vivek Sahu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®