mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"yilun.xu@linux.intel.com" <yilun.xu@linux.intel.com>,
	"x86@kernel.org" <x86@kernel.org>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"Li, Xiaoyao" <xiaoyao.li@intel.com>,
	"Hansen, Dave" <dave.hansen@intel.com>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
	"Hunter, Adrian" <adrian.hunter@intel.com>,
	"tony.lindgren@linux.intel.com" <tony.lindgren@linux.intel.com>,
	"kas@kernel.org" <kas@kernel.org>,
	"Xu, Yilun" <yilun.xu@intel.com>,
	"artem.bityutskiy@linux.intel.com"
	<artem.bityutskiy@linux.intel.com>,
	"nik.borisov@suse.com" <nik.borisov@suse.com>,
	"Mehta, Sohil" <sohil.mehta@intel.com>,
	"Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
	"Gao, Chao" <chao.gao@intel.com>,
	"Fang, Peter" <peter.fang@intel.com>,
	"Maloor, Kishen" <kishen.maloor@intel.com>
Subject: Re: [PATCH v5 1/6] x86/virt/tdx: Move TDH.SYS.CONFIG operations into a wrapper
Date: Wed, 18 Nov 2026 18:51:30 +0000	[thread overview]
Message-ID: <cbc0c92dba00c04fc538f40795c00f94c53d5bcf.camel@intel.com> (raw)
In-Reply-To: <20261111-tdx-module-ext-v5-1-c74f764abc3d@linux.intel.com>

On Wed, 2026-11-11 at 11:48 +0800, Xu Yilun wrote:
> TDH.SYS.CONFIG is currently not wrapped in a SEAMCALL wrapper because it
> is not exposed to external callers (such as KVM), also because the
> level of TDX ABI details needed to perform the call is low enough to
> flow well with the calling code.
> 
> But as more configurations are being added to this SEAMCALL leaf, more
> ABI details are leaked into the surrounding caller code, which decreases
> the readability of the caller logic. The first case is that the Dynamic
> PAMT (DPAMT) change [1] tweaks the R8 argument based on whether DPAMT is
> supported by the loaded TDX module.
> 
> A follow-up case comes as the TDX architecture has evolved the ABI to
> introduce new leaf versions. The host must select the version to call
> based on what new features are supported by the loaded TDX module.

It is not totally clear to me what a leaf version is here. Like is it a new leaf
or (as it actually is) a new variant of a single leaf.

> 
> Before the version selection makes the caller logic even messier, move
> the register ABI operations into a wrapper.
> 
> The original changelog was written by hand. AI was used to help correct
> grammatical errors and polish individual sentences for better
> readability.

Looks good overall, but weren't we going to drop the AI blurb? Oh oops that was
a comment on a different series:
https://lore.kernel.org/lkml/03cdc774-7fef-4d0b-82f7-126288636f3d@intel.com/

> 
> Signed-off-by: Xu Yilun <yilun.xu@linux.intel.com>
> Link:
> https://lore.kernel.org/all/20260904215841.303070-10-rick.p.edgecombe@intel.com/
>  # [1]
> ---
> v5:
>  - Drop the tdmr_info_pa_array stuff (Dave)
>  - Simplify the changelog (Dave)
>  - Remove all Reviewed-by tags due to code change
>  - Better clarify the AI usage
> 
> v4:
>  - Cut the redundant opening words in the 1st paragraph (Rick)
>  - Collect Reviewed-by tags
> 
> v3:
>  - sizeof(tdmr_pa_array->phys[0]) instead of sizeof(u64) (Rick)
>  - Re-phrase the code comments for struct tdmr_info_pa_array (Tony)
>  - Refactor the changelog
>  - Collect Reviewed-by tags
> 
> v2:
>  - Remove TDH.SYS.UPDATE wrapper (Dave & Rick)
>  - Talk about the handling of in-memory ABIs for SEAMCALL wrappers
>    (Rick)
>  - Refactor the entire changelog according to Rick's suggestion (Rick)
>  - Add code comment for struct tdmr_info_pa_array (AI nitpicker)
>  - Use kernel data type for nr_tdmr_pa parameter (AI nitpicker)
> 
> v1:
>  - This patch is split out from the last series (Rick)
> ---
>  arch/x86/virt/vmx/tdx/tdx.c | 30 +++++++++++++++++++-----------
>  1 file changed, 19 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/x86/virt/vmx/tdx/tdx.c b/arch/x86/virt/vmx/tdx/tdx.c
> index 96ced0494b68..c7bd0b01786d 100644
> --- a/arch/x86/virt/vmx/tdx/tdx.c
> +++ b/arch/x86/virt/vmx/tdx/tdx.c
> @@ -1033,10 +1033,26 @@ static __init int construct_tdmrs(struct list_head
> *tmb_list,
>  
>  #define TDX_SYS_CONFIG_DYNAMIC_PAMT	BIT(16)
>  
> +static __init int tdx_sys_config(u64 *tdmr_pa_array, unsigned int nr_tdmr_pa,
> +				 u64 global_keyid)
> +{
> +	struct tdx_module_args args = {
> +		.rcx = __pa(tdmr_pa_array),
> +		.rdx = nr_tdmr_pa,
> +		.r8 = global_keyid,
> +	};
> +
> +	if (tdx_supports_dynamic_pamt(&tdx_sysinfo)) {
> +		pr_info("Enable Dynamic PAMT\n");
> +		args.r8 |= TDX_SYS_CONFIG_DYNAMIC_PAMT;
> +	}
> +
> +	return seamcall_prerr(TDH_SYS_CONFIG, &args);
> +}
> +
>  static __init int config_tdx_module(struct tdmr_info_list *tdmr_list,
>  				    u64 global_keyid)
>  {
> -	struct tdx_module_args args = {};
>  	u64 *tdmr_pa_array;
>  	size_t array_sz;
>  	int i, ret;
> @@ -1058,16 +1074,8 @@ static __init int config_tdx_module(struct
> tdmr_info_list *tdmr_list,
>  	for (i = 0; i < tdmr_list->nr_consumed_tdmrs; i++)
>  		tdmr_pa_array[i] = __pa(tdmr_entry(tdmr_list, i));
>  
> -	args.rcx = __pa(tdmr_pa_array);
> -	args.rdx = tdmr_list->nr_consumed_tdmrs;
> -	args.r8 = global_keyid;
> -
> -	if (tdx_supports_dynamic_pamt(&tdx_sysinfo)) {
> -		pr_info("Enable Dynamic PAMT\n");
> -		args.r8 |= TDX_SYS_CONFIG_DYNAMIC_PAMT;
> -	}
> -
> -	ret = seamcall_prerr(TDH_SYS_CONFIG, &args);
> +	ret = tdx_sys_config(tdmr_pa_array, tdmr_list->nr_consumed_tdmrs,
> +			     global_keyid);
>  
>  	/* Free the array as it is not required anymore. */
>  	kfree(tdmr_pa_array);
> 


  parent reply	other threads:[~2026-11-18 18:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11  3:48 [PATCH v5 0/6] Enable TDX module extensions Xu Yilun
2026-11-11  3:48 ` [PATCH v5 1/6] x86/virt/tdx: Move TDH.SYS.CONFIG operations into a wrapper Xu Yilun
2026-11-13 15:06   ` Nikolay Borisov
2026-11-18 18:51   ` Edgecombe, Rick P [this message]
2026-11-11  3:48 ` [PATCH v5 2/6] x86/virt/tdx: Configure add-on features on TDX module init Xu Yilun
2026-11-11  3:48 ` [PATCH v5 3/6] x86/virt/tdx: Add extra memory to TDX module for the extensions Xu Yilun
2026-11-17  3:06   ` Alexey Kardashevskiy
2026-11-18  2:32     ` Xu Yilun
2026-11-11  3:48 ` [PATCH v5 4/6] x86/virt/tdx: Support DPAMT when adding memory " Xu Yilun
2026-11-11  3:48 ` [PATCH v5 5/6] x86/virt/tdx: Make TDX module initialize " Xu Yilun
2026-11-13 16:13   ` Nikolay Borisov
2026-11-11  3:48 ` [PATCH v5 6/6] x86/virt/tdx: Re-initialize the extensions on runtime TDX module update Xu Yilun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cbc0c92dba00c04fc538f40795c00f94c53d5bcf.camel@intel.com \
    --to=rick.p.edgecombe@intel.com \
    --cc=adrian.hunter@intel.com \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=chao.gao@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=kas@kernel.org \
    --cc=kishen.maloor@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nik.borisov@suse.com \
    --cc=peter.fang@intel.com \
    --cc=sohil.mehta@intel.com \
    --cc=tony.lindgren@linux.intel.com \
    --cc=x86@kernel.org \
    --cc=xiaoyao.li@intel.com \
    --cc=yilun.xu@intel.com \
    --cc=yilun.xu@linux.intel.com \
    --cc=zhenzhong.duan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®