* [PATCH] x86: fix missing declartion of io_apic_irqs
@ 2024-11-25 12:35 Zhang Kunbo
2024-11-25 20:54 ` Markus Elfring
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Kunbo @ 2024-11-25 12:35 UTC (permalink / raw)
To: tglx, mingo, bp, dave.hansen, x86, hpa
Cc: linux-kernel, liaochang1, chris.zjh
arch/x86/kernel/i8259.c should include arch/x86/include/asm/io_apic.h
for declaration of io_apic_irqs. This fix the sparse warning:
arch/x86/kernel/i8259.c:57:15: warning: symbol 'io_apic_irqs' was not declared. Should it be static?
Signed-off-by: Zhang Kunbo <zhangkunbo@huawei.com>
---
arch/x86/kernel/i8259.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/kernel/i8259.c b/arch/x86/kernel/i8259.c
index c20d1832c481..2bade73f49e3 100644
--- a/arch/x86/kernel/i8259.c
+++ b/arch/x86/kernel/i8259.c
@@ -23,6 +23,7 @@
#include <asm/desc.h>
#include <asm/apic.h>
#include <asm/i8259.h>
+#include <asm/io_apic.h>
/*
* This is the 'legacy' 8259A Programmable Interrupt Controller,
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: fix missing declartion of io_apic_irqs
2024-11-25 12:35 [PATCH] x86: fix missing declartion of io_apic_irqs Zhang Kunbo
@ 2024-11-25 20:54 ` Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2024-11-25 20:54 UTC (permalink / raw)
To: Zhang Kunbo, x86, Borislav Petkov, Dave Hansen, H. Peter Anvin,
Ingo Molnar, Liao Chang, Thomas Gleixner
Cc: LKML, Zhang Jianhua
> arch/x86/kernel/i8259.c should include arch/x86/include/asm/io_apic.h
> for declaration of io_apic_irqs. This fix the sparse warning:
…
Please avoid a typo in the summary phrase accordingly.
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12#n94
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-25 21:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-25 12:35 [PATCH] x86: fix missing declartion of io_apic_irqs Zhang Kunbo
2024-11-25 20:54 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®