mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Li Huafei <lihuafei1@huawei.com>
To: Mark Brown <broonie@kernel.org>
Cc: <linux@armlinux.org.uk>, <rmk+kernel@armlinux.org.uk>,
	<ardb@kernel.org>, <will@kernel.org>, <mark.rutland@arm.com>,
	<peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
	<alexander.shishkin@linux.intel.com>, <jolsa@kernel.org>,
	<namhyung@kernel.org>, <arnd@arndb.de>,
	<linus.walleij@linaro.org>, <rostedt@goodmis.org>,
	<nick.hawkins@hpe.com>, <john@phrozen.org>, <mhiramat@kernel.org>,
	<ast@kernel.org>, <linyujun809@huawei.com>,
	<ndesaulniers@google.com>, <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-perf-users@vger.kernel.org>
Subject: Re: [PATCH 4/5] ARM: stacktrace: Make stack walk callback consistent with generic code
Date: Wed, 13 Jul 2022 19:21:50 +0800	[thread overview]
Message-ID: <cbdd6276-4e5c-e983-6b1a-b43863cce9a9@huawei.com> (raw)
In-Reply-To: <Ys14cMm0n6EqS/cQ@sirena.org.uk>


On 2022/7/12 21:34, Mark Brown wrote:
> On Tue, Jul 12, 2022 at 10:15:26AM +0800, Li Huafei wrote:
>
>> In order to use generic arch_stack_walk() code, make stack walk callback
>> consistent with it.
> It might be useful to say what the changes are here, if nothing else
> that makes it easier to review and confirm that the changes are doing
> what you intend them to.  See my conversion for arm64 for an example.


Thanks for the advice. I've looked at the commit:

   baa2cd417053 ("arm64: stacktrace: Make stack walk callback consistent 
with generic code")

The description is very clear. It describes the change in detail and
gives a reason for making that change a separate commit. The same
description applies to the current changes, so I took the commit message
directly, just made the s/arm64/ARM/ changes, and updated to v2:

https://lore.kernel.org/lkml/20220713110020.85511-1-lihuafei1@huawei.com/


> The actual changes here seem OK though
>
> Reviewed-by: Mark Brown <broonie@kernel.org>

Thanks for the review!


Thanks,

Huafei


  reply	other threads:[~2022-07-13 11:21 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-12  2:15 [PATCH 0/5] ARM: Convert to ARCH_STACKWALK Li Huafei
2022-07-12  2:15 ` [PATCH 1/5] ARM: stacktrace: Skip frame pointer boundary check for call_with_stack() Li Huafei
2022-07-18  8:57   ` Linus Walleij
2022-07-26  8:10     ` Li Huafei
2022-07-12  2:15 ` [PATCH 2/5] ARM: stacktrace: Avoid duplicate saving of exception PC value Li Huafei
2022-07-18  9:01   ` Linus Walleij
2022-07-26  9:10     ` Li Huafei
2022-07-26 10:22   ` Russell King (Oracle)
2022-07-26 12:21     ` Li Huafei
2022-07-12  2:15 ` [PATCH 3/5] ARM: stacktrace: Allow stack trace saving for non-current tasks Li Huafei
2022-07-18  9:07   ` Linus Walleij
2022-07-26  9:12     ` Li Huafei
2022-07-26  9:49       ` Russell King (Oracle)
2022-07-26 12:08         ` Li Huafei
2022-07-12  2:15 ` [PATCH 4/5] ARM: stacktrace: Make stack walk callback consistent with generic code Li Huafei
2022-07-12 13:34   ` Mark Brown
2022-07-13 11:21     ` Li Huafei [this message]
2022-07-18  9:09   ` Linus Walleij
2022-07-26  9:19     ` Li Huafei
2022-07-12  2:15 ` [PATCH 5/5] ARM: stacktrace: Convert stacktrace to generic ARCH_STACKWALK Li Huafei
2022-07-18  9:12   ` Linus Walleij
2022-07-26  9:15     ` Li Huafei
2022-07-27  6:29     ` Li Huafei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cbdd6276-4e5c-e983-6b1a-b43863cce9a9@huawei.com \
    --to=lihuafei1@huawei.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=ast@kernel.org \
    --cc=broonie@kernel.org \
    --cc=john@phrozen.org \
    --cc=jolsa@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=linyujun809@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=nick.hawkins@hpe.com \
    --cc=peterz@infradead.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=rostedt@goodmis.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®