mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Tien ChenLi" <cltien@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH]pktgen oops when used with balance-tlb bonding
Date: Sat, 22 Jul 2006 19:11:21 -0400	[thread overview]
Message-ID: <cc862f80607221611x52efac88u620516e17edfa03b@mail.gmail.com> (raw)

I fixed a bug in pktgen so it won't cause oops when used with
balance-tlb or balance-alb bonding driver:

--- linux-2.6.17.4/net/core/pktgen.c.orig       2006-07-06 16:02:28.000000000 -0
400
+++ linux-2.6.17.4/net/core/pktgen.c    2006-07-10 16:40:47.000000000 -0400
@@ -2149,6 +2149,9 @@
        skb->mac.raw = ((u8 *) iph) - 14 - pkt_dev->nr_labels*sizeof(u32);
        skb->dev = odev;
        skb->pkt_type = PACKET_HOST;
+       skb->mac.raw = eth;
+       skb->nh.iph = iph;
+       skb->h.uh = udph;

        if (pkt_dev->nfrags <= 0)
                pgh = (struct pktgen_hdr *)skb_put(skb, datalen);

The root cause is that the bond_alb_xmit in bonding will peek the
destination address in packet via the skb->nh.iph pointer, generally
this will be filled by upper layer network driver, but the packet
generated by pktgen will be sent to device driver so it will need to
set this pointer correctly. The other two pointers are not necessary
for now, they are set to avoid similar problem.

Chen-Li Tien

             reply	other threads:[~2006-07-22 23:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-22 23:11 Tien ChenLi [this message]
2006-07-24  6:35 ` David Miller
2006-08-02 20:38 ` Willy Tarreau
2006-08-07 19:04   ` Tien ChenLi
2006-08-07 19:07     ` Tien ChenLi
2006-08-08  3:51       ` David Miller
2006-08-08  3:49     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc862f80607221611x52efac88u620516e17edfa03b@mail.gmail.com \
    --to=cltien@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®