mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Tudor.Ambarus@microchip.com>
To: <wanjiabing@vivo.com>, <richard@nod.at>,
	<miquel.raynal@bootlin.com>, <vigneshr@ti.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Cc: <kael_w@yeah.net>
Subject: Re: [PATCH] drivers: mtd: ubi: Remove unnecessary struct declaration
Date: Tue, 6 Apr 2021 07:00:25 +0000	[thread overview]
Message-ID: <ccba7901-676f-e8c5-2085-0f8f9d505754@microchip.com> (raw)
In-Reply-To: <20210406063751.522992-1-wanjiabing@vivo.com>

On 4/6/21 9:37 AM, Wan Jiabing wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> struct ubi_wl_entry is defined at 178th line.
> The declaration here is unnecessary. Remove it.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>

the subject of the patch should start with "ubi:", thus
"ubi: Remove unnecessary struct declaration"

with that:
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>

> ---
>  drivers/mtd/ubi/ubi.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/mtd/ubi/ubi.h b/drivers/mtd/ubi/ubi.h
> index c2da77163f94..7c083ad58274 100644
> --- a/drivers/mtd/ubi/ubi.h
> +++ b/drivers/mtd/ubi/ubi.h
> @@ -388,8 +388,6 @@ struct ubi_volume_desc {
>         int mode;
>  };
> 
> -struct ubi_wl_entry;
> -
>  /**
>   * struct ubi_debug_info - debugging information for an UBI device.
>   *
> --
> 2.25.1
> 
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
> 


      reply	other threads:[~2021-04-06  7:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06  6:37 Wan Jiabing
2021-04-06  7:00 ` Tudor.Ambarus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ccba7901-676f-e8c5-2085-0f8f9d505754@microchip.com \
    --to=tudor.ambarus@microchip.com \
    --cc=kael_w@yeah.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=wanjiabing@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®