mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] drivers: mtd: ubi: Remove unnecessary struct declaration
@ 2021-04-06  6:37 Wan Jiabing
  2021-04-06  7:00 ` Tudor.Ambarus
  0 siblings, 1 reply; 2+ messages in thread
From: Wan Jiabing @ 2021-04-06  6:37 UTC (permalink / raw)
  To: Richard Weinberger, Miquel Raynal, Vignesh Raghavendra,
	linux-mtd, linux-kernel
  Cc: kael_w, Wan Jiabing

struct ubi_wl_entry is defined at 178th line.
The declaration here is unnecessary. Remove it.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/mtd/ubi/ubi.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/mtd/ubi/ubi.h b/drivers/mtd/ubi/ubi.h
index c2da77163f94..7c083ad58274 100644
--- a/drivers/mtd/ubi/ubi.h
+++ b/drivers/mtd/ubi/ubi.h
@@ -388,8 +388,6 @@ struct ubi_volume_desc {
 	int mode;
 };
 
-struct ubi_wl_entry;
-
 /**
  * struct ubi_debug_info - debugging information for an UBI device.
  *
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers: mtd: ubi: Remove unnecessary struct declaration
  2021-04-06  6:37 [PATCH] drivers: mtd: ubi: Remove unnecessary struct declaration Wan Jiabing
@ 2021-04-06  7:00 ` Tudor.Ambarus
  0 siblings, 0 replies; 2+ messages in thread
From: Tudor.Ambarus @ 2021-04-06  7:00 UTC (permalink / raw)
  To: wanjiabing, richard, miquel.raynal, vigneshr, linux-mtd, linux-kernel
  Cc: kael_w

On 4/6/21 9:37 AM, Wan Jiabing wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> struct ubi_wl_entry is defined at 178th line.
> The declaration here is unnecessary. Remove it.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>

the subject of the patch should start with "ubi:", thus
"ubi: Remove unnecessary struct declaration"

with that:
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>

> ---
>  drivers/mtd/ubi/ubi.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/mtd/ubi/ubi.h b/drivers/mtd/ubi/ubi.h
> index c2da77163f94..7c083ad58274 100644
> --- a/drivers/mtd/ubi/ubi.h
> +++ b/drivers/mtd/ubi/ubi.h
> @@ -388,8 +388,6 @@ struct ubi_volume_desc {
>         int mode;
>  };
> 
> -struct ubi_wl_entry;
> -
>  /**
>   * struct ubi_debug_info - debugging information for an UBI device.
>   *
> --
> 2.25.1
> 
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-06  7:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-06  6:37 [PATCH] drivers: mtd: ubi: Remove unnecessary struct declaration Wan Jiabing
2021-04-06  7:00 ` Tudor.Ambarus

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®