* [PATCH] virtio_mmio: remove redundant dev_err message
@ 2019-09-24 7:21 Ding Xiang
2019-09-25 3:49 ` Jason Wang
0 siblings, 1 reply; 2+ messages in thread
From: Ding Xiang @ 2019-09-24 7:21 UTC (permalink / raw)
To: mst, jasowang; +Cc: virtualization, linux-kernel
platform_get_irq already contains error message, so remove
the redundant dev_err message
Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
---
drivers/virtio/virtio_mmio.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
index e09edb5..c4b9f25 100644
--- a/drivers/virtio/virtio_mmio.c
+++ b/drivers/virtio/virtio_mmio.c
@@ -466,10 +466,8 @@ static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs,
int irq = platform_get_irq(vm_dev->pdev, 0);
int i, err, queue_idx = 0;
- if (irq < 0) {
- dev_err(&vdev->dev, "Cannot get IRQ resource\n");
+ if (irq < 0)
return irq;
- }
err = request_irq(irq, vm_interrupt, IRQF_SHARED,
dev_name(&vdev->dev), vm_dev);
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] virtio_mmio: remove redundant dev_err message
2019-09-24 7:21 [PATCH] virtio_mmio: remove redundant dev_err message Ding Xiang
@ 2019-09-25 3:49 ` Jason Wang
0 siblings, 0 replies; 2+ messages in thread
From: Jason Wang @ 2019-09-25 3:49 UTC (permalink / raw)
To: Ding Xiang, mst; +Cc: virtualization, linux-kernel
On 2019/9/24 下午3:21, Ding Xiang wrote:
> platform_get_irq already contains error message,
Is this message contained in all possible error path? If not, it's
probably better to keep it as is.
Thanks
> so remove
> the redundant dev_err message
>
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
> ---
> drivers/virtio/virtio_mmio.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
> index e09edb5..c4b9f25 100644
> --- a/drivers/virtio/virtio_mmio.c
> +++ b/drivers/virtio/virtio_mmio.c
> @@ -466,10 +466,8 @@ static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs,
> int irq = platform_get_irq(vm_dev->pdev, 0);
> int i, err, queue_idx = 0;
>
> - if (irq < 0) {
> - dev_err(&vdev->dev, "Cannot get IRQ resource\n");
> + if (irq < 0)
> return irq;
> - }
>
> err = request_irq(irq, vm_interrupt, IRQF_SHARED,
> dev_name(&vdev->dev), vm_dev);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-25 3:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-24 7:21 [PATCH] virtio_mmio: remove redundant dev_err message Ding Xiang
2019-09-25 3:49 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®