* [PATCH v3 1/4] dt-bindings: remoteproc: qcom,sm6375-pas: Document remoteprocs [not found] <20230109135647.339224-1-konrad.dybcio@linaro.org> @ 2023-01-09 13:56 ` Konrad Dybcio 2023-01-09 17:32 ` Rob Herring 2023-02-14 8:03 ` Krzysztof Kozlowski 2023-01-09 13:56 ` [PATCH v3 2/4] remoteproc: qcom: pas: Add SM6375 ADSP & CDSP Konrad Dybcio ` (2 subsequent siblings) 3 siblings, 2 replies; 7+ messages in thread From: Konrad Dybcio @ 2023-01-09 13:56 UTC (permalink / raw) To: linux-arm-msm, andersson, agross, krzysztof.kozlowski Cc: marijn.suijten, Konrad Dybcio, Mathieu Poirier, Rob Herring, Krzysztof Kozlowski, Manivannan Sadhasivam, linux-remoteproc, devicetree, linux-kernel SM6375 hosts an ADSP, CDSP and modem as remote processors. Create related bindings. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- v2 -> v3: - Separate out 6375 bindings .../bindings/remoteproc/qcom,sm6375-pas.yaml | 137 ++++++++++++++++++ 1 file changed, 137 insertions(+) create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml new file mode 100644 index 000000000000..60ee3fc7ab5b --- /dev/null +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml @@ -0,0 +1,137 @@ +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/remoteproc/qcom,sm6375-pas.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm SM6375 Peripheral Authentication Service + +maintainers: + - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> + +description: + Qualcomm SM6375 SoC Peripheral Authentication Service loads and boots + firmware on the Qualcomm DSP Hexagon cores. + +properties: + compatible: + enum: + - qcom,sm6375-adsp-pas + - qcom,sm6375-cdsp-pas + - qcom,sm6375-mpss-pas + + reg: + maxItems: 1 + + clocks: + items: + - description: XO clock + + clock-names: + items: + - const: xo + + smd-edge: false + +required: + - compatible + - reg + +allOf: + - $ref: /schemas/remoteproc/qcom,pas-common.yaml# + - if: + properties: + compatible: + enum: + - qcom,sm6375-adsp-pas + - qcom,sm6375-cdsp-pas + then: + properties: + interrupts: + maxItems: 5 + interrupt-names: + maxItems: 5 + else: + properties: + interrupts: + minItems: 6 + interrupt-names: + minItems: 6 + + - if: + properties: + compatible: + enum: + - qcom,sm6375-adsp-pas + then: + properties: + power-domains: + items: + - description: LCX power domain + - description: LMX power domain + power-domain-names: + items: + - const: lcx + - const: lmx + + - if: + properties: + compatible: + enum: + - qcom,sm6375-cdsp-pas + - qcom,sm6375-mpss-pas + then: + properties: + power-domains: + items: + - description: CX power domain + power-domain-names: + items: + - const: cx + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/qcom,rpmcc.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/mailbox/qcom-ipcc.h> + #include <dt-bindings/power/qcom-rpmpd.h> + + remoteproc_adsp: remoteproc@a400000 { + compatible = "qcom,sm6375-adsp-pas"; + reg = <0x0a400000 0x100>; + + interrupts-extended = <&intc GIC_SPI 282 IRQ_TYPE_LEVEL_HIGH>, + <&smp2p_adsp_in 0 IRQ_TYPE_EDGE_RISING>, + <&smp2p_adsp_in 1 IRQ_TYPE_EDGE_RISING>, + <&smp2p_adsp_in 2 IRQ_TYPE_EDGE_RISING>, + <&smp2p_adsp_in 3 IRQ_TYPE_EDGE_RISING>; + interrupt-names = "wdog", "fatal", "ready", + "handover", "stop-ack"; + + clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>; + clock-names = "xo"; + + power-domains = <&rpmpd SM6375_VDD_LPI_CX>, + <&rpmpd SM6375_VDD_LPI_MX>; + power-domain-names = "lcx", "lmx"; + + memory-region = <&pil_adsp_mem>; + + qcom,smem-states = <&smp2p_adsp_out 0>; + qcom,smem-state-names = "stop"; + + glink-edge { + interrupts-extended = <&ipcc IPCC_CLIENT_LPASS + IPCC_MPROC_SIGNAL_GLINK_QMP + IRQ_TYPE_EDGE_RISING>; + mboxes = <&ipcc IPCC_CLIENT_LPASS + IPCC_MPROC_SIGNAL_GLINK_QMP>; + + label = "lpass"; + qcom,remote-pid = <2>; + + /* ... */ + }; + }; -- 2.39.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 1/4] dt-bindings: remoteproc: qcom,sm6375-pas: Document remoteprocs 2023-01-09 13:56 ` [PATCH v3 1/4] dt-bindings: remoteproc: qcom,sm6375-pas: Document remoteprocs Konrad Dybcio @ 2023-01-09 17:32 ` Rob Herring 2023-02-13 18:09 ` Konrad Dybcio 2023-02-14 8:03 ` Krzysztof Kozlowski 1 sibling, 1 reply; 7+ messages in thread From: Rob Herring @ 2023-01-09 17:32 UTC (permalink / raw) To: Konrad Dybcio Cc: linux-remoteproc, andersson, Rob Herring, Mathieu Poirier, marijn.suijten, linux-arm-msm, agross, Krzysztof Kozlowski, devicetree, linux-kernel, krzysztof.kozlowski, Manivannan Sadhasivam On Mon, 09 Jan 2023 14:56:44 +0100, Konrad Dybcio wrote: > SM6375 hosts an ADSP, CDSP and modem as remote processors. Create > related bindings. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > v2 -> v3: > - Separate out 6375 bindings > > .../bindings/remoteproc/qcom,sm6375-pas.yaml | 137 ++++++++++++++++++ > 1 file changed, 137 insertions(+) > create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: ./Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/remoteproc/qcom,pas-common.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.example.dtb: remoteproc@a400000: False schema does not allow {'compatible': ['qcom,sm6375-adsp-pas'], 'reg': [[171966464, 256]], 'interrupts-extended': [[4294967295, 0, 282, 4], [4294967295, 0, 1], [4294967295, 1, 1], [4294967295, 2, 1], [4294967295, 3, 1]], 'interrupt-names': ['wdog', 'fatal', 'ready', 'handover', 'stop-ack'], 'clocks': [[4294967295, 0]], 'clock-names': ['xo'], 'power-domains': [[4294967295, 8], [4294967295, 9]], 'power-domain-names': ['lcx', 'lmx'], 'memory-region': [[4294967295]], 'qcom,smem-states': [[4294967295, 0]], 'qcom,smem-state-names': ['stop'], 'glink-edge': {'interrupts-extended': [[4294967295, 3, 0, 1]], 'mboxes': [[4294967295, 3, 0]], 'label': ['lpass'], 'qcom,remote-pid': [[2]]}, '$nodename': ['remoteproc@a400000']} From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.example.dtb: remoteproc@a400000: Unevaluated properties are not allowed ('glink-edge', 'memory-region', 'qcom,smem-state-names', 'qcom,smem-states' were unexpected) From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230109135647.339224-2-konrad.dybcio@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 1/4] dt-bindings: remoteproc: qcom,sm6375-pas: Document remoteprocs 2023-01-09 17:32 ` Rob Herring @ 2023-02-13 18:09 ` Konrad Dybcio 0 siblings, 0 replies; 7+ messages in thread From: Konrad Dybcio @ 2023-02-13 18:09 UTC (permalink / raw) To: Rob Herring Cc: linux-remoteproc, andersson, Rob Herring, Mathieu Poirier, marijn.suijten, linux-arm-msm, agross, Krzysztof Kozlowski, devicetree, linux-kernel, krzysztof.kozlowski, Manivannan Sadhasivam On 9.01.2023 18:32, Rob Herring wrote: > > On Mon, 09 Jan 2023 14:56:44 +0100, Konrad Dybcio wrote: >> SM6375 hosts an ADSP, CDSP and modem as remote processors. Create >> related bindings. >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- Could you take another look, Rob? I think it errored out because of me not having specified a dependency (which is in -next since Nov, but not in -rc), which I should have noted.. Konrad >> v2 -> v3: >> - Separate out 6375 bindings >> >> .../bindings/remoteproc/qcom,sm6375-pas.yaml | 137 ++++++++++++++++++ >> 1 file changed, 137 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > ./Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/remoteproc/qcom,pas-common.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.example.dtb: remoteproc@a400000: False schema does not allow {'compatible': ['qcom,sm6375-adsp-pas'], 'reg': [[171966464, 256]], 'interrupts-extended': [[4294967295, 0, 282, 4], [4294967295, 0, 1], [4294967295, 1, 1], [4294967295, 2, 1], [4294967295, 3, 1]], 'interrupt-names': ['wdog', 'fatal', 'ready', 'handover', 'stop-ack'], 'clocks': [[4294967295, 0]], 'clock-names': ['xo'], 'power-domains': [[4294967295, 8], [4294967295, 9]], 'power-domain-names': ['lcx', 'lmx'], 'memory-region': [[4294967295]], 'qcom,smem-states': [[4294967295, 0]], 'qcom,smem-state-names': ['stop'], 'glink-edge': {'interrupts-extended': [[4294967295, 3, 0, 1]], 'mboxes': [[4294967295, 3, 0]], 'label': ['lpass'], 'qcom,remote-pid': [[2]]}, '$nodename': ['remoteproc@a400000']} > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.example.dtb: remoteproc@a400000: Unevaluated properties are not allowed ('glink-edge', 'memory-region', 'qcom,smem-state-names', 'qcom,smem-states' were unexpected) > From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/qcom,sm6375-pas.yaml > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230109135647.339224-2-konrad.dybcio@linaro.org > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 1/4] dt-bindings: remoteproc: qcom,sm6375-pas: Document remoteprocs 2023-01-09 13:56 ` [PATCH v3 1/4] dt-bindings: remoteproc: qcom,sm6375-pas: Document remoteprocs Konrad Dybcio 2023-01-09 17:32 ` Rob Herring @ 2023-02-14 8:03 ` Krzysztof Kozlowski 1 sibling, 0 replies; 7+ messages in thread From: Krzysztof Kozlowski @ 2023-02-14 8:03 UTC (permalink / raw) To: Konrad Dybcio, linux-arm-msm, andersson, agross Cc: marijn.suijten, Mathieu Poirier, Rob Herring, Krzysztof Kozlowski, Manivannan Sadhasivam, linux-remoteproc, devicetree, linux-kernel On 09/01/2023 14:56, Konrad Dybcio wrote: > SM6375 hosts an ADSP, CDSP and modem as remote processors. Create > related bindings. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3 2/4] remoteproc: qcom: pas: Add SM6375 ADSP & CDSP [not found] <20230109135647.339224-1-konrad.dybcio@linaro.org> 2023-01-09 13:56 ` [PATCH v3 1/4] dt-bindings: remoteproc: qcom,sm6375-pas: Document remoteprocs Konrad Dybcio @ 2023-01-09 13:56 ` Konrad Dybcio 2023-01-09 13:56 ` [PATCH v3 3/4] remoteproc: qcom: pas: Add SM6375 MPSS Konrad Dybcio 2023-01-09 13:56 ` [PATCH v3 4/4] arm64: dts: qcom: sm6375: Add missing power-domain-named to CDSP Konrad Dybcio 3 siblings, 0 replies; 7+ messages in thread From: Konrad Dybcio @ 2023-01-09 13:56 UTC (permalink / raw) To: linux-arm-msm, andersson, agross, krzysztof.kozlowski Cc: marijn.suijten, Konrad Dybcio, Mathieu Poirier, linux-remoteproc, linux-kernel Add a config for the ADSP&CDSP present on SM6375. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- v2 -> v3: No changes drivers/remoteproc/qcom_q6v5_pas.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c index f95e0229a6c1..d8a4ecec8535 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -948,6 +948,8 @@ static const struct of_device_id adsp_of_match[] = { { .compatible = "qcom,sm6350-adsp-pas", .data = &sm6350_adsp_resource}, { .compatible = "qcom,sm6350-cdsp-pas", .data = &sm6350_cdsp_resource}, { .compatible = "qcom,sm6350-mpss-pas", .data = &mpss_resource_init}, + { .compatible = "qcom,sm6375-adsp-pas", .data = &sm6350_adsp_resource}, + { .compatible = "qcom,sm6375-cdsp-pas", .data = &sm8150_cdsp_resource}, { .compatible = "qcom,sm8150-adsp-pas", .data = &sm8150_adsp_resource}, { .compatible = "qcom,sm8150-cdsp-pas", .data = &sm8150_cdsp_resource}, { .compatible = "qcom,sm8150-mpss-pas", .data = &mpss_resource_init}, -- 2.39.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3 3/4] remoteproc: qcom: pas: Add SM6375 MPSS [not found] <20230109135647.339224-1-konrad.dybcio@linaro.org> 2023-01-09 13:56 ` [PATCH v3 1/4] dt-bindings: remoteproc: qcom,sm6375-pas: Document remoteprocs Konrad Dybcio 2023-01-09 13:56 ` [PATCH v3 2/4] remoteproc: qcom: pas: Add SM6375 ADSP & CDSP Konrad Dybcio @ 2023-01-09 13:56 ` Konrad Dybcio 2023-01-09 13:56 ` [PATCH v3 4/4] arm64: dts: qcom: sm6375: Add missing power-domain-named to CDSP Konrad Dybcio 3 siblings, 0 replies; 7+ messages in thread From: Konrad Dybcio @ 2023-01-09 13:56 UTC (permalink / raw) To: linux-arm-msm, andersson, agross, krzysztof.kozlowski Cc: marijn.suijten, Konrad Dybcio, Mathieu Poirier, linux-remoteproc, linux-kernel Add a config for the MPSS present on SM6375. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- v2 -> v3: No changes drivers/remoteproc/qcom_q6v5_pas.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c index d8a4ecec8535..10eaef85816d 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -831,6 +831,21 @@ static const struct adsp_data slpi_resource_init = { .ssctl_id = 0x16, }; +static const struct adsp_data sm6375_mpss_resource = { + .crash_reason_smem = 421, + .firmware_name = "modem.mdt", + .pas_id = 4, + .minidump_id = 3, + .auto_boot = false, + .proxy_pd_names = (char*[]){ + "cx", + NULL + }, + .ssr_name = "mpss", + .sysmon_name = "modem", + .ssctl_id = 0x12, +}; + static const struct adsp_data sm8150_slpi_resource = { .crash_reason_smem = 424, .firmware_name = "slpi.mdt", @@ -950,6 +965,7 @@ static const struct of_device_id adsp_of_match[] = { { .compatible = "qcom,sm6350-mpss-pas", .data = &mpss_resource_init}, { .compatible = "qcom,sm6375-adsp-pas", .data = &sm6350_adsp_resource}, { .compatible = "qcom,sm6375-cdsp-pas", .data = &sm8150_cdsp_resource}, + { .compatible = "qcom,sm6375-mpss-pas", .data = &sm6375_mpss_resource}, { .compatible = "qcom,sm8150-adsp-pas", .data = &sm8150_adsp_resource}, { .compatible = "qcom,sm8150-cdsp-pas", .data = &sm8150_cdsp_resource}, { .compatible = "qcom,sm8150-mpss-pas", .data = &mpss_resource_init}, -- 2.39.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3 4/4] arm64: dts: qcom: sm6375: Add missing power-domain-named to CDSP [not found] <20230109135647.339224-1-konrad.dybcio@linaro.org> ` (2 preceding siblings ...) 2023-01-09 13:56 ` [PATCH v3 3/4] remoteproc: qcom: pas: Add SM6375 MPSS Konrad Dybcio @ 2023-01-09 13:56 ` Konrad Dybcio 3 siblings, 0 replies; 7+ messages in thread From: Konrad Dybcio @ 2023-01-09 13:56 UTC (permalink / raw) To: linux-arm-msm, andersson, agross, krzysztof.kozlowski Cc: marijn.suijten, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, devicetree, linux-kernel This was omitted when first introducing the node. Fix it. Fixes: fe6fd26aeddf ("arm64: dts: qcom: sm6375: Add ADSP&CDSP") Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- v2 -> v3: New patch arch/arm64/boot/dts/qcom/sm6375.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sm6375.dtsi b/arch/arm64/boot/dts/qcom/sm6375.dtsi index 4f00307b30e8..bf5114468ba5 100644 --- a/arch/arm64/boot/dts/qcom/sm6375.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6375.dtsi @@ -1873,6 +1873,7 @@ remoteproc_cdsp: remoteproc@b000000 { clock-names = "xo"; power-domains = <&rpmpd SM6375_VDDCX>; + power-domain-names = "cx"; memory-region = <&pil_cdsp_mem>; -- 2.39.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-02-14 8:04 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230109135647.339224-1-konrad.dybcio@linaro.org>
2023-01-09 13:56 ` [PATCH v3 1/4] dt-bindings: remoteproc: qcom,sm6375-pas: Document remoteprocs Konrad Dybcio
2023-01-09 17:32 ` Rob Herring
2023-02-13 18:09 ` Konrad Dybcio
2023-02-14 8:03 ` Krzysztof Kozlowski
2023-01-09 13:56 ` [PATCH v3 2/4] remoteproc: qcom: pas: Add SM6375 ADSP & CDSP Konrad Dybcio
2023-01-09 13:56 ` [PATCH v3 3/4] remoteproc: qcom: pas: Add SM6375 MPSS Konrad Dybcio
2023-01-09 13:56 ` [PATCH v3 4/4] arm64: dts: qcom: sm6375: Add missing power-domain-named to CDSP Konrad Dybcio
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®