* Re: [PATCH] drm/imagination: Optionally depend on POWER_SEQUENCING
2025-10-14 11:57 [PATCH] drm/imagination: Optionally depend on POWER_SEQUENCING Matt Coster
@ 2025-11-03 10:14 ` Alessio Belle
2025-11-03 10:35 ` Matt Coster
2025-11-03 13:30 ` Matt Coster
2 siblings, 0 replies; 4+ messages in thread
From: Alessio Belle @ 2025-11-03 10:14 UTC (permalink / raw)
To: Matt Coster
Cc: lkp, airlied, tzimmermann, simona, m.wilczynski, dri-devel,
ulf.hansson, linux-kernel, Frank Binns, maarten.lankhorst,
stable, Alexandru Dadu, mripard
On Tue, 2025-10-14 at 12:57 +0100, Matt Coster wrote:
> When the change using pwrseq was added, I nixed the dependency on
> POWER_SEQUENCING since we didn't want it pulled in on platforms where
> it's not needed [1]. I hadn't, however, considered the link-time
> implications of this for configs with POWER_SEQUENCING=m.
>
> [1]: https://lore.kernel.org/r/a265a20e-8908-40d8-b4e0-2c8b8f773742@imgtec.com/
>
> Fixes: e38e8391f30b ("drm/imagination: Use pwrseq for TH1520 GPU power management")
> Cc: stable@vger.kernel.org
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202510111806.CMulNMKW-lkp@intel.com/
> Signed-off-by: Matt Coster <matt.coster@imgtec.com>
Reviewed-by: Alessio Belle <alessio.belle@imgtec.com>
Thanks,
Alessio
> ---
> drivers/gpu/drm/imagination/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/imagination/Kconfig b/drivers/gpu/drm/imagination/Kconfig
> index 3bfa2ac212dc..7e7ffb9c2257 100644
> --- a/drivers/gpu/drm/imagination/Kconfig
> +++ b/drivers/gpu/drm/imagination/Kconfig
> @@ -6,6 +6,7 @@ config DRM_POWERVR
> depends on ARM64
> depends on DRM
> depends on PM
> + depends on POWER_SEQUENCING || !POWER_SEQUENCING
> select DRM_EXEC
> select DRM_GEM_SHMEM_HELPER
> select DRM_SCHED
>
> ---
> base-commit: db74b04edce1bc86b9a5acc724c7ca06f427ab60
> change-id: 20251013-pwrseq-dep-0c158ad8029c
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/imagination: Optionally depend on POWER_SEQUENCING
2025-10-14 11:57 [PATCH] drm/imagination: Optionally depend on POWER_SEQUENCING Matt Coster
2025-11-03 10:14 ` Alessio Belle
@ 2025-11-03 10:35 ` Matt Coster
2025-11-03 13:30 ` Matt Coster
2 siblings, 0 replies; 4+ messages in thread
From: Matt Coster @ 2025-11-03 10:35 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Michal Wilczynski, Ulf Hansson
Cc: Frank Binns, Alessio Belle, Alexandru Dadu, Marek Vasut,
dri-devel, linux-kernel, stable, kernel test robot
[-- Attachment #1.1: Type: text/plain, Size: 1664 bytes --]
On 14/10/2025 12:57, Matt Coster wrote:
> When the change using pwrseq was added, I nixed the dependency on
> POWER_SEQUENCING since we didn't want it pulled in on platforms where
> it's not needed [1]. I hadn't, however, considered the link-time
> implications of this for configs with POWER_SEQUENCING=m.
>
> [1]: https://lore.kernel.org/r/a265a20e-8908-40d8-b4e0-2c8b8f773742@imgtec.com/
>
> Fixes: e38e8391f30b ("drm/imagination: Use pwrseq for TH1520 GPU power management")
> Cc: stable@vger.kernel.org
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202510111806.CMulNMKW-lkp@intel.com/
There's been another automated report of the same bug since this patch
went out, so adding:
Closes: https://lore.kernel.org/oe-kbuild-all/202511011739.SONHjSfR-lkp@intel.com/
Cheers,
Matt
> Signed-off-by: Matt Coster <matt.coster@imgtec.com>
> ---
> drivers/gpu/drm/imagination/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/imagination/Kconfig b/drivers/gpu/drm/imagination/Kconfig
> index 3bfa2ac212dc..7e7ffb9c2257 100644
> --- a/drivers/gpu/drm/imagination/Kconfig
> +++ b/drivers/gpu/drm/imagination/Kconfig
> @@ -6,6 +6,7 @@ config DRM_POWERVR
> depends on ARM64
> depends on DRM
> depends on PM
> + depends on POWER_SEQUENCING || !POWER_SEQUENCING
> select DRM_EXEC
> select DRM_GEM_SHMEM_HELPER
> select DRM_SCHED
>
> ---
> base-commit: db74b04edce1bc86b9a5acc724c7ca06f427ab60
> change-id: 20251013-pwrseq-dep-0c158ad8029c
>
--
Matt Coster
E: matt.coster@imgtec.com
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/imagination: Optionally depend on POWER_SEQUENCING
2025-10-14 11:57 [PATCH] drm/imagination: Optionally depend on POWER_SEQUENCING Matt Coster
2025-11-03 10:14 ` Alessio Belle
2025-11-03 10:35 ` Matt Coster
@ 2025-11-03 13:30 ` Matt Coster
2 siblings, 0 replies; 4+ messages in thread
From: Matt Coster @ 2025-11-03 13:30 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, Michal Wilczynski, Ulf Hansson,
Matt Coster
Cc: Frank Binns, Alessio Belle, Alexandru Dadu, dri-devel,
linux-kernel, stable, kernel test robot
On Tue, 14 Oct 2025 12:57:31 +0100, Matt Coster wrote:
> When the change using pwrseq was added, I nixed the dependency on
> POWER_SEQUENCING since we didn't want it pulled in on platforms where
> it's not needed [1]. I hadn't, however, considered the link-time
> implications of this for configs with POWER_SEQUENCING=m.
>
> [1]: https://lore.kernel.org/r/a265a20e-8908-40d8-b4e0-2c8b8f773742@imgtec.com/
>
> [...]
Applied, thanks!
[1/1] drm/imagination: Optionally depend on POWER_SEQUENCING
(no commit info)
Best regards,
--
Matt Coster <matt.coster@imgtec.com>
^ permalink raw reply [flat|nested] 4+ messages in thread