From: neil.armstrong@linaro.org
To: Jinjie Ruan <ruanjinjie@huawei.com>,
quic_jesszhan@quicinc.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
daniel@ffwll.ch, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next 6/8] drm/panel: khadas-ts050: Make ts050_panel_data and ts050v2_panel_data static
Date: Mon, 19 Aug 2024 17:34:32 +0200 [thread overview]
Message-ID: <cd53b240-0db6-4d27-85d6-e2004086fd29@linaro.org> (raw)
In-Reply-To: <20240819120043.3884933-1-ruanjinjie@huawei.com>
On 19/08/2024 14:00, Jinjie Ruan wrote:
> The sparse tool complains as follows:
>
> drivers/gpu/drm/panel/panel-khadas-ts050.c:620:32: warning:
> symbol 'ts050_panel_data' was not declared. Should it be static?
>
> drivers/gpu/drm/panel/panel-khadas-ts050.c:625:32: warning:
> symbol 'ts050v2_panel_data' was not declared. Should it be static?
>
> These symbols are not used outside panel-khadas-ts050.c, so marks them static.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
> drivers/gpu/drm/panel/panel-khadas-ts050.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-khadas-ts050.c b/drivers/gpu/drm/panel/panel-khadas-ts050.c
> index 14932cb3defc..0e5e8e57bd1e 100644
> --- a/drivers/gpu/drm/panel/panel-khadas-ts050.c
> +++ b/drivers/gpu/drm/panel/panel-khadas-ts050.c
> @@ -617,12 +617,12 @@ static const struct khadas_ts050_panel_cmd ts050_init_code[] = {
> {0xd4, {0x04}, 0x01}, /* RGBMIPICTRL: VSYNC front porch = 4 */
> };
>
> -struct khadas_ts050_panel_data ts050_panel_data = {
> +static struct khadas_ts050_panel_data ts050_panel_data = {
> .init_code = (struct khadas_ts050_panel_cmd *)ts050_init_code,
> .len = ARRAY_SIZE(ts050_init_code)
> };
>
> -struct khadas_ts050_panel_data ts050v2_panel_data = {
> +static struct khadas_ts050_panel_data ts050v2_panel_data = {
> .init_code = (struct khadas_ts050_panel_cmd *)ts050v2_init_code,
> .len = ARRAY_SIZE(ts050v2_init_code)
> };
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
prev parent reply other threads:[~2024-08-19 15:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 12:00 Jinjie Ruan
2024-08-19 15:34 ` neil.armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd53b240-0db6-4d27-85d6-e2004086fd29@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=quic_jesszhan@quicinc.com \
--cc=ruanjinjie@huawei.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®