* [PATCH -next 6/8] drm/panel: khadas-ts050: Make ts050_panel_data and ts050v2_panel_data static
@ 2024-08-19 12:00 Jinjie Ruan
2024-08-19 15:34 ` neil.armstrong
0 siblings, 1 reply; 2+ messages in thread
From: Jinjie Ruan @ 2024-08-19 12:00 UTC (permalink / raw)
To: neil.armstrong, quic_jesszhan, maarten.lankhorst, mripard,
tzimmermann, airlied, daniel, dri-devel, linux-kernel
Cc: ruanjinjie
The sparse tool complains as follows:
drivers/gpu/drm/panel/panel-khadas-ts050.c:620:32: warning:
symbol 'ts050_panel_data' was not declared. Should it be static?
drivers/gpu/drm/panel/panel-khadas-ts050.c:625:32: warning:
symbol 'ts050v2_panel_data' was not declared. Should it be static?
These symbols are not used outside panel-khadas-ts050.c, so marks them static.
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
drivers/gpu/drm/panel/panel-khadas-ts050.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-khadas-ts050.c b/drivers/gpu/drm/panel/panel-khadas-ts050.c
index 14932cb3defc..0e5e8e57bd1e 100644
--- a/drivers/gpu/drm/panel/panel-khadas-ts050.c
+++ b/drivers/gpu/drm/panel/panel-khadas-ts050.c
@@ -617,12 +617,12 @@ static const struct khadas_ts050_panel_cmd ts050_init_code[] = {
{0xd4, {0x04}, 0x01}, /* RGBMIPICTRL: VSYNC front porch = 4 */
};
-struct khadas_ts050_panel_data ts050_panel_data = {
+static struct khadas_ts050_panel_data ts050_panel_data = {
.init_code = (struct khadas_ts050_panel_cmd *)ts050_init_code,
.len = ARRAY_SIZE(ts050_init_code)
};
-struct khadas_ts050_panel_data ts050v2_panel_data = {
+static struct khadas_ts050_panel_data ts050v2_panel_data = {
.init_code = (struct khadas_ts050_panel_cmd *)ts050v2_init_code,
.len = ARRAY_SIZE(ts050v2_init_code)
};
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH -next 6/8] drm/panel: khadas-ts050: Make ts050_panel_data and ts050v2_panel_data static
2024-08-19 12:00 [PATCH -next 6/8] drm/panel: khadas-ts050: Make ts050_panel_data and ts050v2_panel_data static Jinjie Ruan
@ 2024-08-19 15:34 ` neil.armstrong
0 siblings, 0 replies; 2+ messages in thread
From: neil.armstrong @ 2024-08-19 15:34 UTC (permalink / raw)
To: Jinjie Ruan, quic_jesszhan, maarten.lankhorst, mripard,
tzimmermann, airlied, daniel, dri-devel, linux-kernel
On 19/08/2024 14:00, Jinjie Ruan wrote:
> The sparse tool complains as follows:
>
> drivers/gpu/drm/panel/panel-khadas-ts050.c:620:32: warning:
> symbol 'ts050_panel_data' was not declared. Should it be static?
>
> drivers/gpu/drm/panel/panel-khadas-ts050.c:625:32: warning:
> symbol 'ts050v2_panel_data' was not declared. Should it be static?
>
> These symbols are not used outside panel-khadas-ts050.c, so marks them static.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
> drivers/gpu/drm/panel/panel-khadas-ts050.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-khadas-ts050.c b/drivers/gpu/drm/panel/panel-khadas-ts050.c
> index 14932cb3defc..0e5e8e57bd1e 100644
> --- a/drivers/gpu/drm/panel/panel-khadas-ts050.c
> +++ b/drivers/gpu/drm/panel/panel-khadas-ts050.c
> @@ -617,12 +617,12 @@ static const struct khadas_ts050_panel_cmd ts050_init_code[] = {
> {0xd4, {0x04}, 0x01}, /* RGBMIPICTRL: VSYNC front porch = 4 */
> };
>
> -struct khadas_ts050_panel_data ts050_panel_data = {
> +static struct khadas_ts050_panel_data ts050_panel_data = {
> .init_code = (struct khadas_ts050_panel_cmd *)ts050_init_code,
> .len = ARRAY_SIZE(ts050_init_code)
> };
>
> -struct khadas_ts050_panel_data ts050v2_panel_data = {
> +static struct khadas_ts050_panel_data ts050v2_panel_data = {
> .init_code = (struct khadas_ts050_panel_cmd *)ts050v2_init_code,
> .len = ARRAY_SIZE(ts050v2_init_code)
> };
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-19 15:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-19 12:00 [PATCH -next 6/8] drm/panel: khadas-ts050: Make ts050_panel_data and ts050v2_panel_data static Jinjie Ruan
2024-08-19 15:34 ` neil.armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®