From: "Colin King (gmail)" <colin.i.king@gmail.com>
To: Kevin Tang <kevin3.tang@gmail.com>
Cc: Kevin Tang <kevin.tang@unisoc.com>,
Orson Zhai <orsonzhai@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: shift and mask issue in drivers/gpu/drm/sprd/megacores_pll.c
Date: Mon, 7 Oct 2024 10:46:50 +0100 [thread overview]
Message-ID: <cd76a15e-70e9-4abf-9932-38d520b66205@gmail.com> (raw)
Hi,
I noticed a shift/mask issue in dphy_set_pll_reg() in
drivers/gpu/drm/sprd/megacores_pll.c, the expression (pll->kint << 4) &
0xf is
always zero:
...
reg_val[4] = pll->kint >> 12;
reg_val[5] = pll->kint >> 4;
reg_val[6] = pll->out_sel | ((pll->kint << 4) & 0xf);
...
I'm not sure what the correct expression should be, but the current
assignment to reg_val[6] seems incorrect to me.
Colin
reply other threads:[~2024-10-07 9:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd76a15e-70e9-4abf-9932-38d520b66205@gmail.com \
--to=colin.i.king@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kevin.tang@unisoc.com \
--cc=kevin3.tang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=orsonzhai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®