* [PATCH] drm/bridge: select DRM_KMS_HELPER for AUX_BRIDGE
@ 2025-04-11 15:09 Dmitry Baryshkov
2025-04-14 7:38 ` Neil Armstrong
2025-04-16 23:11 ` Dmitry Baryshkov
0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2025-04-11 15:09 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, linux-kernel
The aux bridge uses devm_drm_of_get_bridge() from the panel bridge (and
correctly selects DRM_PANEL_BRIDGE). However panel bridge is not a
separate module, it is compiled into the drm_kms_helper.o. Select
DRM_KMS_HELPER too to express this dependency.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
drivers/gpu/drm/bridge/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 09a1be234f7173bdf88e385507bbe5e5c6d583a6..b9e0ca85226a603a24f90c6879d1499f824060cb 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -16,6 +16,7 @@ config DRM_AUX_BRIDGE
tristate
depends on DRM_BRIDGE && OF
select AUXILIARY_BUS
+ select DRM_KMS_HELPER
select DRM_PANEL_BRIDGE
help
Simple transparent bridge that is used by several non-DRM drivers to
---
base-commit: 2bdde620f7f2bff2ff1cb7dc166859eaa0c78a7c
change-id: 20250411-aux-select-kms-086618b92d6e
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: select DRM_KMS_HELPER for AUX_BRIDGE
2025-04-11 15:09 [PATCH] drm/bridge: select DRM_KMS_HELPER for AUX_BRIDGE Dmitry Baryshkov
@ 2025-04-14 7:38 ` Neil Armstrong
2025-04-16 23:11 ` Dmitry Baryshkov
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2025-04-14 7:38 UTC (permalink / raw)
To: Dmitry Baryshkov, Andrzej Hajda, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, linux-kernel
On 11/04/2025 17:09, Dmitry Baryshkov wrote:
> The aux bridge uses devm_drm_of_get_bridge() from the panel bridge (and
> correctly selects DRM_PANEL_BRIDGE). However panel bridge is not a
> separate module, it is compiled into the drm_kms_helper.o. Select
> DRM_KMS_HELPER too to express this dependency.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
> drivers/gpu/drm/bridge/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 09a1be234f7173bdf88e385507bbe5e5c6d583a6..b9e0ca85226a603a24f90c6879d1499f824060cb 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -16,6 +16,7 @@ config DRM_AUX_BRIDGE
> tristate
> depends on DRM_BRIDGE && OF
> select AUXILIARY_BUS
> + select DRM_KMS_HELPER
> select DRM_PANEL_BRIDGE
> help
> Simple transparent bridge that is used by several non-DRM drivers to
>
> ---
> base-commit: 2bdde620f7f2bff2ff1cb7dc166859eaa0c78a7c
> change-id: 20250411-aux-select-kms-086618b92d6e
>
> Best regards,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: select DRM_KMS_HELPER for AUX_BRIDGE
2025-04-11 15:09 [PATCH] drm/bridge: select DRM_KMS_HELPER for AUX_BRIDGE Dmitry Baryshkov
2025-04-14 7:38 ` Neil Armstrong
@ 2025-04-16 23:11 ` Dmitry Baryshkov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2025-04-16 23:11 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Dmitry Baryshkov
Cc: dri-devel, linux-kernel
On Fri, 11 Apr 2025 18:09:40 +0300, Dmitry Baryshkov wrote:
> The aux bridge uses devm_drm_of_get_bridge() from the panel bridge (and
> correctly selects DRM_PANEL_BRIDGE). However panel bridge is not a
> separate module, it is compiled into the drm_kms_helper.o. Select
> DRM_KMS_HELPER too to express this dependency.
>
>
Applied to drm-misc-next, thanks!
[1/1] drm/bridge: select DRM_KMS_HELPER for AUX_BRIDGE
commit: b12fa5e76e1463fc5a196f2717040e4564e184b6
Best regards,
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-16 23:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-11 15:09 [PATCH] drm/bridge: select DRM_KMS_HELPER for AUX_BRIDGE Dmitry Baryshkov
2025-04-14 7:38 ` Neil Armstrong
2025-04-16 23:11 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®