* [PATCH v1] video: fbdev: sm712fb: fix an issue about iounmap for a wrong address @ 2020-04-22 16:07 ` Dejin Zheng 2020-06-01 13:25 ` Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 2+ messages in thread From: Dejin Zheng @ 2020-04-22 16:07 UTC (permalink / raw) To: sudipm.mukherjee, teddy.wang, b.zolnierkie, gregkh, linux-fbdev, dri-devel Cc: linux-kernel, Dejin Zheng, Andy Shevchenko the sfb->fb->screen_base is not save the value get by iounmap() when the chip id is 0x720. so iounmap() for address sfb->fb->screen_base is not right. Fixes: 1461d6672864854 ("staging: sm7xxfb: merge sm712fb with fbdev") CC: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com> --- drivers/video/fbdev/sm712fb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/sm712fb.c b/drivers/video/fbdev/sm712fb.c index 6a1b4a853d9e..8cd655d6d628 100644 --- a/drivers/video/fbdev/sm712fb.c +++ b/drivers/video/fbdev/sm712fb.c @@ -1429,6 +1429,8 @@ static int smtc_map_smem(struct smtcfb_info *sfb, static void smtc_unmap_smem(struct smtcfb_info *sfb) { if (sfb && sfb->fb->screen_base) { + if (sfb->chip_id == 0x720) + sfb->fb->screen_base -= 0x00200000; iounmap(sfb->fb->screen_base); sfb->fb->screen_base = NULL; } -- 2.25.0 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1] video: fbdev: sm712fb: fix an issue about iounmap for a wrong address 2020-04-22 16:07 ` [PATCH v1] video: fbdev: sm712fb: fix an issue about iounmap for a wrong address Dejin Zheng @ 2020-06-01 13:25 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 2+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2020-06-01 13:25 UTC (permalink / raw) To: Dejin Zheng Cc: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, dri-devel, linux-kernel, Andy Shevchenko On 4/22/20 6:07 PM, Dejin Zheng wrote: > the sfb->fb->screen_base is not save the value get by iounmap() when > the chip id is 0x720. so iounmap() for address sfb->fb->screen_base > is not right. > > Fixes: 1461d6672864854 ("staging: sm7xxfb: merge sm712fb with fbdev") > CC: Andy Shevchenko <andy.shevchenko@gmail.com> > Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com> Applied to drm-misc-next tree (patch should show up in v5.9), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/video/fbdev/sm712fb.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/video/fbdev/sm712fb.c b/drivers/video/fbdev/sm712fb.c > index 6a1b4a853d9e..8cd655d6d628 100644 > --- a/drivers/video/fbdev/sm712fb.c > +++ b/drivers/video/fbdev/sm712fb.c > @@ -1429,6 +1429,8 @@ static int smtc_map_smem(struct smtcfb_info *sfb, > static void smtc_unmap_smem(struct smtcfb_info *sfb) > { > if (sfb && sfb->fb->screen_base) { > + if (sfb->chip_id == 0x720) > + sfb->fb->screen_base -= 0x00200000; > iounmap(sfb->fb->screen_base); > sfb->fb->screen_base = NULL; > } > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-01 13:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20200422160730eucas1p179849adadf1cb41dfe54d7e5f8b61c8e@eucas1p1.samsung.com>
2020-04-22 16:07 ` [PATCH v1] video: fbdev: sm712fb: fix an issue about iounmap for a wrong address Dejin Zheng
2020-06-01 13:25 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®