Re: [PATCH v3 0/3] media: qcom: camss: Add sa8775p camss TPG support

[Wenmeng Liu <quic_wenmliu@qualcomm.com>]

On 8/22/2025 8:09 PM, Wenmeng Liu wrote:
> SA8775P is a Qualcomm SoC. This series adds driver changes to
> bring up the TPG interfaces in SA8775P.
> 
> We have tested this on qcs9100-ride board with 'Test Pattern Generator'.
> Unlike CSID TPG, this TPG can be seen as a combination of CSIPHY and sensor.
> 
> Tested with following commands:
> - media-ctl --reset
> - media-ctl -V '"msm_tpg0":0[fmt:SRGGB10/4608x2592 field:none]'
> - media-ctl -V '"msm_csid0":0[fmt:SRGGB10/4608x2592 field:none]'
> - media-ctl -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/4608x2592 field:none]'
> - media-ctl -l '"msm_tpg0":1->"msm_csid0":0[1]'
> - media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]'
> - v4l2-ctl -d /dev/v4l-subdev4 -c test_pattern=9
> - yavta -B capture-mplane -n 5 -f SRGGB10P -s 4608x2592 /dev/video0
>    --capture=7
> 
> Dependencies:
> https://lore.kernel.org/all/20250814101615.1102795-10-quic_vikramsa@quicinc.com/
> https://lore.kernel.org/all/20250813053724.232494-1-quic_vikramsa@quicinc.com/
> 
> changes in v3:
> - Change the payload mode string
> - Change the method for setting the TPG clock rate
> - Remove the TPG IRQ
> - Format correction
> - Remove unused variables
> - Merge functions and eliminate redundancy
> - Modify the register write method
> - Change TPG matching method to use grp_id
> - Encapsulate magic numbers as macros
> - Link to v2: https://lore.kernel.org/all/20250717-lemans_tpg-v2-0-a2538659349c@quicinc.com/
> 
> Changes in v2:
> - rebase tpg changes based on new versions of sa8775p and qcs8300 camss patches
> - Link to v1: https://lore.kernel.org/all/20250211-sa8775p_tpg-v1-0-3f76c5f8431f@quicinc.com/
> 
> ---
> Wenmeng Liu (3):
>        media: qcom: camss: Add support for TPG common
>        media: qcom: camss: Add link support for TPG common
>        media: qcom: camss: tpg: Add TPG support for SA8775P and QCS8300
> 
>   drivers/media/platform/qcom/camss/Makefile         |   2 +
>   .../media/platform/qcom/camss/camss-csid-gen3.c    |  17 +
>   drivers/media/platform/qcom/camss/camss-csid.c     |  43 +-
>   drivers/media/platform/qcom/camss/camss-csiphy.c   |   1 +
>   drivers/media/platform/qcom/camss/camss-csiphy.h   |   2 +
>   drivers/media/platform/qcom/camss/camss-tpg-gen1.c | 219 +++++++
>   drivers/media/platform/qcom/camss/camss-tpg.c      | 696 +++++++++++++++++++++
>   drivers/media/platform/qcom/camss/camss-tpg.h      | 125 ++++
>   drivers/media/platform/qcom/camss/camss.c          | 130 ++++
>   drivers/media/platform/qcom/camss/camss.h          |   5 +
>   10 files changed, 1226 insertions(+), 14 deletions(-)
> ---
> base-commit: 6afac82056e38e02266cd30f458b25a1f9017508
> change-id: 20250822-camss_tpg-718db678d984
> 
> Best regards,

Gently reminder to Bryan.

Thanks,
Wenmeng