From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Wenmeng Liu <quic_wenmliu@quicinc.com>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 3/3] media: qcom: camss: tpg: Add TPG support for SA8775P and QCS8300
Date: Wed, 3 Sep 2025 14:16:30 +0200 [thread overview]
Message-ID: <d40c5ab2-2195-462f-9fd4-8c519a43f032@oss.qualcomm.com> (raw)
In-Reply-To: <20250822-camss_tpg-v3-3-c7833a5f10d0@quicinc.com>
On 8/22/25 2:09 PM, Wenmeng Liu wrote:
> Add support for TPG found on SA8775P and QCS8300.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
[...]
> +#define TPG_HW_VERSION 0x0
> +#define HW_VERSION_STEPPING 0
> +#define HW_VERSION_REVISION 16
> +#define HW_VERSION_GENERATION 28
Please use GENMASK for defining bitfields, avoid tabs (just a space
is fine, perhaps add one in front of #define to denote bitfields) and
use FIELD_PREP/FIELD_GET accessors
Konrad
next prev parent reply other threads:[~2025-09-03 12:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 12:09 [PATCH v3 0/3] media: qcom: camss: Add sa8775p camss TPG support Wenmeng Liu
2025-08-22 12:09 ` [PATCH v3 1/3] media: qcom: camss: Add support for TPG common Wenmeng Liu
2025-08-22 12:09 ` [PATCH v3 2/3] media: qcom: camss: Add link " Wenmeng Liu
2025-08-22 12:09 ` [PATCH v3 3/3] media: qcom: camss: tpg: Add TPG support for SA8775P and QCS8300 Wenmeng Liu
2025-09-03 12:16 ` Konrad Dybcio [this message]
2025-09-05 7:09 ` Wenmeng Liu
2025-09-17 10:16 ` [PATCH v3 0/3] media: qcom: camss: Add sa8775p camss TPG support Wenmeng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d40c5ab2-2195-462f-9fd4-8c519a43f032@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=bryan.odonoghue@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_wenmliu@quicinc.com \
--cc=rfoss@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®