From: "Rafał Miłecki" <rafal@milecki.pl>
To: Jon Mason <jon.mason@broadcom.com>
Cc: David Miller <davem@davemloft.net>,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] net: ethernet: bgmac: unify code of the same family
Date: Fri, 03 Feb 2017 22:48:15 +0100 [thread overview]
Message-ID: <cdd5a5472af15d6da11e80306424d8b9@milecki.pl> (raw)
In-Reply-To: <1486157970-6315-3-git-send-email-jon.mason@broadcom.com>
On 2017-02-03 22:39, Jon Mason wrote:
> BCM471X and BCM535X are of the same family (from what I can derive from
> internal documents). Group them into the case statement together,
> which
> results in more code reuse.
>
> Also, use existing helper variables to make the code a little more
> readable too.
>
> Signed-off-by: Jon Mason <jon.mason@broadcom.com>
I'd like to review it / test it on few devices. Please give me weekend
for
that.
next prev parent reply other threads:[~2017-02-03 23:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 21:39 [PATCH net-next 0/3] net: ethernet: bgmac: PM support and clean-ups Jon Mason
2017-02-03 21:39 ` [PATCH 1/3] net: ethernet: bgmac: use #defines for MAX size Jon Mason
2017-02-03 21:39 ` [PATCH 2/3] net: ethernet: bgmac: unify code of the same family Jon Mason
2017-02-03 21:48 ` Rafał Miłecki [this message]
2017-02-03 22:35 ` Jon Mason
2017-02-03 21:39 ` [PATCH 3/3] net: ethernet: bgmac: driver power manangement Jon Mason
2017-02-04 2:16 ` Florian Fainelli
2017-02-06 16:30 ` Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdd5a5472af15d6da11e80306424d8b9@milecki.pl \
--to=rafal@milecki.pl \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=jon.mason@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®