From: Jo Van Bulck <jo.vanbulck@cs.kuleuven.be>
To: Sohil Mehta <sohil.mehta@intel.com>,
linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com,
luto@kernel.org, peterz@infradead.org, mingo@redhat.com
Cc: x86@kernel.org, bp@alien8.de, tglx@linutronix.de, hpa@zytor.com
Subject: Re: [PATCH RESEND] x86/pti: Fix kernel warnings for pti= and nopti cmdline options.
Date: Fri, 11 Aug 2023 14:20:33 -0700 [thread overview]
Message-ID: <ce0185e8-4f5c-cff5-4e17-b967f133bc91@cs.kuleuven.be> (raw)
In-Reply-To: <c22d7613-fb2e-11ec-9544-a39ffc7fd955@intel.com>
On 11.08.23 12:13, Sohil Mehta wrote:> Based on above, even when you
split the if check only a single print
> would be enough, right?
Yes, I agree these both cases can simply print "disabled on command
line." (as in the original code) IMHO
> I don't believe that is a requirement either. Sometimes kernel command
> lines can get very long and people make mistakes. I just thought it is
> neat that the current code is defaulting that way and we should probably
> keep the same behavior since it makes sense.
Makes sense indeed.
> I agree, in both cases pti= overriding the other option (nopti or
> mitigations=off) sounds reasonable to me.
I prepared a revised patch for this and will post this shortly.
Best,
Jo
prev parent reply other threads:[~2023-08-11 21:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 19:56 Jo Van Bulck
2023-08-09 0:13 ` Sohil Mehta
2023-08-11 18:23 ` Jo Van Bulck
2023-08-11 19:13 ` Sohil Mehta
2023-08-11 21:20 ` Jo Van Bulck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce0185e8-4f5c-cff5-4e17-b967f133bc91@cs.kuleuven.be \
--to=jo.vanbulck@cs.kuleuven.be \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sohil.mehta@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®