mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Moteen Shah <m-shah@ti.com>
To: Sen Wang <sen@ti.com>, <peter.ujfalusi@gmail.com>,
	<broonie@kernel.org>, <lgirdwood@gmail.com>, <perex@perex.cz>,
	<tiwai@suse.com>, <linux-sound@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: <devarsht@ti.com>, <r-donadkar@ti.com>, <s-jain1@ti.com>
Subject: Re: [PATCH] ASoC: ti: davinci-mcasp: Add system suspend/resume support
Date: Wed, 18 Feb 2026 14:57:01 +0530	[thread overview]
Message-ID: <ce225f6f-153d-44bf-a3f4-55fd9dd42ab1@ti.com> (raw)
In-Reply-To: <20260211221001.155843-1-sen@ti.com>


On 12/02/26 03:40, Sen Wang wrote:
> The McASP driver supports runtime PM callbacks for register save/restore
> during device idle, but doesn't provide system suspend/resume callbacks.
> This causes audio to fail to resume after system suspend.
>
> Since the driver already handles runtime suspend & resume, we can reuse
> existing runtime PM logics.
>
> Signed-off-by: Sen Wang <sen@ti.com>
> ---
> Tested on SK-AM62Px with audio playback during system suspend/resume cycles
>
> Testlog:
>    https://gist.github.com/SenWang125/065c2840071f2569a79db9e99010603f
>
>   sound/soc/ti/davinci-mcasp.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/ti/davinci-mcasp.c b/sound/soc/ti/davinci-mcasp.c
> index 8a2977093df1..643661ebee83 100644
> --- a/sound/soc/ti/davinci-mcasp.c
> +++ b/sound/soc/ti/davinci-mcasp.c
> @@ -2811,6 +2811,8 @@ static int davinci_mcasp_runtime_resume(struct device *dev)
>   #endif
>   
>   static const struct dev_pm_ops davinci_mcasp_pm_ops = {
> +	SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
> +				pm_runtime_force_resume)
>   	SET_RUNTIME_PM_OPS(davinci_mcasp_runtime_suspend,
>   			   davinci_mcasp_runtime_resume,
>   			   NULL)

Tested on j784s4.
Logs: https://gist.github.com/Jamm02/8ed69ad1c9b3a4f0cda4977cc18e01b8

Tested-by: Moteen Shah <m-shah@ti.com>

Regards,
Moteen


  parent reply	other threads:[~2026-02-18  9:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-11 22:10 Sen Wang
2026-02-17  5:33 ` Péter Ujfalusi
2026-02-17 10:04 ` devarsh
2026-02-17 22:26 ` Kendall Willis
2026-02-18  9:27 ` Moteen Shah [this message]
2026-02-25 19:06 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce225f6f-153d-44bf-a3f4-55fd9dd42ab1@ti.com \
    --to=m-shah@ti.com \
    --cc=broonie@kernel.org \
    --cc=devarsht@ti.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=peter.ujfalusi@gmail.com \
    --cc=r-donadkar@ti.com \
    --cc=s-jain1@ti.com \
    --cc=sen@ti.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®