mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ASoC: ti: davinci-mcasp: Add system suspend/resume support
@ 2026-02-11 22:10 Sen Wang
  2026-02-17  5:33 ` Péter Ujfalusi
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Sen Wang @ 2026-02-11 22:10 UTC (permalink / raw)
  To: peter.ujfalusi, broonie, lgirdwood, perex, tiwai, linux-sound,
	linux-kernel
  Cc: devarsht, r-donadkar, s-jain1, m-shah, Sen Wang

The McASP driver supports runtime PM callbacks for register save/restore
during device idle, but doesn't provide system suspend/resume callbacks.
This causes audio to fail to resume after system suspend.

Since the driver already handles runtime suspend & resume, we can reuse
existing runtime PM logics.

Signed-off-by: Sen Wang <sen@ti.com>
---
Tested on SK-AM62Px with audio playback during system suspend/resume cycles

Testlog:
  https://gist.github.com/SenWang125/065c2840071f2569a79db9e99010603f

 sound/soc/ti/davinci-mcasp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/ti/davinci-mcasp.c b/sound/soc/ti/davinci-mcasp.c
index 8a2977093df1..643661ebee83 100644
--- a/sound/soc/ti/davinci-mcasp.c
+++ b/sound/soc/ti/davinci-mcasp.c
@@ -2811,6 +2811,8 @@ static int davinci_mcasp_runtime_resume(struct device *dev)
 #endif
 
 static const struct dev_pm_ops davinci_mcasp_pm_ops = {
+	SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
+				pm_runtime_force_resume)
 	SET_RUNTIME_PM_OPS(davinci_mcasp_runtime_suspend,
 			   davinci_mcasp_runtime_resume,
 			   NULL)
-- 
2.43.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: ti: davinci-mcasp: Add system suspend/resume support
  2026-02-11 22:10 [PATCH] ASoC: ti: davinci-mcasp: Add system suspend/resume support Sen Wang
@ 2026-02-17  5:33 ` Péter Ujfalusi
  2026-02-17 10:04 ` devarsh
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Péter Ujfalusi @ 2026-02-17  5:33 UTC (permalink / raw)
  To: Sen Wang, broonie, lgirdwood, perex, tiwai, linux-sound, linux-kernel
  Cc: devarsht, r-donadkar, s-jain1, m-shah



On 12/02/2026 00:10, Sen Wang wrote:
> The McASP driver supports runtime PM callbacks for register save/restore
> during device idle, but doesn't provide system suspend/resume callbacks.
> This causes audio to fail to resume after system suspend.
> 
> Since the driver already handles runtime suspend & resume, we can reuse
> existing runtime PM logics.

Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>

> 
> Signed-off-by: Sen Wang <sen@ti.com>
> ---
> Tested on SK-AM62Px with audio playback during system suspend/resume cycles
> 
> Testlog:
>   https://gist.github.com/SenWang125/065c2840071f2569a79db9e99010603f
> 
>  sound/soc/ti/davinci-mcasp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/ti/davinci-mcasp.c b/sound/soc/ti/davinci-mcasp.c
> index 8a2977093df1..643661ebee83 100644
> --- a/sound/soc/ti/davinci-mcasp.c
> +++ b/sound/soc/ti/davinci-mcasp.c
> @@ -2811,6 +2811,8 @@ static int davinci_mcasp_runtime_resume(struct device *dev)
>  #endif
>  
>  static const struct dev_pm_ops davinci_mcasp_pm_ops = {
> +	SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
> +				pm_runtime_force_resume)
>  	SET_RUNTIME_PM_OPS(davinci_mcasp_runtime_suspend,
>  			   davinci_mcasp_runtime_resume,
>  			   NULL)

-- 
Péter


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: ti: davinci-mcasp: Add system suspend/resume support
  2026-02-11 22:10 [PATCH] ASoC: ti: davinci-mcasp: Add system suspend/resume support Sen Wang
  2026-02-17  5:33 ` Péter Ujfalusi
@ 2026-02-17 10:04 ` devarsh
  2026-02-17 22:26 ` Kendall Willis
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: devarsh @ 2026-02-17 10:04 UTC (permalink / raw)
  To: Sen Wang, peter.ujfalusi, broonie, lgirdwood, perex, tiwai,
	linux-sound, linux-kernel
  Cc: r-donadkar, s-jain1, m-shah

On 12/02/26 03:40, Sen Wang wrote:
> The McASP driver supports runtime PM callbacks for register save/restore
> during device idle, but doesn't provide system suspend/resume callbacks.
> This causes audio to fail to resume after system suspend.
> 
> Since the driver already handles runtime suspend & resume, we can reuse
> existing runtime PM logics.
> 
> Signed-off-by: Sen Wang <sen@ti.com>

Reviewed-by: Devarsh Thakkar <devarsht@ti.com>

Regards
Devarsh
> ---
> Tested on SK-AM62Px with audio playback during system suspend/resume cycles
> 
> Testlog:
>   https://gist.github.com/SenWang125/065c2840071f2569a79db9e99010603f
> 
>  sound/soc/ti/davinci-mcasp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/ti/davinci-mcasp.c b/sound/soc/ti/davinci-mcasp.c
> index 8a2977093df1..643661ebee83 100644
> --- a/sound/soc/ti/davinci-mcasp.c
> +++ b/sound/soc/ti/davinci-mcasp.c
> @@ -2811,6 +2811,8 @@ static int davinci_mcasp_runtime_resume(struct device *dev)
>  #endif
>  
>  static const struct dev_pm_ops davinci_mcasp_pm_ops = {
> +	SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
> +				pm_runtime_force_resume)
>  	SET_RUNTIME_PM_OPS(davinci_mcasp_runtime_suspend,
>  			   davinci_mcasp_runtime_resume,
>  			   NULL)


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: ti: davinci-mcasp: Add system suspend/resume support
  2026-02-11 22:10 [PATCH] ASoC: ti: davinci-mcasp: Add system suspend/resume support Sen Wang
  2026-02-17  5:33 ` Péter Ujfalusi
  2026-02-17 10:04 ` devarsh
@ 2026-02-17 22:26 ` Kendall Willis
  2026-02-18  9:27 ` Moteen Shah
  2026-02-25 19:06 ` Mark Brown
  4 siblings, 0 replies; 6+ messages in thread
From: Kendall Willis @ 2026-02-17 22:26 UTC (permalink / raw)
  To: Sen Wang, peter.ujfalusi, broonie, lgirdwood, perex, tiwai,
	linux-sound, linux-kernel
  Cc: devarsht, r-donadkar, s-jain1, m-shah

On 2/11/26 16:10, Sen Wang wrote:
> The McASP driver supports runtime PM callbacks for register save/restore
> during device idle, but doesn't provide system suspend/resume callbacks.
> This causes audio to fail to resume after system suspend.
> 
> Since the driver already handles runtime suspend & resume, we can reuse
> existing runtime PM logics.
> 
> Signed-off-by: Sen Wang <sen@ti.com>
> ---
> Tested on SK-AM62Px with audio playback during system suspend/resume cycles
> 
> Testlog:
>    https://gist.github.com/SenWang125/065c2840071f2569a79db9e99010603f
> 
>   sound/soc/ti/davinci-mcasp.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/ti/davinci-mcasp.c b/sound/soc/ti/davinci-mcasp.c
> index 8a2977093df1..643661ebee83 100644
> --- a/sound/soc/ti/davinci-mcasp.c
> +++ b/sound/soc/ti/davinci-mcasp.c
> @@ -2811,6 +2811,8 @@ static int davinci_mcasp_runtime_resume(struct device *dev)
>   #endif
>   
>   static const struct dev_pm_ops davinci_mcasp_pm_ops = {
> +	SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
> +				pm_runtime_force_resume)
>   	SET_RUNTIME_PM_OPS(davinci_mcasp_runtime_suspend,
>   			   davinci_mcasp_runtime_resume,
>   			   NULL)

Reviewed-by: Kendall Willis <k-willis@ti.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: ti: davinci-mcasp: Add system suspend/resume support
  2026-02-11 22:10 [PATCH] ASoC: ti: davinci-mcasp: Add system suspend/resume support Sen Wang
                   ` (2 preceding siblings ...)
  2026-02-17 22:26 ` Kendall Willis
@ 2026-02-18  9:27 ` Moteen Shah
  2026-02-25 19:06 ` Mark Brown
  4 siblings, 0 replies; 6+ messages in thread
From: Moteen Shah @ 2026-02-18  9:27 UTC (permalink / raw)
  To: Sen Wang, peter.ujfalusi, broonie, lgirdwood, perex, tiwai,
	linux-sound, linux-kernel
  Cc: devarsht, r-donadkar, s-jain1


On 12/02/26 03:40, Sen Wang wrote:
> The McASP driver supports runtime PM callbacks for register save/restore
> during device idle, but doesn't provide system suspend/resume callbacks.
> This causes audio to fail to resume after system suspend.
>
> Since the driver already handles runtime suspend & resume, we can reuse
> existing runtime PM logics.
>
> Signed-off-by: Sen Wang <sen@ti.com>
> ---
> Tested on SK-AM62Px with audio playback during system suspend/resume cycles
>
> Testlog:
>    https://gist.github.com/SenWang125/065c2840071f2569a79db9e99010603f
>
>   sound/soc/ti/davinci-mcasp.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/ti/davinci-mcasp.c b/sound/soc/ti/davinci-mcasp.c
> index 8a2977093df1..643661ebee83 100644
> --- a/sound/soc/ti/davinci-mcasp.c
> +++ b/sound/soc/ti/davinci-mcasp.c
> @@ -2811,6 +2811,8 @@ static int davinci_mcasp_runtime_resume(struct device *dev)
>   #endif
>   
>   static const struct dev_pm_ops davinci_mcasp_pm_ops = {
> +	SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
> +				pm_runtime_force_resume)
>   	SET_RUNTIME_PM_OPS(davinci_mcasp_runtime_suspend,
>   			   davinci_mcasp_runtime_resume,
>   			   NULL)

Tested on j784s4.
Logs: https://gist.github.com/Jamm02/8ed69ad1c9b3a4f0cda4977cc18e01b8

Tested-by: Moteen Shah <m-shah@ti.com>

Regards,
Moteen


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ASoC: ti: davinci-mcasp: Add system suspend/resume support
  2026-02-11 22:10 [PATCH] ASoC: ti: davinci-mcasp: Add system suspend/resume support Sen Wang
                   ` (3 preceding siblings ...)
  2026-02-18  9:27 ` Moteen Shah
@ 2026-02-25 19:06 ` Mark Brown
  4 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2026-02-25 19:06 UTC (permalink / raw)
  To: peter.ujfalusi, lgirdwood, perex, tiwai, linux-sound,
	linux-kernel, Sen Wang
  Cc: devarsht, r-donadkar, s-jain1, m-shah

On Wed, 11 Feb 2026 16:10:01 -0600, Sen Wang wrote:
> The McASP driver supports runtime PM callbacks for register save/restore
> during device idle, but doesn't provide system suspend/resume callbacks.
> This causes audio to fail to resume after system suspend.
> 
> Since the driver already handles runtime suspend & resume, we can reuse
> existing runtime PM logics.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: ti: davinci-mcasp: Add system suspend/resume support
      commit: 5879521cb558871472b97c4744dbe634a4286f0e

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-02-25 19:06 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-11 22:10 [PATCH] ASoC: ti: davinci-mcasp: Add system suspend/resume support Sen Wang
2026-02-17  5:33 ` Péter Ujfalusi
2026-02-17 10:04 ` devarsh
2026-02-17 22:26 ` Kendall Willis
2026-02-18  9:27 ` Moteen Shah
2026-02-25 19:06 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®